Commit Graph

191 Commits

Author SHA1 Message Date
Tom Hacohen c788486398 Automatic migration to the new eo_add syntax. 2016-03-09 16:09:17 +00:00
Tom Hacohen 75569ec561 Fix warnings following migration to Eo4.
Mostly unused variables.
2016-03-03 10:08:27 +00:00
Tom Hacohen d16aa5956b Automatic migration to Eo4.
I just ran my script (email to follow) to migrate all of the EFL
automatically. This commit is *only* the automatic conversion, so it can
be easily reverted and re-run.
2016-03-03 10:08:27 +00:00
Cedric BAIL 8dacdb465a scroller: prevent the use of uninitialized data in some case. 2016-02-02 11:00:54 -08:00
Marcel Hollerbach 860baa4657 Elm config: use a name instead of elm_widget_type_get
Summary:
The use of elm_widget_type_get here is pretty harmfull, for the usecase
of inheriting a widget elm_widget_type_get is something else than
before. But the key binding should still work.

@fix T2891

Reviewers: tasn

Reviewed By: tasn

Maniphest Tasks: T2891

Differential Revision: https://phab.enlightenment.org/D3470
2015-12-21 12:57:15 +00:00
Jaehwan Kim fd5b78b7da focus: change the focus don't stay to scroller.
The focus go to scroller only when it needs.
If the focusable object isn't in the current viewport of the scroller,
the scroller should have the focus.
If not, the focus move to the focusable object in the scroller.

@feature.
2015-09-25 15:45:03 +09:00
Jaehwan Kim 0dedfc9248 focus: add the APIs to set the focus next about item.
Add elm_object_focus_next_item_set/get,
elm_object_item_focus_next_object_set/get and
elm_object_item_focus_next_item_set/get.

If the item and object is set at the same time,
the item is preference to object when the focus moves.

This feature is implemented about gengrid.
It will be implemented about ohter widgets.

@feature
2015-09-15 19:53:23 +09:00
Carsten Haitzler be2ae5f410 elm autofocus show - fix cases where focus is inside containers
i found that the focus doesnt auto-show when focusing things inside
scrollers and so on. i had to add more points to trigger auto show.
this fixes that

@fix
2015-09-10 18:29:24 +09:00
Amitesh Singh fe271ff8e6 scroller: fix memory leak on keys traversal
@fix
2015-08-25 09:35:05 +05:30
Jaehwan Kim bb6ac8852b scroller: fix the misstake. change && -> ||
@fix
2015-08-24 13:38:19 +09:00
Jaehwan Kim a905e7a33b scroller: fix the focus move bug in scroller.
When the focused object is out of the viewport and the key direction
is only the direction focus is out, it should find the next focus.

@fix
2015-08-11 20:53:14 +09:00
Umesh Tanwar d9c18d9814 Scroller: Improvement in _key_action_move() calculations.
Summary:
If x coordinate is equal to 0, key action is no more
effective as EINA_FALSE is returned. This is creating problem
in looping. Looping will be done when x < 0, but as soon as
x == 0, _key_action_move starts returning EINA_FALSE. Same
thing applies to y coordinate and other extremities.

@fix

Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>

Test Plan: elementary_test -> Scroller -> Loop in X axis -> scroll left using left key(looping does not happen)

Reviewers: raster, Hermet, cedric, singh.amitesh, SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: sachin.dev, SanghyeonLee, eagleeye

Differential Revision: https://phab.enlightenment.org/D2778
2015-07-19 23:40:50 +09:00
Avi Levin 54a1748486 elm_scroller: porting evas smart callbacks to eo 2015-07-05 13:05:38 +03:00
Daniel Kolesa 3904cc7175 elm: constify Eolian methods correctly because of recent Eolian changes 2015-06-25 12:21:00 +01:00
Umesh Tanwar 7c71953733 elm_scroller: add wheel_disable_set API
Summary:
This API can be used by widgets like Genlist/Gengrid, which implements
Elm_Interface_Scrollable interface.Mouse wheel is used to scroll up and
down on widget.

@feature

Test Plan: elementary_test -> Scroller -> Wheel Disable

Reviewers: raster, Hermet, cedric, SanghyeonLee, singh.amitesh

Subscribers: JackDanielZ, herdsman, cedric, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2715

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Tom Hacohen 27b72840c8 Adjust usage of eo_constructor() according to recent changes. 2015-05-20 13:03:28 +01:00
Jean-Philippe Andre 315175083b colorselector,scroller: Check return value of elm_layout_theme_set
Fixes:
- CID1273968
- CID1291831
2015-04-07 15:26:46 +09:00
Cedric BAIL df4c3bbb7d evas: let's not use eo_do for potential Efl interface call. 2015-04-03 16:04:58 +02:00
Jaehwan Kim 1925ec3b8e scroller: add loop feature.
This feature works the infinite loop horizontally or vertically.
If the content is set, it will be shown repeatedly.
@feature

Change-Id: I1f20b794ae44bc8e5d120901222c7cccadca96b7

Conflicts:
	src/lib/elm_scroller.c
	src/lib/elm_scroller_legacy.h
2015-03-23 20:35:04 +09:00
Hosang Kim 008f37e18e Scroller: Add step size set API
Summary:
Application do not change step size because only interface API is existed.

@feature

Test Plan: elementary_test -> scroller -> change step size

Reviewers: seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D1677
2014-11-20 20:29:41 +09:00
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Lukasz Stanislawski 09b9ef0bc0 atspi: expose more actions through atspi bus.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.

Reviewers: z.kosinski

Reviewed By: z.kosinski

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1227
2014-07-25 11:58:16 +02:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Carsten Haitzler 9d55fab418 entry: wrong viewport value calculation issue fix
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.

solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.

signed-off by: Shilpa Singh <shilpa.singh@samsung.com>

@fix

Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.

Reviewers: jaehwan, woohyun, seoz, Hermet, raster

CC: govi, rajeshps, thiepha

Differential Revision: https://phab.enlightenment.org/D674
2014-04-21 12:31:49 +09:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Daniel Juyung Seo 11ad4e125d scroller: Initialized some internal variables.
This fixes coverity CID 1199657, 1199622, 1199621, 1199620.

@fix
2014-04-13 01:58:43 +09:00
Tom Hacohen a7c5d02257 Adjust code to use the slightly different Eo2 API.
With Eo2 you can return values directly without the need to use a pointer
(use the C return).

For example:
eo_do(obj, elm_object_text_get(&text));
becomes:
eo_do(obj, text = elm_object_text_get());

@feature
2014-04-10 09:49:22 +01:00
Tom Hacohen cbf43225f1 scroller: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Jaeun Choi 624b278c44 scroller: apply key binding
Summary: This patch applies key binding to elm_scroller.

Test Plan: elementary_test > Scroller > check key events

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D711
2014-04-10 17:10:00 +09:00
Daniel Zaoui c76581ca44 Eolian: Integration of Scroller 2014-03-31 09:08:42 +03:00
ChunEon Park f28c0a5259 scroller content type is not always widget. 2014-03-22 14:40:48 +09:00
Daniel Juyung Seo 77dfd41b76 scroller: Fixed wrong widget call to non-widget object.
content can be a non-widget object.
2014-03-20 02:13:03 +09:00
Daniel Zaoui 7460467419 Eolian: Integration of Scrollable Interface 2014-03-18 08:14:44 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
WooHyun Jung 0a1179dde4 elm_layout now supports focused/unfocused smart callback
by itself for widgets that inherit layout class.
If it uses elm_widget's, smart callback will be called at the
beginning or smart_on_focus function.
2014-02-06 16:18:57 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Tom Hacohen 877abee7fe Elm scroller: prevent usage of uninitialized vars as reported by valgrind.
This improves the terminology crash rate a bit.
2013-11-28 16:33:46 +00:00
Tom Hacohen be207937f5 Elm scroller: _movement_block_get fix return val on error.
It was returning ELM_SCROLLER_SINGLE_DIRECTION_NONE instead of
ELM_SCROLLER_MOVEMENT_NO_BLOCK.
Looks like a c&p error.
2013-11-28 16:17:15 +00:00
WooHyun Jung 2920eda9e5 elementary/elm_scroller.c : For checking focus next object, focus_direcion_get function should be changed to focus_next_get function. If there is no focus next object, focus_direction_get will be executed by focus_next_get. 2013-11-21 10:13:40 +09:00
Daniel Juyung Seo a480745321 scroller, slider: fixed wrong changed I made by 6a683df1598a4c3293a33765cc60dd
I caused by c&p bug.
Special thanks to stefan and coverity.
This fixes coverity CID 1128353 and 1128354.
2013-11-15 22:51:10 +09:00
Daniel Juyung Seo b75a880c6c button,inwin,radio,scroller,slider: Do not call smart_activate when the widget is disabled. 2013-11-08 21:49:52 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Daniel Juyung Seo c40fbd89b8 elm: Use ELM_LAYOUT_DATA_GET convenient macro instead of calling eo_data_scope_get(obj, ELM_OBJ_LAYOUT_CLASS). 2013-10-05 17:29:13 +09:00