There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.
SVN revision: 82228
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
On Tue, Dec 11, 2012 at 8:46 PM, SHILPA ONKAR SINGH <shilpa.singh@samsung.com> wrote:
Hi All,
Please find attached bug fix patch for Colorselector.
This patch fixes the resize issue in palette which happens when
palette item size is given more than finger size.
This patch also fixes a fixed: 1 1 warning shown in picker(New addition to colorselector).
This warning can be seen when we shift from "both mode"(palette+component) to picker
mode and back to both mode.
Change description:
elm_colorselector: Palette items resize issue when item size is more than finger size and fixed: 1 1 warning in picker
fixed.
Signed-Off by: Shilpa Singh(shilpa.singh@samsung.com)
Thanks & Regards
Shilpa Singh
SVN revision: 80937
Subject: [E-devel] [patch][elementary] * access *
Series of of pathes from kim shinwoo. looked good to me - so in they
go, finishing off some more access mode to be more complete.
SVN revision: 75415
Attached to the mail is a patch for fixing issues
1. "bg edje object not deleted on deleting colorselector"
2. Theme hook fixed to read data items.
Existing Issue:
bg edje object of colorselector not deleted and data items not read again on theme hook.
Change Description:
1. elm_colorselector's edje object not deleted issue fix.
2. Theme hook updated to read data items again.
Signed-Off-By : ShilpaOnkar Singh <shilpa.singh@samsung.com>
SVN revision: 69459
edjeobject, not elm_button. This patch will change all button
edje_objects to real elm_button. And long_press will be supported by
elm_button's autorepeat feature. (This patch was made by Shilpa. Thanks)
SVN revision: 64931
structure.
'canvas' and 'output' are same. So we need to deprecate one of them
later(may be evas 2.0 or so.) After I discuss this with raster, I've
got to use 'canvas' not 'output'. So I fixed elementary codes.
SVN revision: 60268
Daniel Juyung Seo
Daniel Juyung Seo
Chris Michael
Cedric Bail
Daniel Zaoui
Yossi Kantor
Tom Hacohen
Gustavo Lima Chaves
Shinwoo Kim
ChunEon Park
Yakov Goldberg
Cedric BAIL
Carsten Haitzler
Hannes Janetzek
ShilpaOnkar Singh
Jihoon Kim
WooHyun Jung
Jonas M. Gastal