Commit Graph

131 Commits

Author SHA1 Message Date
Jee-Yong Um 4ade3552db elm_image: Fixed to have exact size using elm_image_fill_outside_set()
Summary:
There was a problem that image is stretched over its size
when elm_image_fill_outside_set() is applied.
This patch fixed that.

@fix

Reviewers: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D1854
2015-01-08 15:47:24 +09:00
Mike Blumenkrantz 799171a0c8 elm_image now inherits edje signal emit
@feature
2015-01-06 15:19:26 -05:00
jiin.moon c3397d302b image: fix clipped image issue if x or y is less than zero
Summary:
After applying clipping patch about image on outside,
the width or height of the image be decreased
if x or y of an image is less than zero.
The way to calculate width/height has changed.

This fixes a side effect added in 2839881f37ea85b3469d8fd37cfaa4f9d67458fa

Reviewers: Hermet

Differential Revision: https://phab.enlightenment.org/D1810
2014-12-24 14:10:05 +09:00
Daniel Juyung Seo 82eb0a210c image: Fix formatting for the latest commit 283988. 2014-12-19 02:36:16 +09:00
jiin.moon fe3bacf30a elm/image: Fix an unclipped issue about image bigger than object size
Summary:
When resizes an image
if "fill_inside" and "aspect_fixed" in Elm_Image_Data struct are "TRUE",
extra width or height go outside of the object area.
The width or height on outside will be clipped.
@fix

Reviewers: Hermet

Differential Revision: https://phab.enlightenment.org/D1794
2014-12-18 17:53:44 +09:00
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Mike Blumenkrantz 8391f8a860 elm_image no longer crashes when deleting the image from a download callback 2014-10-09 16:52:17 -04:00
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Tom Hacohen 307e03c1b1 Image: Use image interface. 2014-08-21 11:04:28 +01:00
Tom Hacohen 4cc392ce5e Image: Use file interface. 2014-08-21 11:04:28 +01:00
Lukasz Stanislawski 09b9ef0bc0 atspi: expose more actions through atspi bus.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.

Reviewers: z.kosinski

Reviewed By: z.kosinski

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1227
2014-07-25 11:58:16 +02:00
Lukasz Stanislawski f9ad7f921a atspi: expose elm_image "activate" action through d-bus 2014-07-15 16:45:55 +02:00
Yakov Goldberg 4f0bc40b91 image: fix segv in elm_image_file_set() 2014-07-08 16:34:23 +03:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Lukasz Stanislawski f4f2bbdbcd atspi: add AtspiImage interface support.
Summary: Sample implementation for elm_image added.

Reviewers: raster, seoz

Differential Revision: https://phab.enlightenment.org/D794
2014-05-27 16:23:13 +09:00
ChunEon Park a9c718361a image - null checking.
If the rotated image exceeds image maximum size, the data would be invalid.
2014-05-21 13:24:32 +09:00
Daniel Juyung Seo 8ffbf246f4 elm: fixed trivial formattings.
Just found them while reading codes.
2014-05-10 23:44:27 +09:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Jaeun Choi 3449c44221 image: apply key binding
Summary: This patch applies key binding to elm_image.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D732
2014-04-15 14:49:35 +09:00
Tom Hacohen 687762a344 image: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Daniel Zaoui fceca47f28 Eolian: Integration of Image 2014-03-23 14:17:38 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Daniel Juyung Seo 5f0ca660b4 elm: Unified the usage of strncmp.
- Use strlen instead of sizeof(x) - 1 for string length calculation.
- Use !strncmp for null check.
2014-01-27 02:07:44 +09:00
Jihoon Kim 54ec084e76 fix some typos in comment and description 2014-01-22 13:20:15 +09:00
Daniel Juyung Seo 5353aa863c elm: Removed unnecessary null check for free. 2014-01-22 11:13:11 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Daniel Juyung Seo 68eca6d62e url: Added underscore(_) to elm internal functions, elm_url_xxx.
- _elm_url_download, _elm_url_cancel, _elm_url_get
- other internal functions in elm_priv.h also have same prefix.
2014-01-21 23:23:37 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Carsten Haitzler d90886c992 fix alloc to use right sizeof type in elm_image
this should fix CID 1132738 - not a real issue as it still was * 4 but
more obvious and clean after fix
2014-01-09 15:04:46 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo f232ff14be image: Remove unnecessary parameter for elm_obj_image_editable_set.
This parameter was introduced as an internal funciton parameter long ago and migrated to eo as it was.
But this parameter is not needed. obj pointer is already there.

Thanks to Yakov for the report.
2014-01-02 09:21:16 +09:00
Jihoon Kim 2f3525f518 image: add NULL check 2013-12-31 11:36:43 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
ChunEon Park 45ed80a0c8 image - fix the elm_image_prescale_set() to work properly.
before this, it had the insane logic so the prescale_set() never work.
Now, it works well and the prescale won't be set in default. (before, the default value is 64. why?)
2013-11-25 20:48:22 +09:00
Daniel Juyung Seo 5567837cf5 button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it.
Now they look more consistent.
2013-11-13 09:54:37 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Zaoui b66233d128 DnD: multi-callbacks support
This features permits execution of more than one set of functions during
DnD.
Delete function API has been modified to give the developer the
possibility to remove a specific set of functions.
2013-11-05 08:28:54 +02:00
Daniel Juyung Seo cee446d308 elm_slider.c, elm_image.c: Removed executable permission from c source.
Please be more careful of file permission.
2013-11-04 22:46:50 +09:00
Cedric Bail 1f442e4a8e elm_image: add mmap_set infrastructure. 2013-11-04 12:19:04 +09:00
Amitesh Singh 72c30bb3e2 [image] - Added support for "clicked" callback on Return/space/KP_Enter key press.
Summary: [image] - Added support for "clicked" callback on Return/space/KP_Enter key press.

Reviewers: seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D278
2013-10-30 08:32:44 +09:00
Daniel Juyung Seo 6397761c6a elm_test: Fixed formatting. tab to space.
Changed tab to space before working on the code.
Kinda surprised by the number of tabs we had.
2013-10-14 19:12:32 +09:00
Daniel Juyung Seo a4fb4efcd7 elm_config/elm_image: Internal small refactoring.
1. Use more ELM_SAFE_FREE macro.
2. Use correct more descriptive macro for timer callback.
2013-10-02 20:18:51 +09:00
Jean-Philippe Andre 6078f040fb elm_image: Fix preload for normal files
grmbl, elm_image must explicitely start preload or the
image will stay blank if evas_object_show() is called before
elm_image_file_set().
2013-10-01 19:09:52 +09:00
Jean-Philippe Andre fada635034 elm_image: Remove double callback on mouse_up
In case of MOUSE_UP event, both the hit rectangle and the
smart image object received the event, thus producing double
clicks.
2013-10-01 19:09:52 +09:00
Daniel Juyung Seo e756f97dae elm: Longwaited trailing white space removal. Clean elm up! 2013-09-30 22:15:01 +09:00
Jean-Philippe Andre 39fe09b137 elm_image: Fix remote image loading
Fixes commit dcb8b54aee3a545a1:
 - elm_image: do not preload full image on file_set.

elementary_test "Image Remote" was not working anymore because
the image was never loaded after download.
2013-09-26 18:57:16 +09:00
Jean-Philippe Andre cdf8137da7 elm_image: do not preload full image on file_set. 2013-09-25 18:39:42 +09:00