Commit Graph

500 Commits

Author SHA1 Message Date
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Jihoon Kim cdec9a9e85 Add elm_entry_input_hint_set/get API
Sets or get the input hint which allows input methods to fine-tune their behavior.
2014-09-01 19:04:05 +09:00
Jérémy Zurcher 33338c53aa fix wrong usage of EINA_FALSE as NULL 2014-08-22 10:20:57 +02:00
ChunEon Park c81683ba5a entry: fix clearing selection region problem while it's already selected.
if entry has selection, it would be cleared if selection region set is requested again.
because entry cancel the selection area after it reset the selection area.
unfortunately, the selection area is new selection so selection area is gone.

this patch prevent clearing selection and keep the new selection.

@fix
2014-08-15 17:44:13 +09:00
Carsten Haitzler f712ac567b elm entry - fix CID 1194480 in coverity
if sd->append_text_left was still set, free it - in case it was and
idler was not set.
2014-08-08 16:16:42 +09:00
yinsc 004bbb2dfc Fix T1289 issue: Elm entry text selection glitch
Summary: Fixes T123

Reviewers: zmike, seoz

CC: yinkair

Maniphest Tasks: T123, T1289

Differential Revision: https://phab.enlightenment.org/D1124
2014-07-07 12:42:43 +09:00
Daniel Kolesa 20525deb55 update according to latest efl changes: _CLASS -> _CLASS/INTERFACE/MIXIN 2014-06-30 21:37:04 +01:00
Daniel Juyung Seo b26413cf32 entry: fixed shadow variable build warnings. 2014-06-19 18:30:21 +09:00
Lukasz Stanislawski 1c350bbfad atspi: typo fix, avoid returning w/o va_end call
Summary:
CID: 1222462
CID: 1222461
CID: 1222465

Reviewers: raster, seoz, z.kosinski

Differential Revision: https://phab.enlightenment.org/D995
2014-06-11 16:05:54 +09:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Lukasz Stanislawski 139c871a72 atspi: add AtspiText and AtspiEditableText interface support.
Summary:
Added reference interface implementation for elm_entry widget. Tests added.
Updated at-spi-constants.h header to version 2.12.0.

Reviewers: raster, seoz

CC: raster

Differential Revision: https://phab.enlightenment.org/D806
2014-06-10 16:18:17 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Thiep Ha 283140a639 entry: update selection handlers' visibility when entry is hidden or shown
Summary:
Selection handlers' visibility should be updated when entry is hidden or shown
When entry has selection and hidden, the selection handlers should be hidden also.
This fix T1175.

@fix

Reviewers: seoz, woohyun, raster

Reviewed By: raster

Maniphest Tasks: T1175

Differential Revision: https://phab.enlightenment.org/D877
2014-05-26 11:28:12 +09:00
Andy Williams ccc06de678 Correctly emit the scroll signal when scrolling an entry @fix T1274.
As the Elm_Entry has replaced the _scroll_cb we need to emit the same signal
(that was the only function of elm_scroller's _scroll_cb)
2014-05-22 22:35:06 +01:00
Youngbok Shin 8730b8d990 entry: Enable context menu with mosue down even if the entry is not editable in some case.
Summary:
Even if a entry is not editable, user can select text in the entry.
When the entry has selection, we have to support "copy" option.
@fix

Test Plan:
Precondition: Apply D852 patch for fixing a bug in elementary_test
1. elementary_test -to entry7
2. Select some text in the non-editable entry.
3. Press mouse right button.

Note: You can test it in Desktop profile.

Reviewers: tasn, woohyun, seoz

Differential Revision: https://phab.enlightenment.org/D848
2014-05-14 13:26:48 +01:00
Daniel Juyung Seo 8ffbf246f4 elm: fixed trivial formattings.
Just found them while reading codes.
2014-05-10 23:44:27 +09:00
Daniel Juyung Seo 44a67054de elm: fixed wrong internal variable name.
Unified the local variable name to ret if the ret is a return value of
another content_unset calls.
- Evas_Object *int_ret --> Evas_Object *ret
- Evas_Object *int_content --> Evas_Object *ret
- Evas_Object *content --> Evas_Object *ret
2014-05-10 14:13:57 +09:00
zmike 07c2da9e2c entry no longer completely breaks focus by focusing itself on selection signal
I don't know why this was added, but it breaks the ability to set focus on any widgets at all under some circumstances. it also is nonsensical since you should never need to set focus while selecting because:

* you are selecting with the mouse button, thereby having previously triggered focus from the mouse click

* you are selecting using api, in which case there's a config option to allow retaining selection which is also conceptually broken by this behavior

@fix
2014-04-26 01:41:15 -04:00
Ryuan Choi 4e4c7e8658 entry: Create selection handles as lazily as possible
Summary:
Moved the construction of selection handles to _update_selection_handler in order to
reduce the cost of construction of elm_entry little bit.

Reviewers: thiepha, Hermet, seoz, raster

CC: seoz, raster

Differential Revision: https://phab.enlightenment.org/D756
2014-04-24 17:52:23 +09:00
Carsten Haitzler 9d55fab418 entry: wrong viewport value calculation issue fix
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.

solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.

signed-off by: Shilpa Singh <shilpa.singh@samsung.com>

@fix

Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.

Reviewers: jaehwan, woohyun, seoz, Hermet, raster

CC: govi, rajeshps, thiepha

Differential Revision: https://phab.enlightenment.org/D674
2014-04-21 12:31:49 +09:00
Tom Hacohen 3a6e755963 entry: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Daniel Zaoui f660fc7456 Eolian: Integration of Entry 2014-03-23 10:56:44 +02:00
Thiep Ha 197458d0f6 [Elm_Entry] Update selection handlers position and its visibility when scrolling
Summary:
Selection handlers' position are not updated when entry is scrolled.
You can check on elementary_test -> Entry 3 (or Entry 4 which is scrollable) -> Select some text -> Scroll entry and see.
This patch is submitted to fix this bug. It update selection handlers' position when entry is scrolled and hide them if needed.
@fix

Reviewers: raster

Differential Revision: https://phab.enlightenment.org/D640
2014-03-20 19:33:42 +09:00
Daniel Zaoui 7460467419 Eolian: Integration of Scrollable Interface 2014-03-18 08:14:44 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Daniel Juyung Seo 2c0c0c335a entry: Use ELM_SAFE_FREE and fixed indentation. 2014-03-16 03:08:19 +09:00
ChunEon Park 549fb6019e entry - fixed calc issue of the wrap none mode.
This deferred recalc job is considered for wrap mode.
if the wrap mode is disabled, this job should be discarded.

since the wrap mode is enabled in default.
the job would be performed even the wrap mode was changed later.

@fix.
2014-03-15 15:40:12 +09:00
ChunEon Park 55827d034d entry - send selection,cleared signal if a selection is dismissed.
when the selection none was requested, the selection won't be cleared without the signal callback.

@fix
2014-03-08 03:54:13 +09:00
Carsten Haitzler 0871e2d2fe entry - fix menu to not popup after every time mobile sel handles are clicked
this fixes a behavior bug in entry @fix cherry-pick-me
2014-03-06 20:14:20 +09:00
Thiep Ha fcd164b4b0 Fix bug of moving cursor handler
Summary:
In elm entry, cursor handlers are placed and moved incorrectly if we do selection from bottom to top.
Ex: In elementary_test -> Entry -> Right click -> choose Select -> do selection from bottom to top (or press Shift + <- keys to do selection).
Look at selection handlers: they are incorrectly placed.
Try to move selection handlers: They suddenly move to near each other.

Minor: Remove unused variable.

@fix

Reviewers: seoz

Differential Revision: https://phab.enlightenment.org/D583
2014-03-06 20:14:11 +09:00
Thiep Ha 8f92069a63 [Elm_Entry] Fix bug: magnifier position is incorrect when mouse down on selection handler
Summary:
Magnifier is displayed incorrectly when mouse down on selection handler

Reproduce way: Right click on entry (eg Entry), choose Select, select some text, press left mouse
on selection handler (do not move the mouse), take a look at magnifier position.
Reason: Magnifier position is set to mouse down position in entry.
Fix: Check mouse down status and place correct position for magnifier.

Reviewers: seoz, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D573
2014-02-22 12:06:31 +09:00
Thiep Ha 771887df2b [Dnd] Fix double text insert issue in elm_entry, drop at disable, non-editable entry
Summary:
Issue 1: If you drop text to elm_entry, text is inserted twice.
Reason: Drop callbacks are registered multiple times in elm_entry.
Resolve: Register only one drop callback at entry side.

Issue 2: Even thought entry is disabled, non-editable, you still can drop text, image file. (Example, run Entry Scrolled and drop text, image file to disabled or non-editable entries).
Reason: Drop callback are registered but not remove when entry is set to disabled, non-editable mode.
Resolve: Correct registering and removing drop callbacks in entry.

Reviewers: JackDanielZ, raster

Reviewed By: raster

CC: woohyun

Differential Revision: https://phab.enlightenment.org/D565
2014-02-19 12:25:08 +09:00
Jaehwan Kim db23689614 access: Add smart signal "access,changed"
It occurs that access mode is changed.
Application can add this callback for each widget.
2014-02-08 14:05:14 +09:00
Tom Hacohen 5174961edd Elm entry: Set initial select mode for non desktop entries.
Initial select mode was not properly set, as was just left to default.

This, in combination with the following from the efl repo:
commit 211845c885
commit c061e76927
fixes T861.
2014-02-07 14:22:37 +00:00
Jihoon Kim ac16bd6fe6 entry: Add elm_entry_select_region_set API
Summary:
in case of GTK, it provides API to select a region of text (gtk_editable_select_region).
However, there are only API to select all or none in EFL.
This API will provide the way to select a region of text.

Test Plan: elementary_test > entry3 > press 'Region' button

Reviewers: woohyun, tasn, id213sin

Reviewed By: tasn

Differential Revision: https://phab.enlightenment.org/D520
2014-02-05 10:16:13 +00:00
Daniel Hirt 2f5a0068fd elm entry: Fix anchor bug finding wrong anchor geometry.
Summary: Fix a bug with finding the proper geometry when reporting anchor
interaction. It's easy to see in entry anchor2 test in elementary_test
when clicking on the lower border of the anchor.

Anchor geometries are relative to the textblock object. The problem was
that this was accounted for using the edje object's geometry instead of
the textblock geometry thus causing an offset.

Reviewers: JackDanielZ, tasn

CC: seoz

Differential Revision: https://phab.enlightenment.org/D436

TAsn: Commit message edited by me.
2014-01-28 14:43:43 +00:00
Daniel Juyung Seo 17e788cc47 entry: Renamed internal macro name with prefix ELM_ENTRY for
consistency.

_CHUNK_SIZE -> ELM_ENTRY_CHUNK_SIZE.
2014-01-23 23:09:28 +09:00
Daniel Juyung Seo 3aeefab17b entry: Used macro for entry delay write time. 2014-01-23 23:08:55 +09:00
ChunEon Park dbacb2fef9 elementary - send signal "language,changed" with one way in the widget.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.

This makes reducing duplicated code and supporting language,chagned from all widgets.
2014-01-23 19:30:34 +09:00
Youngbok Shin 89c3d430a3 entry: Fixed to emit "*enabled" signal to scr_edje when it is not disabled.
Summary: This fixes coverity issue CID 1162751.

Reviewers: seoz, woohyun, tasn

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D482
2014-01-22 11:32:08 +09:00
Daniel Juyung Seo 5353aa863c elm: Removed unnecessary null check for free. 2014-01-22 11:13:11 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
WooHyun Jung 6eb6f805ba entry: NULL should be set to the correct position of tmpbuf.
If edje_object_part_text_get gives different text from original one,
length of text can be changed. So the last position of tmpbuf should
be calculated again refering to the current text to be returned.
2014-01-21 21:00:29 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Youngbok Shin 5de43831aa entry: Add smart activate for accessbility.
Summary:
In TTS mode, when the entry is highlighten and double tap to the entry,
the entry will be focused. But "clicked" smart callback is not called, input panel is not shown.
So I we need to call the callback and show input panel in smart activate.

Reviewers: seoz, Hermet, woohyun, tasn, jaehwan, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D465
2014-01-20 18:45:51 +09:00
Youngbok Shin 0d81887544 entry: If the scrollable entry is set disable, send "*,disabled" signal to scr_edje too.
Summary:
Default theme of entry does not have any disabled state in "elm/scroller/entry/*" styles.
But EFL developer can make any custom style for entry and scroller and it can has disabled state.
So _elm_entry_smart_disable has to emit "*disabled" signal to scr_edje.

Reviewers: woohyun, tasn, seoz, Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D464
2014-01-20 18:04:30 +09:00
Jihoon Kim bf0c4e921a entry: remove duplicated checking variable
'top' variable was checked twice, so it's fixed.
2014-01-14 08:07:22 +09:00
Daniel Juyung Seo 45ee408180 ctxpopup, entry: Check widget type by eo_isa not by evas_object_type
string compare.
2014-01-13 23:14:44 +09:00