Commit Graph

49544 Commits

Author SHA1 Message Date
Carsten Haitzler b26bef48f2 evas cserver client tool - handle possible < 0 sized return
this is cserver so its trusted but handle possible < 0 size msg.
address coverity CID1361243
2016-08-06 16:16:19 +09:00
Carsten Haitzler 2bcb4105e1 pdf loader - check return for rmdir
fixes CID 1361218
2016-08-06 15:59:23 +09:00
Carsten Haitzler 83752435cf eina log - handle possible overflow from high mem (last few bytes) or env
fixes CID 1361219
if you had an env var a few gb in size or we had stuff in the last bit
of memory address space this might be an issue, but that won't happen.

@fix
2016-08-06 15:53:18 +09:00
Carsten Haitzler 20c6bd296b eina log - keep coverity happy with potential ptr comparison overflow
fixes CID 1361220

in theory yes end minus start could be insanely huge or end be very
high in memory thus causing an overflow. this would have to be in the
last few bytes of memory space, so it never going to happen. and the
input from the env var has to be sane anyway as its user controlled.

@fix
2016-08-06 15:50:17 +09:00
Carsten Haitzler 15e34ffe15 embryo_cc - fix coverity complaint about assert
fix assert using a strance assert syntax and go back to basic asserts.
fix coverity CID 1361224

@fix
2016-08-06 15:41:02 +09:00
Stephen Houston 31f351ae4e Eio: Update my email address. 2016-08-05 20:33:27 -05:00
Carsten Haitzler d19cd4e63c eina threadqueue - for paranoia lock+ulock+free in order locks taken
so mimic order of locks taken to be paranoid ... this wouldnt be a
deadlock issue but just to be safe instead of sorry.
2016-08-06 09:56:02 +09:00
Stefan Schmidt 64bf1da8c1 edje: mark new edje_mmap_3d_has() API with since tag 2016-08-05 23:14:57 +02:00
Stefan Schmidt 063c31cb24 ecore_wl2: mark new events with since tag 2016-08-05 23:14:57 +02:00
Stefan Schmidt bb984760cd evas: add missing since tag for new evas_object_type_get() API 2016-08-05 23:14:56 +02:00
Cedric Bail 7e8c6b212d ecore: properly track events in Efl.Loop.Fd object.
Thanks Gustavo.
2016-08-05 12:14:18 -07:00
Cedric Bail a7bb1662e2 Revert "elementary/layout: attach edje object API with eo compositing"
This reverts commit 8a988717e1.

It seems we can't actually inherit from class more than once and neither eo
nor eolian will complain about it. You will just get random weird behavior.
This patch should come back once we have made an interface of edje.
2016-08-05 11:09:55 -07:00
Davide Andreoli a3ad7553c5 Simple test case to spot out a bad bug in elm.Entry
The bug is explained in T4296, basically the "changed" signal in elm.Entry is called randomly.
2016-08-05 19:02:19 +02:00
Carsten Haitzler 26db5d5056 eina thread queue - ensure blocks cannot be freed until lock+unlock
just in case... check blocks cannot be freed until locked and unlocked
just in case someone still is holding a lock.
2016-08-05 23:52:20 +09:00
Stefan Schmidt 0a243671c7 README: clarify poppler dependency
We actually need poppler-cpp which is packaged in various ways in different
distros so better give both names here.
2016-08-05 15:26:02 +02:00
Stefan Schmidt 5db441a6df README: update build dependencies and build instructions
Remove part where we recommend the now merged loaders and players and update
build dependencies as well as recommended options.
2016-08-05 14:35:02 +02:00
Carsten Haitzler 84e4cf7145 ecore imf test - remove unused variable 2016-08-05 20:34:42 +09:00
Carsten Haitzler adc5cd422a ecore eina thread queue test - be anal about thread exiting cleanly 2016-08-05 20:20:25 +09:00
Carsten Haitzler 31e8a528b1 ecore-con - fix complaint about null slave list due to shutdown
so ecore-con already cleared the slaves list on shutdown but an
ecore_thread may stillbe active and thus removing from a NULL slaves
list wont work, so skip if slaves is NULL.

@fix
2016-08-05 19:41:59 +09:00
Carsten Haitzler 4a40ff95de eina lock semaphores - do not use shared semaphores and fix osx names
the way eina does sempahores, they can NEVER be sensibly shared
cross-process portably. so enabling sharing is a pointless idea. in
fact some os's like openbsd check if the sempahore addres is in a
sharable mem region and deny init if it is not. on osx you dont use
shared memory but a sempahore name you share instead... and this is
not exposed thus it can't be shared either. if we did process sharable
semaphores we'd make shm segments and/or name them in a sharable way
were you can share the idenitifer of the shm segment and/or the offset
address or name from osx. but we don't, so making them
process-private is the right thing. sharable sempahores will need a
whole new api.

this also fixes osx naming to make the name pretty unguessable/private
and opened exclusive (or it fails) by using pid, sem counter, and 4
random numbers. it's not a security mechanism as the create will fail
if there is a clash. chances are low. we unlink before anyway. good
enough for osx for now.

@fix
2016-08-05 18:11:42 +09:00
Carsten Haitzler 8fd224b4d6 eina thread queue/semaphores - check even more unlikely errors + complain
check some really unlikely alloc errors and semaphore deadlock errors
and report if that has happened. just in case.
2016-08-05 17:38:02 +09:00
Carsten Haitzler 07924f26f1 eina thread queue - check returns fo semaphore new/lock/release to debug
so openbsd may have issues with semaphores - maybe. this would catch
them if it it. why - if sem_init/sem_wait are different... i dont know.
2016-08-05 17:09:34 +09:00
Carsten Haitzler 8889daa7c5 ecore con eet test - dont use localhost port 8080
so thats a common local port to use for other things... 8080 - don't
use it, so use 12346 much like 12345 is for the other tests. far less
likely to clash. fix up tests to work better.
2016-08-05 17:09:34 +09:00
Shinwoo Kim 89d5479c0b atspi: toolbar - fix cannot call select callback
There is a line to check select_mode in _item_select function.
The item selected(clicked) callback is called when the select_mode is ELM_OBJECT_SELECT_MODE_NONE.
The checking select_mode should be handled at one place.
2016-08-05 16:17:13 +09:00
Carsten Haitzler 720f17619e ecore eina threadqueue test suite - be correct about volatile+padding
fill in the padding of mesages (10 bytes) with something so valgrinds
can be happy and use vlatiole for msgs count as the msgs num should
have been incremented already before the msg sned is done and main
thread/loop gets the msg
2016-08-05 14:35:41 +09:00
Carsten Haitzler 6b6823e5af eina_threadqueue - fix const ptr warning on spinlocks if atomic disabled
atomics SHOULDNT be disabled anyway, but if they are... fix this
warning. (no real bug)
2016-08-05 13:42:50 +09:00
Carsten Haitzler 013c0702f4 ecore_imf - fix make check to doa "load all" check after de-sillifying it
this should make ecore_imf testable with empty env vars also meaning
no env var and the make check test will now ensuree this is set to
exactly test this.
2016-08-05 13:42:11 +09:00
Jean-Philippe Andre 32df056a32 ecore_imf: Fix crash when ECORE_IMF_MODULE is set 2016-08-05 11:33:01 +09:00
Jean-Philippe Andre 917f34587b evas: Make safety check more lenient
This is to avoid ERR messages such as "object is not an image!"
that can happen when a legacy image function is called on an
eo image (proxy, 3d, ...) object.

Note: This does not fix any known issue, but it's probably a safer
solution.
2016-08-05 11:01:55 +09:00
Jean-Philippe Andre 28c917836c efl: Cleanup some code (return values)
This removes some useless code in various places, where the
switch from eo_do() to standard function call was not properly
refactored.

This changes:

type ret = 0;
ret = my_eo_function();
return ret;

To:

return my_eo_function();
2016-08-05 10:32:30 +09:00
Jean-Philippe Andre 26ee77ff67 evas image: Lower ERR message to WRN and fix it
In elm_image, efl_file_get() was called on a legacy Evas Image
object, which generated an ERR message. This was way too much
noise for something that actually works.

It's best not to call efl_file_get/set API on a legacy
object, but it can be convenient for smooth code transitions
from legacy to pure eo.

Also, add safety to those APIs.

Test case: elm_test genlist dnd, start dragging anything.
2016-08-05 10:32:30 +09:00
Jean-Philippe Andre 12fbaacc97 evas: Mark image fill_spread as deprecated
It was never implemented.
2016-08-05 10:32:30 +09:00
Jean-Philippe Andre 4d67ee2478 evas: Add safety checks to evas image legacy APIs
This checks for NULL and ensures the type is evas image.
2016-08-05 10:32:30 +09:00
Daniel Kolesa 13245db06c docs: make dark theme default, add switch --graph-theme-light 2016-08-04 16:45:34 +01:00
Daniel Kolesa 35eebf5c2c docs: add default dark theme (via --graph-theme-dark) in docgen 2016-08-04 16:43:29 +01:00
Marcel Hollerbach 3f1d40cff8 efreet: free fallback cache on shutdown
this fixes errors like:
ERR<4864>:eet lib/eet/eet_lib.c:645 eet_shutdown() File '/home/osauser/.cache/efreet/icons___efreet_fallback_localhost.localdomain.eet' is still open 1 times !

@fix
2016-08-04 17:04:50 +02:00
Carsten Haitzler 8dd27f2fd9 elm tooltips - fix positioning cornercases
this should fix T4277
2016-08-04 23:23:30 +09:00
Stefan Schmidt a17cef99fd mailmap: update mailmap file now that we have all libs merged
Trying to unify the authors a bit here. And yes, Chris wins the price for the
ridiculous amount of variations he uses.
2016-08-04 12:45:43 +02:00
Daniel Hirt 44569b859a Elm.Entry: use proper theme_set function on edje object
Shouldn't use elm_widget_theme_object_set for handlers/anchors here.

Fixes T4091.
@fix
2016-08-04 13:27:08 +03:00
Carsten Haitzler e5cfb76ef1 edje object shutdown - be far more paranoid about ptrs and order
so we didnt set everything to null after being freed and object sae
freed after some data. do the data frees after objects are deleted so
callbacks cant access null data anyway. this makes this edje shutdown
far more robust and safe. massive improvement in stability i hope.
2016-08-04 18:28:49 +09:00
Carsten Haitzler c59995916e edje - fix access to freed data struct during object shutdown
this fixes T4181
2016-08-04 18:19:42 +09:00
Hermet Park b07617ea76 elementary widget: actually this is a right fix than fa4a72d3fc
Now rage and enventor both will be fine.
2016-08-04 16:44:06 +09:00
Carsten Haitzler fa4a72d3fc elm key events/disabling/focus - fix after another disabled widget fix
this fixes key events in rage again after
ea2b5e4048 broke them. this fixes T4285
2016-08-04 16:37:21 +09:00
Hermet Park 77d2e0cb95 efl: fix a neon build break.
We found a some build break problem due to a build system.

In efl configuration, our efl configure enables neon if it's available,
but neon gonna partially turned off on evas compilation if the build system
has a non neon CFLAG option (ie, mfpu=vfpv..). In the end, neon is partially enabled
and it turns out a build break.

It's non-sense but we can't allow this breakage.

There is no way to ignore build system option nor override our neon option perfectly,
so, Let efl package ruled by build system overall.
2016-08-04 15:39:51 +09:00
Subhransu Mohanty d458101a41 edje: updated the start index of vector resource from 1 to 0
Reviewers: cedric, jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4205

Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
2016-08-03 17:34:57 -07:00
Cedric Bail c64071ae13 elementary: keep theme consistent regarding the disabling of odd/even.
This is another patch that should be reverted as soon as we start
7affe8c204 and is still a work around
T3086.
2016-08-03 17:30:35 -07:00
Carsten Haitzler a3e7413992 elm image - silence warnings of setting smooth if image is edje 2016-08-04 08:17:18 +09:00
Carsten Haitzler 1f48ce5f6b emotion generic - vlc - make it off by default as 2 video bends is silly
as per bug. requiring by DEFAULT 2 video back ends is rather
rediculous. pick one and the others are optional. you could argue xine
now is barely worth it, but it's stable and works and has proven to be
not any real pain.

gst1 is a more optimal and far more complete/featured backend that the
vlc generic one anyway. vlc generic has the bonus of out-of-process,
but gst1 is pretty stable (unlike the 0.1 backend), so let's not make
peolpe install 2 video backends (or possibly 3 or more) just to build
efl out of the box.

this fixes T4284
2016-08-04 08:04:57 +09:00
Andy Williams f2a4ff154f Fix further text checks in Elm_Code T4264
An incorrect assumption in how unused memory may be initialised
    @fix
2016-08-03 23:43:23 +01:00
Cedric Bail 7925c56ec9 emotion: fix autodetection of emotion generic vlc player module.
T4273
2016-08-03 12:01:17 -07:00