On Mon, Nov 19, 2012 at 9:33 PM, thiep ha <thiep.ha@samsung.com> wrote:
Dear All,
I have seen that if there is no selection in an entry, the copy/cut menus are still shown in entry.
(Example: double click at the end of entry or on an empty entry).
I modified source code to not show copy/cut menus in above scenario.
I also removed the redundant checking condition for showing copy/cut menus.
Please review this patch.
Best Regards,
Thiep Ha
SVN revision: 79545
it doesn't need to call _smart_sizing_eval in itself.
Currently, _smart_sizing_eval is called by _elm_layout_smart_sub_object_del when elm_layout is deleted.
I think this is called unnecessarily.
SVN revision: 79540
1. add title icon to focus chain, title icon would be an widget
such as segment control which is able to get focus.
2. add smart_access(); to register, unregister access object.
3. call _item_text_set_hook(); if item_new() has title_label,
previously the _item_text_set_hook() is called even though
the title_label is NULL.
4. remove unnecessary variables from elm_widget_naviframe.h
5. add _access_focus_set() to give focus propery.
SVN revision: 79511
Elementary based programs composed of widgets and containers. This means
that every widget will be inside a container, or will be the base
container, usually set as a resize object of the window.
Taking advantage of this structure, we can leave the frame area
calculation be done by elementary, not relying anymore on the framespace
available from Evas.
This commit fixes the problems related to the wayland framespace on
Elementary, while the final implementation of the said framespace is not
done yet on Ecore and Evas. Later it can be easily changed to use the
available infrastructure.
SVN revision: 79491
*note: this commit - callback behavior - would be disputable as genlist becuase list has
"clicked,double", "selected" and "activated" signal and smart callback also.
but the access acitvate callback works as the item is selected.
SVN revision: 79451
*note: this commit - callback behavior - would be disputable, becuase genlist has
"clicked,double", "selected" and "activated" signal and smart callback also.
but the access acitvate callback works as the item is selected.
SVN revision: 79369
because target object could have different gesture callback with different gesture object.
after _callbacks_unregister() is called, only one callback remains.
SVN revision: 79317
Subject: [E-devel] [E-Devel][Patch][Elementary]Map: Remove delayed job
This patch removes delayed jobs in elm_map.
Previously delayed job is used for queuing the zooming & zoom mode
changing & overlay_showing API requests. Queued jobs are all executed
when pan is calculated.
But actually queued jobs are not needed to be executed. Just last
jobs are needed to be executed per pan calculation.
So I removed delayed jobs and fill calc job functions to be executed
while calculation is executed.
SVN revision: 79269
If the sum of item min values is larger than the length of window,
the scroll of toolbar works. And if the length of window is larger
than the sum of item min values, items are expanded.
SVN revision: 79263
1. add smart_activate(); to access object.
2. add an API _elm_access_activate_callback_set();
- this callback is called when user wants to activate access object
which would represent widget item or edje part object.
3. add owner referece to the Elm_Access_Info for access object.
4. clock: use _elm_access_activate_callback_set();
SVN revision: 79199
Hi all,
I had prepare some doc fix for elm_fileselector_entry_inwin_mode_set.
By mistake docs said it returns EINA TRUE in both cases.
Please verify attached file.
Regards,
Patrick
Signed-Off-By: Patryk Kaczmarek<patryk.k@samsung.com>
SVN revision: 79089
i would like to add access enhancement to the toolbar.
please review the attached. if there are no objections, I will commit it.
cordially,
shinwoo kim.
SVN revision: 78995
On Thu, Nov 8, 2012 at 12:42 PM, Rajeev Ranjan <rajeev.r@samsung.com> wrote:
Hi,
Attached is a patch to update documentation for gengrid related to changing longpress_timeout value in gengrid.
Signed-off by: Rajeev Ranjan <rajeev.r@samsung.com>
Thank you.
Regards,
Rajeev
SVN revision: 78990
I attached new patch.
The old patch's default position and mirroring problem has been fixed.
I added new 2 APIs for supporting various notify's postion.
EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_notify_align_get(const Evas_Object *obj, double *horizontal, double *vertical);
And below 2 APIs will be deprecated.
EINA_DEPRECATED EAPI void elm_notify_orient_set(Evas_Object *obj, Elm_Notify_Orient orient); EINA_DEPRECATED EAPI Elm_Notify_Orient elm_notify_orient_get(const Evas_Object *obj);
Please review this patch.
Thanks:)
Signed-Off-By: Seunggyun Kim<sgyun.kim@samsung.com>
SVN revision: 78655
I attached new patch.
The old patch's default position and mirroring problem has been fixed.
I added new 2 APIs for supporting various notify's postion.
EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_notify_align_get(const Evas_Object *obj, double *horizontal, double *vertical);
And below 2 APIs will be deprecated.
EINA_DEPRECATED EAPI void elm_notify_orient_set(Evas_Object *obj, Elm_Notify_Orient orient); EINA_DEPRECATED EAPI Elm_Notify_Orient elm_notify_orient_get(const Evas_Object *obj);
Please review this patch.
Thanks:)
Signed-Off-By: Seunggyun Kim<sgyun.kim@samsung.com>
SVN revision: 78653
WARNING: I don't believe this is the proper bug fix for an uninitialized
memory access, but I really don't know this code enough. Tasn if you could
look at it when you have time.
SVN revision: 78511
i would like to add access feature to the panel.
please review the attached. if there are no objections, I will commit it.
cordially,
shinwoo kim.
SVN revision: 78428
genlist could have LOTS of items. so it would be better to use only displayed items for the focus chain.
please check the attachment and give feedback. thanks.
cordially,
shinwoo kim.
SVN revision: 78378
Subject: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item
Cache Refactoring
This is patch for reconstructing genlist's item cache.
Each item cache functions do harsh jobs so just push,pop by
Elm_Gen_Item * now.
Before, cache is disabled by comments. But I enabled item cache again
(even for the case which tree_effect_enabled is on).
I changed some functions:
_item_cache_find() --> _item_cache_pop()
_item_cache_add() --> _item_cache_push()
_item_cache_zero() -->_item_cache_all_free()
And I removed _item_cache_clean() function because I made
_item_cache_push() to don't exceed the item_cache_max. So clean-up of
cache is not needed anymore.
Breaks "genlist 2" test and clouseau. Just open genlist 2, press the "X"
button, and then the "+" button.
This reverts commit 77944.
SVN revision: 78336
On Fri, Oct 19, 2012 at 12:30 PM, Bluezery <ohpowel@gmail.com> wrote:
> Dear all,
>
> There is a bug, invalid data assign into ecore_job.
> Trivial whilte space removal is included also. it's automated in my editor :D.
>
> Please review this patch.
>
> --
> BRs,
> Kim.
SVN revision: 78221
If the sum of item's min is larger than the viewport size in ELM_TOOLBAR_SHRINK_EXPAND mode,
it can be scroll. And the end of the item is fitted on the end of the viewport.
SVN revision: 78156
Subject: [E-devel] [PATCH][ELEMENTARY][BUG Fix] Current Reordering
item is not resizing on genlist resize (e.g On roation)
Please review the attached patch created to fix the current reordering
item
resizing issue.
[ISSUE] Current genlist reordering item is not resizing on genlist
resize
(e.g. On rotation).
Change Description:
In _calc_job call back, the width of reordering item is corrected.
SVN revision: 77992
Subject: [E-devel] [patch][elementary] diskselector - blank item
should be added on round disabled mode
blank item should be added on the round disabled mode.
current diskselector adds blank item even though the round mode is enabled.
so please check the patch and give feedback. thanks.
SVN revision: 77990
Subject: [E-devel] [patch][elementary] toolbar - highlighting item on
access
the current toolbar does not show highlight effect on accessibility mode.
the attached would give the highlight to toolbar item.
please review the patch and give feedback. thanks.
SVN revision: 77972
Subject: [E-devel] [patch][elementary] conformant - use layout focus
next, direction
um.. there would be a reason to not use focus next and direction stuff..
please let me know why the conform does not use those..
if there is no reason, please keep the patch. thanks.
SVN revision: 77947
Subject: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item
Cache Refactoring
This is patch for reconstructing genlist's item cache.
Each item cache functions do harsh jobs so just push,pop by
Elm_Gen_Item * now.
Before, cache is disabled by comments. But I enabled item cache again
(even for the case which tree_effect_enabled is on).
I changed some functions:
_item_cache_find() --> _item_cache_pop()
_item_cache_add() --> _item_cache_push()
_item_cache_zero() -->_item_cache_all_free()
And I removed _item_cache_clean() function because I made
_item_cache_push() to don't exceed the item_cache_max. So clean-up of
cache is not needed anymore.
SVN revision: 77944
Subject: [E-devel] [patch][elementary] diskselector - bug fix
diskselector has two bugs.
1. on round enable mode
elm_diskselector_item_append(); does not call elm_box_pack_*() for
over_items and under_items which are added when the display item is
bigger
than 3.
because over_items and under_items is not added, the diskselector shows
just 4 items + half item(NOT 5 items), in case of display item number
is 5
- elm_diskselector_display_item_num(obj, 5); -.
this bug could be found only if u use as following sequence.
a. elm_diskselector_round_enabled_set(obj, EINA_TRUE);
b. elm_diskselector_item_append();
2. on the round disable mode + bigger than 3 display item
even though display item is bigger than 3 on the round disable
mode, only
two blank items are added - left_blank, right_blank.
because of this, the first item could not be selected. means.. the first
item cannot be located in the middle of diskselector.
if u scroll the diskselector to the left-most, then the second item is
selected as below.
[blank] [ 1st ] [ 2nd ] [ 3rd ] [ 4th ]
so if the display item is bigger than 3, more blank items would be
necessary.
include lines to resolve above 1st bug, the patch would resolve
this issue
also.
SVN revision: 77740
Subject: [E-devel] [patch][elementary] multibuttonentry - access feature
i have attached a patch which has access feature for the multibuttonentry.
it was hard time to implement access feature on the multibuttonentry than
others.
SVN revision: 77738
Subject: [E-devel] [elementary] size value checking in elm config
This patch contains size value checks for some functions in elm_config
file.
I think that calling these function with negative size values has no
sense.
SVN revision: 77734
It was always increasing quicklaunch count on init, but
only reducing on shutdown when _elm_init_count is zeroed,
i.e., the quicklaunc_shutdown rountine wasn't being executed.
SVN revision: 77378
With ELM_POLICY_EXIT it's possible to request elementary
to delete all the windows before shutdown instead of just
quitting the main loop.
SVN revision: 77328
It's weird, but looks like wrap mode of the spinner is broken at least
since the move of elm to trunk.
The current code:
if (sd->wrap)
{
while (new_val < sd->val_min)
new_val = sd->val_max + new_val + 1 - sd->val_min;
while (new_val > sd->val_max)
new_val = sd->val_min + new_val - sd->val_max - 1;
}
doesn't seems correct. Since even the documented example would fails:
* E.g.:
* @li min value = 10
* @li max value = 50
* @li step value = 20
* @li displayed value = 20
*
* When the user decrement value (using left or bottom arrow), it will
* displays @c 40, because max - (min - (displayed - step)) is
* @c 50 - (@c 10 - (@c 20 - @c 20)) = @c 40.
With the current code the value will be 41.
It also could lead to values above min, like happens on the first spinner test,
when you could go to -50.5 because new value will become:
250 + (-50.5) + 1 - (-50) in the first while() and later since these value
is bigger then 250, would go back to -50.5 ...
So, a reasonable algorithm would be
if (sd->wrap)
{
if (new_val < sd->val_min)
new_val = sd->val_max + new_val - sd->val_min;
else if (new_val > sd->val_max)
new_val = sd->val_min + new_val - sd->val_max;
}
But it doesn't works fine for cases like the months spinners test, when you
have min = 1, max = 12, step = 1 and each option should be displayed with
wrap. This algorithm would wraps from 1 to 11, so would skip December...
So, I think just going to the max value when min is reached is the better
choice.
if (sd->wrap)
{
if (new_val < sd->val_min)
new_val = sd->val_max;
else if (new_val > sd->val_max)
new_val = sd->val_min;
}
SVN revision: 77278
On Fri, Sep 28, 2012 at 10:04 PM, Bluezery <ohpowel@gmail.com> wrote:
> Dear EFL developers,
>
> In current genlist reorder mode, reordering is not moved when
> reordering item is on top or in bottom of within genlist objec because
> of scroller's hold mode.
> After mouse point is moved out of genlist object, then reordering item
> can be moved.
> But in mobile, mouse point can not be moved out of window (if genlist
> item is expanded in window).
> So I add some tweaks to reordering item can be moved when reordering
> item is moved on top item or bottom item.
>
> Please review this patch.
>
> BRs
> Kim.
SVN revision: 77255
Since all the spinners have wrap set we don't test if min / max
are working fine without it.
Also, using EINA_TRUE instead of ELM_WRAP_CHAR makes more sense.
Anyway I couldn't reproduce the bug Ricardo reported to me =/
SVN revision: 77213
I know some guys insinuated it's useless, since if you want to
put a image in your theme you can just place a image part.
But there are some cool things:
- You can add a background that fits the theme (default bg theme)
- You can use background options (tile, stretch...)
SVN revision: 77212
This can happen on window deletion scenario:
the parent object is elm_widget_sub_object_del()ed BEFORE it gets
evas_object_del()ed, so its children won't reach the window anymore.
SVN revision: 77206
Subject: [E-devel] [Patch] multibuttonentry - data corruption issue of
the box list
here is a problem in the data corruption of the box list in
_box_layout_cb() of the multibuttonentry.
EINA_LIST_FOREACH is used to move and resize the objects.
but if box unpack/pack is called in the EINA_LIST_FOREACH loop,
the data of the box list will be corrupted.
This problem can not be solved immediately due to the structural
problems of
the MBE.
So the attached patch, a workaround, avoids calling unpack/pack in the
EINA_LIST_FOREACH loop.
I am in the process of refactoring MBE but in the mean time,
this patch will resolve the above issue.
SVN revision: 77192
Subject: [E-devel] [patch][elementary] diskselector - checking middle
item
the diskselector object x-coordinate would not be 0.
but the _scroll_animate_stop_cb() calculates selected item with assumption
that the diskselector object x-coordinate is 0.
so different item which is not in middle of diskselector is selected.
SVN revision: 77182
Adding the follow functions if the part is a BOX:
- elm_layout_box_append
- elm_layout_box_prepend
- elm_layout_box_insert_before
- elm_layout_box_insert_at
- elm_layout_box_remove
- elm_layout_box_remove_all
or if the part is a TABLE:
- elm_layout_table_pack
- elm_layout_table_unpack
- elm_layout_table_clear
SVN revision: 77039
Hi All,
Please find attached patch for naviframe animation optimization.
This patch makes sure animation happens smoothly even if content is heavy.
i.e, this patch makes sure animation is deferred so that it is visible(showing full transition time)
even if content takes more time in creation.
Change description:
Naviframe Animation optimization for smoother animation.
Signed-off by: Shilpa Singh<shilpa.singh@samsung.com>
Thanks & Regards
Shilpa Singh
SVN revision: 76929
Subject: [E-devel] [patch][access] bubble - access feature
the attached has access feature for bubble widget.
please review it and give some feedback. thanks.
SVN revision: 76798
Subject: [E-devel] [patch][elementary] access - activate widget
Subject: [E-devel] [Patch][elementary] scroller, slider - access
activate feature
the previous activate function just get object only. to activate scroller
or slider etc.. it needs more information. so the patch changed previous
activate(Evas_Object *obj) to activate(Evas_Object *obj, Elm_Activate act);
the Elm_Activate can be one of ELM_ACTIVATE_DEFAULT, UP, DOWN, RIGHT, and
LEFT.. you can add more if it is necessary.
I have attached two patches. one is for the slider and the other is for the
scoller.
this patch would support those who wants change value of slider or content
position of scroller on remote side.
this would be useful to the access side or voice control side also.
SVN revision: 76717
Subject: [E-devel] [patch][elementary] bubble - text set does not
display info text part
current bubble dose not display 'info' which is TEXT part.
i have learned that the following commit would be reverted.
http://trac.enlightenment.org/e/changeset/71516/trunk/elementary/src/lib/elm_bubble.c
or remove 'else' from 'else if' on current
_elm_bubble_smart_text_set();.
anyhow i made a diff and attached. please find it and give feedback.
thanks.
SVN revision: 76669
Stefan Schmidt
Carsten Haitzler
Cedric BAIL
ChunEon Park
WooHyun Jung
Daniel Juyung Seo
Jihoon Kim
Jaehwan Kim
Daniel Zaoui
Shinwoo Kim
Yakov Goldberg
Michael BOUCHAUD
Rafael Antognolli
Jiyoun Park
Jonas M. Gastal
Bluezery
Sebastian Dransfeld
Gustavo Lima Chaves
Vincent Torri
Mikael SANS
Seunggyun Kimsgyun.kim
Sanjeev BA
Bruno Dilly
Eduardo Lima (Etrunko)
DUBEYPRINCE KUMAR
Mike McCormack
KoziarekBeata
Flavio Vinicius Alvares Ceolin
Jihyeon Seol
Aharon Hillel
Leandro Pereira