Summary: modify to not allocate Eina_Rectangle and use it directly on the stack with EINA_RECTANGLE_SET
Reviewers: raster, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2737
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
- TARGETS notifier is specific to CnP and should not be called for DnD
- On DnD (when drag starts) and on CnP, it doesn't make sense that the TARGETS
type are sent to the potential target. Only basic types should be sent.
Summary:
gengrid focus state recovering in item_realize is duplicated.
remove unnecessary lines.
you can find same signal emit codes under line 1018.
Test Plan: test elemetary test gengrid focus highight show correctly after code merged.
Reviewers: raster, Hermet, seoz, jaehwan, cedric
Reviewed By: cedric
Subscribers: singh.amitesh, eagleeye
Differential Revision: https://phab.enlightenment.org/D2656
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Setting the group without checking it exists causes a errormessage, this
is pretty annoying for people which want to set a standart icon. And
give a better errormessage if the standart setting failed.
Reviewers: raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2686
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Both Elm_Image and its base interface Efl.Image have a property named
"animated".
The meaning for Efl.Image is whether or not the image has animation.
On the other hand, Elm_Image use it to set whether an image, which supports
animation, is to animate itself or not.
Thus Elm_Image have another property (animated_available) to tell whether the
image have animation or not, making it even more confusing.
Renamed the "animated" property of Elm_Image to "animated_enable" to make
the intended meaning clearer.
Also replaced the "animated_available" property with the "animated" property
from the Efl.Image interface, since both refers to the same thing, in order
to reduce the API.
Added implementations of the legacy methods for backward compatibility.
Address the issue:
- Elm image and the image interface clash because of the meaning of "animated".
Specified in the page:
https://phab.enlightenment.org/w/efl_interfaces/
Reviewers: felipealmeida, tasn
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2354
When application does not have any value of engine,
this app should be launched with elm_config's value.
Signed-Off-By: Wonsik Jung <sidein@samsung.com>
nearly everything in e is square except for this, which was a holdover from the
b&w theme. the new image looks more coherent with the rest of the square look
image created by me, licensing to match rest of theme images
@feature
Summary:
When text is pasted or dropped into entry, the "changed,user" signal
should be emitted, not "changed" signal.
Currently, the "changed" signal is emitted.
This patch fixes this issue.
@fix
Reviewers: herdsman, tasn
Subscribers: tasn
Differential Revision: https://phab.enlightenment.org/D2710
Summary:
In wayland, elm_config_all_flush doesn't work.
It has X dependency totally.
It uses ecore_file_monitor instead of X property.
Reviewers: Hermet, devilhorns, raster, cedric
Differential Revision: https://phab.enlightenment.org/D2502
Summary:
localtime() can return NULL when there is an error.
@fix
Reviewers: raster, woohyun, Hermet, JackDanielZ
Subscribers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2666
Summary:
It could make crash when malloc is failed.
@fix
Reviewers: raster, woohyun, Hermet, JackDanielZ, thiepha
Subscribers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2671
Summary: Even if scroller is not scrolled, EVAS_EVENT_FLAG_ON_HOLD is set. So clicked event is canceled in Edje.
Test Plan:
On the button in the vertical scroller, click button and move mouse horizontal.
Mouse up on the button, so now button is not clicked
Reviewers: Hermet, CHAN, seoz, jaehwan, woohyun, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2550
Each data notifier was preparing data and then invoking the user callbacks
for DnD or selection protocols.
Most of the notifiers code was handling the user callbacks invocation
and was the same for all of them.
This patch simplifies the notifiers by moving the user callbacks
invocation into a common place for all the types, i.e into the notify
dispatcher.
The notifiers prototype has been changed to suit the code modifications.
The object parameter in datacb must be the selection request object,
not the selection owner object.
This patch corrects that.
Test case: open two windows with entry, copy text from one entry in
first window, paste to entry in other window.
@fix
There is code in elm_cnp.c which is used to paste data to entry widget only.
This can cause error if widget is not entry.
This patch removes that code in elm_cnp.c and adds datacb to entry
to insert content to entry.
@fix
Summary:
It could make crash when strdup() is failed.
CID - 329115
@fix
Reviewers: raster, thiepha, woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D2673
Summary:
It could be failed to allocate memory for Anim_Icon.
CID - 337351
@fix
Reviewers: raster, thiepha, woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D2672
someone.. somewhere along the way.. likely a long time ago.. broke
compress mode. likely the addition of the ellipsis value as an
ellipsis position or something related to that broke compatibility,
as this used to work. be that as it may... finding out just where is
virtually impossible, so fix it the simpler way - add elipsis values
Summary:
change the 'sid->loop_v' condition to '!sid->loop_v' to delete momentum animator
when the vertical scroller reached the end of the content
@fix
Reviewers: raster, Hermet, woohyun
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D2609
Summary:
When context,open signal is sent from elm_entry before showing context
menu, dynamic addition of context menu items to entry becomes easier.
@feature
Test Plan:
Run elementary_test
Launch Entry Scrolled test
Right Click on Multiline Markup entry
Reviewers: tasn
Reviewed By: tasn
Subscribers: subodh6129, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2580
New focus move policy, ELM_FOCUS_MOVE_POLICY_KEY_ONLY, is added.
If you set this policy as base focus move policy, objects cannot steal
focus by using mouse click or mouse in. Only keyboard input (such as Left,
Right, Up, Down, ...) can make focus be moved.
Additaionally, an object can have its own focus move policy by using
elm_object_focus_move_policy_set API.
@feature
This reverts commit 8278dff6a742c391f7c04c3de1033574d818dbb6.
This is not good for scenarios and will break the compatibility.
Thanks to David for reporting.
Summary:
Below bugs are exist in gengrid widget when use horizontal mode and mirrored set.
1. Gengrid item is placed wrong position when mirrored set.
Current calulation for mirroring in _item_place only consider pan object positions.
if widget is mirrored, item should be placed opposited position so object x position must be
consider in mirroring calculation also.
2. Gengrid scroll(pan) minimum size is returned wrong value when mirroed set.
As the result of 1's calculation present oposite position of items, so align also reversed when mirrored.
but current gengrid didn't change align x so minimum size is return wrong value
and scroller expanded wrong direction.
@fix
Test Plan:
1. run elementary_test and set mirroring On
2. run Gengrid2 in elementary_test
3. see how items are placed by push append button repeatly.
4. see scroller shows correct position and items.
5. change usr/bin/test_gengrid.c to set another align value on gengrid and test again.
Reviewers: raster, seoz, Hermet, jaehwan
Subscribers: Jaehyun, anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2553
Summary:
There is a code to compare value is changed.
1256: if (sd->val == val) return;
Even value changed the value changed callback didn't called before.
Reviewers: woohyun, shilpasingh, Hermet
Reviewed By: shilpasingh, Hermet
Differential Revision: https://phab.enlightenment.org/D2560
this delays norender and throttle handling to allow for quick
show/hide etc. changes an app may make so to not jump state so often.
this also fixes an issue wqhere config may change leaving all windows
in norender mode.
Summary:
test_glview.c: In function ‘_print_gl_log’:
test_glview.c:347:10: warning: declaration of ‘log’ shadows a global declaration [-Wshadow]
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2577
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
the paper with earmarked corner and dir in it just doesn't stand out.
too plain and so you can't tell dirs from other files easily at all.
replace with a more normal foler icon that now stands out.
Summary:
When environment variable ELM_ITEM_SELECT_ON_FOCUS_DISABLE is set
_item_focused_next() function doesn't support for ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY mode.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: raster, Hermet
Subscribers: singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2464
Summary:
Fileselector button fails to run in inwin mode.
It is caused by incorrect window parent finding.
This patch corrects the window parent finding.
@fix
Test Plan:
run FileSelector Button, toggle Inwin mode option to on,
eo gives error and nothing is shown.
Reviewers: Hermet, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D2552
Summary:
Updated gengrid to move item selection in 'vertical' mode to the last
item, when currently selected item is not in the last row. As per the
original behaviour, on moving down from such an item, it takes the
focus out of the gengrid widget. Now it is updated to go to the last
item (in last row), and then on further pressing down, focus comes
out of gengrid.
This is something similar to what happens in other UI systems like in
Ubuntu and Windows, when pressing down on (n-1)th row, the last item
in the nth row gets focused.
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Reviewers: Hermet, SanghyeonLee, raster
Reviewed By: raster
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2418
@fix elm_object_cursor_set() to work also when used with the mouse pointer
yet inside the widget, otherwise you need to mouseout/mousein to actually see
the new setted cursor.
Please give a short review on this one, maybe there is a simpler way to check
if the pointer is inside the widget...
Also added a button in the cursor test for this use case
Summary:
When content is resized, scrollbar's position is not updated.
Add bar position update after bar size is changed.
This is sample for resizing issue.
Test Plan: elementary_test -> scroller3
Reviewers: jaehwan, woohyun, seoz, raster, Hermet
Reviewed By: Hermet
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2291
Summary:
For instance, ecore_evas sets initial withdrawn state EINA_FALSE if elm_engine is "buffer".
Therefore, the initial withdrawn state is derived from ecore_evas property.
@fix
Reviewers: raster, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2435
Summary:
When entry is resized, selection handlers are not updated,
it causes selection handlers to be placed in wrong position.
This patch fixes it.
@fix
Reviewers: woohyun, seoz, herdsman, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2487
Summary:
Issue: Too many widgets get created during smart add itself, even if
not necessary, adding to the launch time.
Solution:
Create widgets based on mode, check for modes in generic functions
like smart theme, focus etc:-
Test Plan: elementary_test can be used to test colorselector demo.
Reviewers: cedric, raster, Hermet
Subscribers: rajeshps, govi, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2532
Summary: The "closed_height" is not using in code.
Reviewers: raster, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2535
Summary:
check theme of tooltip label by
$clouseau elementary_test -to "tooltip"
tooltipi label theme was elm/label/base/default but we want theme
"elm/label/base/tooltip/default" to be set instead.
@fix
Test Plan: $clouseau elementary_test -to "tooltip"
Reviewers: raster, Hermet
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2509
Summary:
This uses new Evas Callback type EVAS_CALLBACK_CANVAS_VIEWPORT_RESIZE
to listen to view port size changes.
Reviewers: Hermet, cedric, raster
Reviewed By: raster
Subscribers: SanghyeonLee, seoz
Differential Revision: https://phab.enlightenment.org/D2527
Summary:
elm_object_item_del_cb_set() can set delete callback that is called on item deletion.
Del_cb, Evas_Smart_Cb, has void pointer for item data as its first parameter.
However, getting item data is broken.
@fix
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2524
When closing the application, the delete function given by the user in
the Item Class was called twice. During the clear process, the function
was called for every built item and then during the item destruction.
This patch fixes this behaviour by calling the user function only during
the item destruction.
Another fix has been added. It zero'es the built list pointer inside the
item. Without this fix, the item points to a list node that is already
freed and can lead during widget deletion to an invalid access inside
the list.
@fix T2394
Move enums from elm_scroller_common.h to elm_scroller.eo in order to make them
more accessible for bindings. Delete elm_scroller_common.h.
Moved the include for elm_scroller.eo.legacy.h to the top of elm_scroller_legacy.h
to allow the use of the generated types in the function declarations.
Summary:
For now, if apply image mask to smart obejct, masking does not work except to implement in edc file.
@feature
Reviewers: Jaehyun_Cho, Jaehyun, jpeg, raster, cedric, Hermet
Subscribers: raster, jpeg, cedric
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D2055
Minwoo, Lee
Amitesh Singh
Carsten Haitzler
Daniel Zaoui
Andrii Kroitor
SangHyeon Lee
Youngbok Shin
Shinwoo Kim
Hosang Kim
Marcel Hollerbach
Vaibhav Gupta
Anand
taehyub
Vitor Sousa
Jaehwan Kim
ChunEon Park
Mike Blumenkrantz
Thiep Ha
Ji-Youn Park
Jaehyun Cho
Daniel Zaoui
WooHyun Jung
Daniel Kolesa
maxerba
Lukasz Stanislawski
Stefan Schmidt
shilpa.singh
Tom Hacohen
woochan lee
Daniel Juyung Seo
Umesh Tanwar
Aleksey Karmanov
Davide Andreoli
Lukasz Stanislawski
kumar navneet
Jee-Yong Um
Yakov Goldberg
jiin.moon