Commit Graph

423 Commits

Author SHA1 Message Date
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Daniel Juyung Seo 7dd5fe10af win: Check null before calling elm_widget_highlight_in_theme_get(). It
can be null.

'target' can be null when the focus in is just called.
2014-01-16 02:33:46 +09:00
Ryuan Choi 114e458f56 elm_win: Removed EE_ENGINE_COMPARE macro to reduce redundant function calls.
EE_ENGINE_COMPARE reduces typing little bit, but it makes redundant function calls
because almost callers call it more than once.
And, there is no way to check whether ecore_evas_engine_name_get is null.

This patch removed EE_ENGINE_COMPARE with small refactoring.
In addition, removed unnecessary check routines from _elm_ee_xwin_get.
2014-01-13 19:00:17 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Yakov Goldberg b45b864c36 win: fix parameter order in elm_win_available_profiles_get() for consistency 2013-12-30 15:44:17 +02:00
Daniel Juyung Seo f50925d5ad win: Added internal documentation about elm_win_rotation_set and elm_win_rotation_with_resize_set().
This is for efl developers not app developers so it goes to elm_win.c
Without knowing this, it is very tricky to understand the concept of
this api.
2013-12-27 23:15:12 +09:00
Daniel Juyung Seo 43c19a1fd3 win: Added floating mode documentation and added a check for floating parameter.
The documentation is from the original floating mode commit message.
2013-12-26 14:23:29 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Daniel Juyung Seo 8a0159df4f elm: long waited seasonal trailing whitespaces removal!
This is a ceremony of elementary 1.8 release!
2013-12-02 19:43:46 +09:00
Rafael Antognolli a68ad7f735 elm_win/wayland: Call frame update after rotation changed.
This will update the opaque region, that was set to a different
orientation.

Fix T359.
2013-11-26 14:58:22 -02:00
Daniel Juyung Seo 16e2c0779f elm_win.c: removed build warning when there is no wayland support. 2013-11-15 21:52:19 +09:00
Chris Michael a43489f6de Make routines to get the wayland window from an ecore_evas be more
inline with their X counterparts. Also, remove some EINA_UNUSED where
parameters were being used.

The previous code to get the Ecore_Wl_Window from an Ecore_Evas did
not check to make sure the Ecore_Evas Engine was a wayland engine, and
thus elm_tests like Window Inline would spew CRIT & ERR messages from
ecore_evas about the interface.

This fixes Phab Ticket T502

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-11-15 10:16:00 +00:00
Chris Michael bd7c04e174 Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-11-15 10:16:00 +00:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Carsten Haitzler 1aa3dd0ec4 unbreak wayland elm build more - use get_surface_id api 2013-11-02 11:51:50 +09:00
Chris Michael dcf38e3d20 Revert maximize support ... apparently this has already been "fixed"
... will have to look into why it does not work here propertly tho..

Revert "Fix elm client applications to support maximize properly (ie: removing"

This reverts commit 28763963bb9e26ea25ca182acc294c0a02f03ba2.
2013-11-01 07:25:15 +00:00
Chris Michael f59b6f9109 Revert this ... apparently it has already been "fixed"
Revert "Add missing EINA_UNUSED to function params."

This reverts commit 15b355a1195f0371c4e74d942ef9fcfa86a4a469.
2013-11-01 07:24:45 +00:00
Chris Michael a8b4180d7e Add missing EINA_UNUSED to function params.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-10-31 17:05:17 +00:00
Chris Michael 1f69d676c0 Fix elm client applications to support maximize properly (ie: removing
border shadow and resizing properly).

NB: Elm Theme needs fullscreen support old man !! :P

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-10-31 17:02:18 +00:00
Daniel Juyung Seo e951a0b499 access: fixed a typo. _elm_access_object_hilight -> _elm_access_object_highlight. 2013-10-31 23:01:56 +09:00
Rafael Antognolli e8a029b153 elm/win: Do not force maximized status.
When receiving a maximize event from the maximize button, do not force
sd->maximized. We must wait for a state change event, just like when a
window is maximized by the elm_win_maximized_set function. This will
ensure that a maximized smart event is sent.

Additionally, send a elm,state,maximized signal to the edje theme, so it
can update shadows and window decorations correctly.
2013-10-29 09:20:48 -02:00
Rafael Antognolli 14e63d0a71 elm/win: Put framespace set code in a common place.
A little refactory that hopefully will prevent future mistakes when
changing this code.
2013-10-29 09:20:48 -02:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Daniel Juyung Seo 6397761c6a elm_test: Fixed formatting. tab to space.
Changed tab to space before working on the code.
Kinda surprised by the number of tabs we had.
2013-10-14 19:12:32 +09:00
Ryuan Choi bdab578c1a elm_win: Fixed warning after 99ab56d5
ELM_WIDGET_SUB_ID_THEME needs to return Eina_Bool.
In addition, calls the super function of ELM_WIDGET_SUB_ID_THEME.

Reproduce step is changing profile in elementary_config.
2013-10-11 22:05:21 +09:00
Carsten Haitzler 95fdc9cc88 fix up namespace for many signal while keeping old versions for compat 2013-10-05 21:35:27 +09:00
Daniel Juyung Seo 252ec02cc2 elm_win.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:22:41 +09:00
ChunEon Park f19655ca3d elementary/focus - update focus highlight when theme is changed. 2013-10-03 23:57:08 +09:00
Daniel Juyung Seo e756f97dae elm: Longwaited trailing white space removal. Clean elm up! 2013-09-30 22:15:01 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
Chris Michael 9c638defed Tell evas to use a frame object here.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-09-11 14:11:08 +01:00
Chris Michael fd7bd29b34 Tweak adjustment of setting opaque region.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-09-10 14:29:18 +01:00
Chris Michael 328b0be7f5 Add a rectangle to trac frame "spacer" so we can set opaque_region
properly.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-09-04 14:22:44 +01:00
Chris Michael 4d23309024 Fix eo function description (fixes a typo).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-09-04 09:22:38 +01:00
Chris Michael d64eeef25a Add elm_win_window_id_get API function
NB: On X11, this will return the Ecore_Window of the Elm Window. On
Wayland engines, this will return the surface id of the Elm Window.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-09-04 09:19:30 +01:00
Chris Michael 7155cc0302 Remove blank line
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-09-04 08:23:10 +01:00
Chris Michael 01c42920f2 Fix mike's "move pointer" problem with elm apps inside wayland-only.
On a move start signal, set the mouse cursor to "move".
Add hook for "move stop" to unset cursor.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-28 14:26:06 +01:00
Chris Michael a03b9464a6 Fix wayland borders to not need framespace defined in theme anymore.
NB: Use a rectangle, swallowed into the frame object, to calculate
framespace values.

Thanks Raster !! :)

This also fixes zmike's Fat-Frame issue ;) (ie: frame size and
framespace will be adjusted now for different font sizes in the
titlebar)

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-23 08:39:19 +01:00
Daniel Juyung Seo c5b0d63838 fixed documentation for consistency. Gets -> Get.
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
2013-08-22 05:24:46 +09:00
Daniel Juyung Seo 50939d8f25 elm_win.c: focus animation refactoring. 2013-08-15 22:42:59 +09:00
Daniel Juyung Seo 4e1989433e elm_win.c: formatting fix before working on this file. 2013-08-15 22:42:13 +09:00
Daniel Juyung Seo dd3fb75651 elm_win focus: Added elm_win_focus_highlight_animate_set/get APIs.
Now one can manually enable/disable focus highlight animation for a specific window on run-time.
2013-08-11 18:58:28 +09:00
Daniel Juyung Seo 9bb54a942e elm_win.c: check null before dereferencing it.
This fixes coverity CID 1040022 : Dereference null return value (NULL_RETURNS).
2013-08-11 17:39:24 +09:00
Shinwoo Kim dec4d56d95 [access] call smart_access(); of the object which does not have parent object 2013-08-06 14:00:50 +09:00
Daniel Juyung Seo 91e8853535 elm_win.c: rename variable correctly. top_animate -> animate. 2013-08-04 17:52:54 +09:00
Daniel Juyung Seo a6d5d9909d elm_win.c: refactoring. cleaner code. 2013-08-04 17:38:02 +09:00
Daniel Juyung Seo 36efa6439e elm_win.c: more descriptive variable name. top -> fobj for focus edje object. 2013-08-04 17:37:30 +09:00
Daniel Juyung Seo c4bfc46960 elm_win.c: more ELM_SAFE_FREE adoption. 2013-08-04 17:15:03 +09:00