- Added enabled_filed_count to avoid loop in _elm_datetime_smart_sizing_eval().
sizing_eval is called many times but field_count is only changed when called
_reload_format().
- Moved redundant if statement out of the loop in _field_list_display().
- Removed redundant call from _elm_datetime_smart_add().
_field_list_arrange() is called in _reload_format().
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.
Now it fixed it.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.
This makes reducing duplicated code and supporting language,chagned from all widgets.
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
There are some warnings in elm_object_disabled_set() because elm_layout_theme_set()
calls _elm_datetime_smart_disable() before creating file->item_obj.
This patch refactors _smart_add to initialize file->item_obj before calling
elm_layout_theme_set().
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
Subject: [E-devel] [Patch] [Elementary] elm_datetime widget bug fix:
elm_datetime_field_limit_set() API is not working for min/max boundary
conditions
Hi,
Please review the attached patch for fixing issue in API
elm_datetime_field_limit_set() for boundary values.
It has been created by Sumanth for datetime widget.
[Issue Details]:
elm_datetime_field_limit_set() API is not working well for boundary
values.
[ex: for date, we can't set max limit as 31 and for minute, we can't
set 60 etc..
- it fails at boundary conditions of Min/Max limit for all
datetime fields.]
[Root cause]:
Boundary condition checking has not been done in a proper way.
[Change Description]:
Boundary checking condition is corrected and the min/max limit
boundary values are included as API input.
Signed-Off-By: Sumanth Krishna (sumanth.m@samsung.com)
Signed-Off-By: Rajeev Ranjan (rajeev.r@samsung.com)
SVN revision: 75958
Ryuan Choi
ChunEon Park
Yakov Goldberg
Daniel Juyung Seo
Daniel Juyung Seo
Tom Hacohen
Cedric Bail
Shinwoo Kim
Carsten Haitzler
Daniel Juyung Seo
Daniel Zaoui
Gustavo Lima Chaves
Jaehwan Kim
Shinwoo Kim
WooHyun Jung
Rajeev Ranjan