As ecore_drm_private.h already includes config.h header, we don't need
to include it here in these files also
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
As portions of this code have been derived from existing code in
Weston, we should also be including their copyright/licence text to
give credit.
NB: Fixes T3286
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Reverting this at Felipe's request following my email. There are many
things I strongly object to in this commit. I've touched the surface of
those on the ML (which doesn't work at the moment), though we need to
better discuss it.
The gist:
1. dlsym is a really bad hack that is not even needed.
2. I don't see why eo should even be aware of promises. It's not aware
of list, hash and etc.
3. The eolian changes were done wrong.
This should have been discussed and consulted before done, even if only
because of the amount of hacks it includes and the cross-domain (ecore,
eo and eolian) nature of it.
This reverts commit f9ba80ab33.
This reverts commit 9f4c43c20dfa36e7a8be18278acf4336c13574d7.
I'm sorry but this causes a side effect(list sizing issue) at enventor.
And I couldn't find any mis-usage in enventor side.
We can't not accept this patch unless we figure the exact reason out.
While we had the functionality to generate type stubs header we never had
these tested in our unit test setup. Adding to simple cases for struct
and typedef which we already use for normal header generation tests.
Imagine this. You have an object. You pass this object handle as a
message to another thread. Let's say it's not a UI object, so
something you might expect to be able to be accessed from multiple
threads. In order to keep the object alive you eo_ref() it when
placing the message on a queue and eo_unref() it once the message is
"done" in the other thread. If the original sender unref()ed the
object before the message is done, then the object will be destroyed
in the reciever thread. This is bad for objects "expecting" not to be
destroyed outside their owning thread.
This allows thius situation to be fixed. A constructor in a class of
an object can set up a delete interceptor. For example if we have a
"loop ownership" class you multi-ple-inherit from/use as a mixin. This
class will set up the interceptor to ensure that on destruction if
pthread_self() != owning loop thread id, then add object to "delete
me" queue on the owning loop and wake it up. the owning loop thread
will wake up and then process this queue and delete the queued objects
nicely and safely within the "owning context".
This can also be used in this same manner to defer deletion within a
loop "until later" in the same delete_me queue.
You can even use this as a caching mechanism for objects to prevernt
their actual destruction and instead place them in a cached area to be
picked from at a later date.
The uses are many for this and this is a basic building block for
future EFL features like generic messages where a message payload
could be an eo object and thus the above loop onwership issue can
happen and needs fixing.
This adds APIs, implementation, documentation (doxy reference) and tests.
@feature
Summary: This clarifies the documentation of the new api.
Reviewers: SanghyeonLee, shilpasingh, cedric
Reviewed By: cedric
Subscribers: bu5hm4n, buds
Differential Revision: https://phab.enlightenment.org/D3725
This reverts commit 7f4ea1a79c.
This reverts one of three parts of the try to get sub directory
compilation back into eina. It breaks our distcheck though and I
talked to Cedric about it and he prefers to revert these as we might
need to go another route to bring this functionality back. Details
will come to the mailing list.
This reverts commit 1affc60d00.
This reverts one of three parts of the try to get sub directory
compilation back into eina. It breaks our distcheck though and I
talked to Cedric about it and he prefers to revert these as we might
need to go another route to bring this functionality back. Details
will come to the mailing list.
This reverts commit e26fcbb1dc.
This reverts one of three parts of the try to get sub directory
compilation back into eina. It breaks our distcheck though and I
talked to Cedric about it and he prefers to revert these as we might
need to go another route to bring this functionality back. Details
will come to the mailing list.
Do not force this on everybody who runs with tests=coverage. It makes stdout
impossible to follow as well as overruns the tests log file. If one wants to
run with -DDEBUG it can be set from your own CFLAGS.
After aca6fc8c36 there have been problems when
linking when having coverage enabled.
AC_SEARCH_LIBS was used wrongly here. You need function name first and lib to
link against as second argument. The symbol name also has wto leading
underscores for me.
/usr/lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../x86_64-pc-linux-gnu/bin/ld generated: undefined
reference to `__gcov_init'
Summary:
elm_fileselector_buttons_ok_cancel_set() API checks the existence of
ok button before adding it.
This patch makes condition statement more intuitive.
Reviewers: cedric, bu5hm4n
Differential Revision: https://phab.enlightenment.org/D3770
Add a promise object that allows Eolian interface to include promises
as a way to have asynchronous value return and composibility.
The usage is like this in a .eo file:
class Foo {
methods {
bar {
params {
promise: Promise<int>;
}
}
}
}
Which will create the following API interface:
void foo_bar(Ecore_Promise** promise);
and the equivalent declaration for implementation.
However, the API function will instantiate the Promise for the
user and the implementer of the class.
This iterator is convenient when you already have a C-Array and you
need to pass this array to a function receiving an Eina_Iterator.
int array[] = {1, 2, 3, 4};
int* array2[] = {&array[0], &array[1], &array[2], &array[3], NULL};
Eina_Iterator* iterator = eina_carray_iterator_new((void**)array);
======
CC libelementary_la-elm_interface_atspi_value.lo
elm_interface_atspi_image.c: In function '_elm_interface_atspi_image_description_set':
elm_interface_atspi_image.c:36:9: warning: 'old_descr' may be used uninitialized in this function [-Wmaybe-uninitialized]
eina_stringshare_del(old_descr);
^
======
Summary:
- in dump_cb buf is allocated by malloc() ->strdup() -> free.
This is needless.
- And buf allocated in dump_cb is strdup again.
This may cause memory leak.
Reviewers: Hermet, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3752
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When item_show / scrolling is happening, _item_block_position will be
called from smart_calculate where item width is set as block width.
If items are not realized _item_realize will be called and if items are
getting realized for first time we set mincalcd as false. So later
item width gets overwritten by min width of item and so issue is happening.
@fix T2603
Signed-off-by: godly.talias <godly.talias@samsung.com>
Test Plan: elementary_test -> Genlist Group -> show 480
Reviewers: prince.dubey, shilpasingh, SanghyeonLee, cedric
Subscribers: rajeshps, seoz, govi
Maniphest Tasks: T2603
Differential Revision: https://phab.enlightenment.org/D3729
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: This API will return the number of items that have passed the filter at a given point of time. If the API is called before "filter,done" callback comes, it may or may not give the filtered count for the complete genlist.
Test Plan: Updated Genlist_filter example to print the output from filtered_count_get API in "filter,done" callback.
Reviewers: SanghyeonLee, shilpasingh, cedric
Reviewed By: cedric
Subscribers: buds
Differential Revision: https://phab.enlightenment.org/D3725
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
refine code and theme, hopefully solve the issue
that the height of file list (genlist) is calculated wrong.
Test Plan: elementary_test -to fileselector
Reviewers: SanghyeonLee, jpeg, cedric
Subscribers: taxi2se
Differential Revision: https://phab.enlightenment.org/D3715
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When glib support is enabled (HAVE_GLIB), _ecore_glib_init()
was always reserving resources. However, its counterpart may not
be called when:
- glib is not always integrated and
- when a user didn't explicitly required the integration.
Calling _ecore_glib_init() within the request code will cause the
resources to be reserved only when the integration with glib is
required and furthermore guarantees that resources always have a
chance to be released.
Reviewers: cedric, raster
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3749
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: While making new changes after rewieving D3710 we met this bug again, removing eo_unref is the best way to fix it because _eo_ref_replace from D3021 makes nothing special.
Reviewers: cedric, raster, Hermet
Subscribers: jpeg, artem.popov
Differential Revision: https://phab.enlightenment.org/D3745
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If not found edje part description, edje just set default description in spite of RTL status.
This adds to call function for getting the correct description as RTL status.
Reviewers: raster, Hermet, cedric
Subscribers: minkyu, sju27, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3735
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Stefan Schmidt
Chris Michael
Stephen okra Houston
Tom Hacohen
Vitor Sousa
Hermet Park
Carsten Haitzler
shashank.p
Daniel Kolesa
Jee-Yong Um
Felipe Magno de Almeida
Jean Guyomarc'h
Marcel Hollerbach
Amitesh Singh
SungTaek Hong
Shinwoo Kim
Minkyu Kang
godly.talias
Hosang Kim
perepelits.m
jiin.moon
Soohye Shin
Woochan Lee
Mike Blumenkrantz