Commit Graph

664 Commits

Author SHA1 Message Date
Jean-Philippe Andre c916e518d9 glview: Mark draw_request as eo-only
This is a rename of changed_set, not a new function.

@fix
2016-08-16 17:06:48 +09:00
Jee-Yong Um 30ec592638 elementary: remove redundant parts_text_fix from Elm.Layout
Summary:
When a theme is loaded, Elm.Layout updates strings with new theme.
This adjustment will be performed by Edje. (See D4219)

Reviewers: cedric, jpeg

Subscribers: taxi2se

Differential Revision: https://phab.enlightenment.org/D4220
2016-08-16 16:14:21 +09:00
JEONGHYUN YUN f00c078b9b elm_panel : add a toggled event triggered when panel toggled in any way.
Summary:
There are 2 ways to toogle the panel, by using elm_panel_toggle API and by interaction such as flick or click on panel.
This toggled event can help us to know the time when the panel toggled by all case.

Reviewers: woohyun, kimcinoo, Hermet, jypark

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4180
2016-08-16 16:14:21 +09:00
Thiep Ha fb15910640 elm video: correct api
The elm_videfl_add should be elm_video_add.
It was changed by commit e65aae994e.
This commit brings it back.
2016-08-16 12:36:26 +09:00
Tom Hacohen e65aae994e Eo: Finish the renaming of Eo to the EFL.
This renames all the rest of the API to the EFL namespace except for
Eo_Event that will follow soon.

Obviously breaks both API and ABI.
2016-08-15 15:07:42 +01:00
Vyacheslav Reutskiy 5135867218 elm_genlist: unhighlight item if it not selected
Summary:
Main trouble in handle click and double click event.
If user hold Esc and do double click on genlist item,
it still highlighted but not selected, because between
click and double click genlist process a key down event.
This patch add check the item state on mouse up, check
a item state - if item highlighted but not selected,
unhighlight it.

@fix
Fixes T3986

Test Plan:
1. run elementary_test Genlist
2. hold ESC
3. double-click on few genlist items

Reviewers: raster, cedric, NikaWhite

Subscribers: seoz, jpeg

Maniphest Tasks: T3986

Differential Revision: https://phab.enlightenment.org/D4222
2016-08-15 16:16:52 +03:00
Jean Guyomarc'h a5232bb283 elementary: fix documentation for elm_prefs
Update API references and code example.
2016-08-14 18:57:12 +02:00
Carsten Haitzler d86f73f9e6 elm win - fix elm win center to actually center again
@fix
2016-08-13 23:08:01 +09:00
Carsten Haitzler fd228ae6c5 efl api release - fix elm win accel preference set in legacy api
this shouldnt exist in legacy api as its not settable after creation.
it's useful only for eo constructors before finalize
2016-08-13 22:51:38 +09:00
Carsten Haitzler b59d7a6a1b efl api release - fix @since for elm win legacy api name_get addition 2016-08-13 12:15:13 +09:00
Stefan Schmidt 4c7aaac4a5 elm: ui_win: add since tags for accel_preference_get/set 2016-08-12 18:05:13 +02:00
Stefan Schmidt 8b6a320616 elm: widget: add since tags for new APIs 2016-08-12 18:05:13 +02:00
Stefan Schmidt 186ad100c7 elm: entry: fix since tag to be used for getter and setter
Both have been added in 1.18 not only set()
2016-08-12 18:05:13 +02:00
Carsten Haitzler 645927817b efl api release - fix @since for new elm win indicator api's 2016-08-12 18:04:55 +02:00
Carsten Haitzler b387d3ceee efl api release - fix @since in new elm slider range api's 2016-08-12 18:04:55 +02:00
Carsten Haitzler ec49db1e91 efl api release - fix @since in new elm glview api's 2016-08-12 18:04:55 +02:00
Carsten Haitzler ed9a58b28b efl api release - fix @since in new elm genlist api's 2016-08-12 18:04:55 +02:00
Carsten Haitzler 76410cff47 efl api release - fix @since in new elm gengrid apis 2016-08-12 18:04:55 +02:00
Carsten Haitzler 5537c7ffe3 efl api release - fix @since in new elm entry api's 2016-08-12 18:04:55 +02:00
Carsten Haitzler 6a6f039db2 efl api release - fix @since in new elm config apis 2016-08-12 18:04:54 +02:00
Carsten Haitzler c57d893768 efl api release - fix exposing of eo fake legacy api for elm check 2016-08-12 18:04:54 +02:00
Carsten Haitzler 47e6037a8b efl api release - fix exposing of eo api types for elm fileselector 2016-08-12 18:04:54 +02:00
Jean-Philippe Andre 4e00d5a71f image: Remove all new EAPI that shouldn't exist
Remove EAPI symbols and functions that were
wrongfully added:
 - elm_image_scale_down_set
 - elm_image_scale_down_get
 - elm_image_scale_up_set
 - elm_image_scale_up_get
 - elm_image_fill_inside_set
 - elm_image_fill_inside_get
 - elm_image_scale_get
 - elm_image_scale_set

Doing this before the 1.18.x release announcement.

Fixes T4343
@fix
2016-08-12 09:24:41 +09:00
Jean-Philippe Andre c6bb29c4e4 elm_image: Remove EAPI sizing_eval
This is an internal API, should not be exposed as EAPI.
Doing this before the 1.18.x announcement.

@fix
2016-08-12 09:20:21 +09:00
Jean-Philippe Andre f8684635e4 elm_win: Fix ABI break with missing EAPIs
EAPI elm_win_type_set
EAPI elm_win_name_set

Those two APIs should never have been part of the legacy API,
but they have been generated since at least 1.16. The commits
  1aceb3bc19
and
  41aa19447c
removed the legacy symbols generation. It seemed like a good
idea since the APIs shouldn't exist, but in fact this broke
ABI. I hate this. So sorry about it.

I'm adding them back in with no documentation and as
EINA_DEPRECATED.

This is an emergency commit before the 1.18.x release
announcement.

Fixes T4344
@fix
2016-08-12 08:11:54 +09:00
Tom Hacohen c662934be8 Change the EFL to follow the new Eo rename. 2016-08-11 17:04:43 +01:00
Chris Michael 585b1db623 elementary: Add call to set opaque_region for case of borderless and
alpha

If we have a borderless alpha window, then make call to set opaque
region accordingly. This still avoids calling opaque_region_set twice,
yet maintains opaque region for the above mentioned case.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2016-08-11 07:50:41 -04:00
Stefan Schmidt 961a1ada0f Manual revert of: commit 07404215a9
combobox: add Multiple selection feature

This exposes problems with name clashes and behaviour change for the legacy API.
Revert for now and we can revisit for 1.19.

Git revert got to confused as this was committed before we merged elm in. I did
the revert manually.
2016-08-11 12:14:07 +02:00
Jean-Philippe Andre b29847e0da wayland_egl: Fix double free in case of failure
When trying to create a window, the WL EGL engine creates
an ecore_evas and connects to the wayland display. But if
EGL is not supported (in weston with nvidia for instance),
the egl initialization fails and the window must be detroyed
in order to fallback to wayland_shm.

This led to a double disconnect from the wayland display
as both the ecore_evas del and the error handling code
were trying to disconnect.

Also, use ref == 0 in two places rather than ref <= 0, as
it can prevent double frees in bad situations (ref < 0).
And reset a global variable to NULL on shutdown.
2016-08-11 11:37:41 +09:00
Jean-Philippe Andre 58aa349283 widget: Optimize out one function call if not needed 2016-08-10 14:17:58 +09:00
Carsten Haitzler 8d6d395358 fix double delcaration of variable in elm_code
this fixes T4318 - thanks romain.
2016-08-10 11:12:17 +09:00
Stefan Schmidt 4f840c5feb elm: config: fix API naming to use disabled instead of disable to unify
We use disabled across our APIs so better fix this new one to unify it before
we release. This was introduced in commit 0116e07288

Many thanks to DaveMDS for reporting this!
2016-08-09 16:26:49 +02:00
Daniel Hirt 3eae9ff74f Elm.Entry: force cursor change on size_eval signal
This is a follow-up to ba060fe932.
Fixes T4274.
2016-08-08 16:47:22 +03:00
Carsten Haitzler 0bcd4f73d2 elm filesel - handle api that might provide path too big for buffer
this addresses a path that could be too small (unlikely due to max
path generally being 4k), for a stack buffer. this should make
coverity happy. fix CID 1356634
2016-08-08 18:38:25 +09:00
Carsten Haitzler e5dbf6cfba elm init - handle return value of ecore_file_init make coverity happy
this isn't an issue as init will never fail, but makes coverity happy
with CID 1353589
2016-08-08 17:47:14 +09:00
Carsten Haitzler 05ad541534 elm dbus menu - handle return value of eldbus_message_iter_arguments_get
handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.
2016-08-08 17:47:14 +09:00
Carsten Haitzler 9d8c829c2f elm app client - check return of eldbus_message_iter_arguments_get
as accoding to coverity CID 1353593 chekc returns of the above
function and return/continue as apporpriate if these fail (which
generallly they shouldnt unless some end of the dbus client is broken).
2016-08-08 17:47:14 +09:00
Carsten Haitzler c827d42fbd elm_need_efret() - improve error handling according to coverity
fix CID 1360466

we don't actually chekc if efreet inits right with elm_need_efreet()
as we just assume it inits (And there pretty much is no case where it
will not), but make coverity happy and check.

@fix
2016-08-08 17:47:14 +09:00
Sungtaek Hong 2de14b985c elm_map: fix wrong check of source search
Summary:
When map source is set by elm_map_source_set(),
it foreaches enlisted sources, and should return
when the source cannot be found.

@fix

Test Plan:
Call elm_map_source_set(map, [any type], [Wrong source name]);
         Observe  ERR("source name (%s) is not found", source_name) message.

Reviewers: Hermet, cedric, jpeg

Reviewed By: jpeg

Subscribers: conr2d

Differential Revision: https://phab.enlightenment.org/D4212
2016-08-08 15:16:53 +09:00
Carsten Haitzler 9e09c46574 elm config - dont rescale ui if no config that needs rescale changed
also finger size, and other thigns that could affect ui look that may
need elm rescale to work.

this fixes T4296

@fix
2016-08-06 18:10:36 +09:00
Cedric Bail a7bb1662e2 Revert "elementary/layout: attach edje object API with eo compositing"
This reverts commit 8a988717e1.

It seems we can't actually inherit from class more than once and neither eo
nor eolian will complain about it. You will just get random weird behavior.
This patch should come back once we have made an interface of edje.
2016-08-05 11:09:55 -07:00
Shinwoo Kim 89d5479c0b atspi: toolbar - fix cannot call select callback
There is a line to check select_mode in _item_select function.
The item selected(clicked) callback is called when the select_mode is ELM_OBJECT_SELECT_MODE_NONE.
The checking select_mode should be handled at one place.
2016-08-05 16:17:13 +09:00
Jean-Philippe Andre 28c917836c efl: Cleanup some code (return values)
This removes some useless code in various places, where the
switch from eo_do() to standard function call was not properly
refactored.

This changes:

type ret = 0;
ret = my_eo_function();
return ret;

To:

return my_eo_function();
2016-08-05 10:32:30 +09:00
Jean-Philippe Andre 26ee77ff67 evas image: Lower ERR message to WRN and fix it
In elm_image, efl_file_get() was called on a legacy Evas Image
object, which generated an ERR message. This was way too much
noise for something that actually works.

It's best not to call efl_file_get/set API on a legacy
object, but it can be convenient for smooth code transitions
from legacy to pure eo.

Also, add safety to those APIs.

Test case: elm_test genlist dnd, start dragging anything.
2016-08-05 10:32:30 +09:00
Carsten Haitzler 8dd27f2fd9 elm tooltips - fix positioning cornercases
this should fix T4277
2016-08-04 23:23:30 +09:00
Daniel Hirt 44569b859a Elm.Entry: use proper theme_set function on edje object
Shouldn't use elm_widget_theme_object_set for handlers/anchors here.

Fixes T4091.
@fix
2016-08-04 13:27:08 +03:00
Hermet Park b07617ea76 elementary widget: actually this is a right fix than fa4a72d3fc
Now rage and enventor both will be fine.
2016-08-04 16:44:06 +09:00
Carsten Haitzler fa4a72d3fc elm key events/disabling/focus - fix after another disabled widget fix
this fixes key events in rage again after
ea2b5e4048 broke them. this fixes T4285
2016-08-04 16:37:21 +09:00
Carsten Haitzler a3e7413992 elm image - silence warnings of setting smooth if image is edje 2016-08-04 08:17:18 +09:00
Stefan Schmidt 9f5e5ae732 elm: scrollable: add guards to include eo and legacy header only when allowed
Make sure the eo and legacy headers are only included when the matching defines
are enabled.
2016-08-03 15:03:37 +02:00