Subject: RE: [E-devel] One bug in _edje_key_down_cb func (in
edje_entry.c)
I found one bug in _edje_key_down_cb func (in edje_entry.c)
When I input "Backspace" in an entry object, _signal_cursor_chagned_func(in
elm_entry.c) is not called.
This is because the following code in _edje_key_down_cb func (in edje_entry.c)
is not called.
if ((evas_textblock_cursor_compare(tc, en->cursor)) && (!cursor_changed))
_edje_emit(ed, "cursor,changed", rp->part->name);
Why not called ? Because ~ evas_textblock_cursor_compare(tc, en->cursor)
returns 0.
(i.e. old cursor and current cursor have the same position information)
I think old cursor should keep its position without any updating.
But in evas_textblock_cursor_char_delete() func, called by _backsapce func
(in edje_entry.c) -
old cursor's postion is updated as the current position.
SVN revision: 57199
Passing the correct data to _edje_entry_imf_event_delete_surrounding_cb and _edje_entry_imf_retrieve_surrounding_cb
Fix indentation.
Patch by Jihoon Kim.
SVN revision: 54365
Entry widget has not processed the key event of keypad such as KP_Left,
KP_Right, KP_Home, KP_End, and so on.
In this patch, those key events is processed.
SVN revision: 54359
Fixed formatting issues.
Fixed typos.
Fixed clearing of selection when pressing a key in a software keyboard.
Patch by Jihoon Kim and small adjustments by myself. Thanks a lot.
SVN revision: 51897
Apply badzero.cocci, badnull.coci and badnull2.cocci
This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:
code before patch ||code after patch
===============================================================
return a == NULL; return !a;
return a != NULL; return !!a;
func(a == NULL); func(!a);
func(a != NULL); func(!!a);
b = a == NULL; b = !a;
b = a != NULL; b = !!a;
b = a == NULL ? c : d; b = !a ? c : d;
b = a != NULL ? c : d; b = a ? c : d;
other cases:
a == NULL !a
a != NULL a
SVN revision: 51487
* Remove vim modelines:
find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;
* Remove leading blank lines:
find . -name '*.[cxh]' -exec sed -i '/./,$!d'
If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0
SVN revision: 50816
WARNING: I don't know why in the first it doesn't map correctly to
an object. So if someone with more knowledge on this piece of code
could give it a look.
SVN revision: 49613
This fix the issue with elementary cursor end set function.
The cursor is now after the last textblock node, and not before it, as
it was until now.
SVN revision: 49242