Commit Graph

63865 Commits

Author SHA1 Message Date
Cedric Bail 29beda7f4f evas: fix memory leak with Efl.Canvas.Vg
Summary:
It is not correct to change the parent and hope that refcount will work
for you. The parent chain is a decision made by the user, not something
a widget can touch. Only ref count are to be used when given an outside
object. As things where not triggering destruction, there was also no
point where the image buffer would be getting to zero and be freed. This
commit also fix this.

Reviewers: Hermet, zmike

Reviewed By: Hermet

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10169
2019-09-27 14:19:38 +09:00
Jaehyun Cho 04a2b7a048 theme: remove efl.track.slider and efl.track2.slider from efl_ui_slider
Summary:
efl_ui_slider does not support popup which shows the current value.
Therefore, efl.track.slider and efl.track2.slider swallows which set the
popup size and position are not required in efl_ui_slider.

Reviewers: zmike, woohyun

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10216
2019-09-26 23:21:48 -04:00
Mike Blumenkrantz 6443120eb3 evas/object; fix null deref
Summary:
_efl_canvas_object_clipper_prev_reset() derefs obj->cur

CID 1396985
Depends on D10211

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10212
2019-09-26 18:00:05 -04:00
Mike Blumenkrantz 64799b32a1 eio/dir: fix null deref
Summary:
above cases may fail, causing target to be null

CID 1399103
Depends on D10210

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10211
2019-09-26 17:59:59 -04:00
Mike Blumenkrantz a50bd311ab efl_ui/image fix null derefs
Summary:
CID 1405781, 1405780
Depends on D10209

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10210
2019-09-26 17:59:54 -04:00
Mike Blumenkrantz 4a3b4e3b4a efl_ui/scroll_manager: fix null derefs
Summary:
CID 1405811, 1405804
Depends on D10208

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10209
2019-09-26 17:59:49 -04:00
Mike Blumenkrantz f7befea043 efl_ui/table: handle case where table has no items
Summary:
CID 1399086
Depends on D10207

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10208
2019-09-26 17:59:43 -04:00
Mike Blumenkrantz b2165b8921 ecore_evas/convert: fix div by zero
Summary:
if one is 0, the printf line will divide by it

CID 1403900
Depends on D10206

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10207
2019-09-26 17:59:38 -04:00
Mike Blumenkrantz 88da46d3f6 tests/eina: outdent code
Summary:
this is a very important coverity issue.

CID 1400838
Depends on D10205

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10206
2019-09-26 17:59:34 -04:00
Mike Blumenkrantz cd97c2a0b7 eina/list: move dead code inside corresponding #ifdef
Summary:
this is debug code

CID 1404753, 1404745
Depends on D10204

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10205
2019-09-26 17:59:29 -04:00
Mike Blumenkrantz 2584adae08 tests/strbuf: call va_end for varargs
Summary: CID 1400792

Reviewers: brunobelo

Reviewed By: brunobelo

Subscribers: brunobelo, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10204
2019-09-26 17:59:24 -04:00
Mike Blumenkrantz b5ee2f128f epp: remove extra variable passed in format specifier
Summary: CID 1402674

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10203
2019-09-26 17:59:19 -04:00
Bruno da Silva Belo 7ba4f00f57 eolian_cxx: Possible infinite loop, if called.
Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10200
2019-09-26 18:53:23 -03:00
Mike Blumenkrantz 68b1cfe5d6 efl_ui/item_clickable: mark beta again
Summary:
this isn't strictly necessary at the moment

Depends on D10197

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10199
2019-09-26 18:00:32 +02:00
Mike Blumenkrantz bc855ec8b6 theme: add spec documentation for all stabilized theme groups in 1.23
Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing

ref T8231
Depends on D10196

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10197
2019-09-26 18:00:32 +02:00
Mike Blumenkrantz 253e7d51db theme: remove efl_ui_slider "disabled" styles
Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10196
2019-09-26 18:00:32 +02:00
Mike Blumenkrantz 2d206757ed tests/check: add port of check widget mouse testing for efl_ui_check
Summary:
coverage++
Depends on D10194

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10195
2019-09-26 18:00:32 +02:00
Mike Blumenkrantz 5256b9476d efl_ui/layout: improve error message when theme version parsing fails
Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10194
2019-09-26 18:00:32 +02:00
Mike Blumenkrantz 6f6407729e efl_ui/layout: fix shadow warning
Summary:
a variable with the same name is declared above
Depends on D10192

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10193
2019-09-26 18:00:31 +02:00
Mike Blumenkrantz a21dacbad6 efl_ui/layout: use better check for determining whether to defer signals
Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10192
2019-09-26 18:00:31 +02:00
Daniel Kolesa 79aa86df5a eolian: better error message for const on strings 2019-09-26 17:33:44 +02:00
Mike Blumenkrantz d2d4fcce48 ecore-x: protect against accidentally "un-managing" the root window
Summary:
block calls to XSelectInput with the root window if the root window is
currently being "managed" in-process in order to avoid breaking the
running wm
Depends on D10013

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10014
2019-09-26 11:23:24 -04:00
Mike Blumenkrantz 2f7b359183 ecore-x: add internal function for selecting just properties of root window
Summary:
this is just a shortcut for watching properties in the case where no wm is
active in the process
Depends on D10012

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10013
2019-09-26 11:23:12 -04:00
Mike Blumenkrantz 2bc6754d39 ecore-x: track whether ecore-x is internally "managing" the root window
Summary:
when ecore_x_window_manage is called, this is probably only for the case of
managing the root window, i.e., running a window manager. store this state
internally so that we can avoid calling additional XSelectInput later and
fucking up the expected eventing

Depends on D9899

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10012
2019-09-26 11:23:01 -04:00
Mike Blumenkrantz fddc27ed40 ecore-evas/x: detect and track wm existence, apply visibility correctly
Summary:
this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether
a wm exists, and bypasses waiting for a configure event from a nonexistent wm
if the screen is not currently managed

fix T7838

Depends on D10014

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7838

Differential Revision: https://phab.enlightenment.org/D9900
2019-09-26 11:22:44 -04:00
Mike Blumenkrantz 9d16a44334 ecore-x: fix null derefs in window prop code
Summary:
handle cases where null params could be passed and cause crashes

@fix

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9899
2019-09-26 11:22:32 -04:00
Daniel Kolesa f37c996ad4 efl_mono: remove spurious const 2019-09-26 17:17:29 +02:00
SangHyeon Jade Lee d4c4d8f0f4 efl_core : stabilized Efl.Generic_Model
Summary:
stabilzed Efl.Generic_Model

depends on D10188

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10189
2019-09-26 11:06:22 -04:00
SangHyeon Jade Lee 33512079cd efl_ui : stablized Efl.Ui.View
Summary:
Efl.Ui.View is base infrastructure interface of MVVM.

fixes T7578

Reviewers: zmike, cedric, segfaultxavi, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7578

Differential Revision: https://phab.enlightenment.org/D10188
2019-09-26 11:06:22 -04:00
Daniel Kolesa b0ee540ec9 eolian: rename param direction enum and fields for consistency 2019-09-26 16:56:13 +02:00
Daniel Kolesa cdff7852e0 eolian: loosen the requirements on API (don't return stringshare) 2019-09-26 16:47:22 +02:00
Daniel Kolesa 6d93dc4cbf eolian: rename event_prefix to event_c_prefix for consistency 2019-09-26 16:47:22 +02:00
Daniel Kolesa 7e10d96d27 eolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section 2019-09-26 16:47:21 +02:00
Mike Blumenkrantz f5a4fd89d9 efl_ui/item_clickable: fix event info for press events
this is just a button and not the full clickable struct

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198
2019-09-26 16:30:32 +02:00
Daniel Kolesa a95870286e eolian: stricter checks for const() validity 2019-09-26 16:19:12 +02:00
WooHyun Jung 23bbf2bf3a efl_ui_image: fix a wrong return value of legacy API
Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.

Reviewers: zmike, segfaultxavi, bu5hm4n

Reviewed By: zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10186
2019-09-26 09:00:09 -04:00
WooHyun Jung 3bdd50e412 edje_legacy: add validation check to return legacy default value
Summary:
When invalid object comes, the return value should be
EINA_FALSE.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10185
2019-09-26 08:59:31 -04:00
WooHyun Jung ddb28ccdf1 efl_ui_win: add validation check to return legacy default value
Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10187
2019-09-26 08:59:28 -04:00
Marcel Hollerbach 8197fee189 efl: mark selectable stable
Summary:
fixes T7871
fixes T7852

This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.

Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike

Reviewed By: segfaultxavi

Subscribers: SanghyeonLee, cedric

Tags: #efl

Maniphest Tasks: T7871, T7852

Differential Revision: https://phab.enlightenment.org/D10184
2019-09-26 13:06:24 +02:00
Marcel Hollerbach 1df17abba5 efl_ui_*selectable: unify these APIs with the same c_prefix
Summary:
with this commit that api for single and multi selectable shares the
same prefix, which makes sense in c as we do not really differ between
those two types there anyway.

ref T7871

Reviewers: SanghyeonLee, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7871

Differential Revision: https://phab.enlightenment.org/D10183
2019-09-26 18:32:58 +09:00
SangHyeon Jade Lee a4f5da0fb2 efl_ui : add document comment on efl_ui_item_clickable event data
Summary: Add document comment on Efl_Ui_Item_Clickable.Clickable_Clicked.

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10181
2019-09-26 10:46:17 +02:00
Cedric Bail 41d0ead833 elementary: stabilize Efl.Ui.Item_Clickable.
Summary: Depends on D10177

Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10173
2019-09-25 21:59:29 -04:00
Cedric Bail 26d5b7366e elementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.
Summary: Depends on D10176

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10177
2019-09-25 21:59:25 -04:00
Cedric Bail b8af6c17fc elementary: temporary workaround include issue that prevent acces to Evas_Eo.h
Summary: Depends on D10175

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10176
2019-09-25 21:59:20 -04:00
Cedric Bail 7cf364f270 elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable
Summary: Depends on D10171

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10175
2019-09-25 21:59:14 -04:00
Cedric Bail 4c3dce94eb elementary: stabilize Efl.Ui.Collection_View.
Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8261

Differential Revision: https://phab.enlightenment.org/D10171
2019-09-25 21:59:09 -04:00
Mike Blumenkrantz 593b7426ae api: mark Efl.Ui.Image_Zoomable stable
Summary:
ref T7875
Depends on D10125

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7875

Differential Revision: https://phab.enlightenment.org/D10126
2019-09-25 17:56:38 -04:00
Mike Blumenkrantz b59c00864c api: mark Efl.Gfx.Image_Load_Controller stable
Summary:
fix T7876
Depends on D10124

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7876

Differential Revision: https://phab.enlightenment.org/D10125
2019-09-25 17:56:33 -04:00
Mike Blumenkrantz 8e17112c76 api: mark efl.gfx.image and related types stable
Summary:
fix T7875
fix T7926
fix T7927
fix T7926
fix T7929

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7929, T7927, T7926, T7875

Differential Revision: https://phab.enlightenment.org/D10124
2019-09-25 17:56:29 -04:00
Mike Blumenkrantz 59709bc907 theme: migrate all efl,anim,activate (and similar) signals to efl,state,animation,activated
Summary:
ref T8231
Depends on D10166

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10167
2019-09-25 17:56:17 -04:00