This patch is a list version of genlist patch cc827fef6.
Now, list does not autoscroll to last focused/selected item when the list
is focused. It tries to find the nearest visible item instead of the
last focused/selected item.
event.
When you use mouse(touch) that triggers mouse up event, the
focus/selection movement is done by mouse up callback, so don't need to
handle on_focus event when mouse(touch) is used.
You can reproduce the bug by the following step.
1. launch elementary_test -> list focus, genlist focus, gengrid focus
2. focus an item (by touch, by key)
3. move focus to left button (by touch, by key)
4. click an another item (by touch)
5. previously focused item will be unfocused again even it was unfocused
at step #3/
Special thanks to Amitesh for the report.
Focus is moved by mouse click by default. This patch makes moving focus
by mouse_in optionally by configuration and API. Widget item focus
movement is not applied yet. Need to do that as well.
- configuration: "focus_move_policy"
- API: elm_config_focus_move_policy_set/get
- enum
ELM_FOCUS_MOVE_POLICY_CLICK
ELM_FOCUS_MOVE_POLICY_IN
@feature
- Added focus highlight enable/disable option.
- Added a button to set the focus to 2nd item after 1.5 seconds.
- Added a button to select the 2nd item after 1.5 seconds.
- Removed unnecessary frame and lable for the test.
This commit is a gengrid version of 7d43205a0.
Now it works so much better than before.
- Fixed the separate behavior between selected item and focused item.
- Fixed wrong focus set when gengrid is focused first time by mouse.
- Fixed wrong scroll movement when the focus highlight is disabled.
- Item selection sets that item focused. So when an item is selected, do
not need to set the focus again.
Now it works so much better than before.
- Fixed the separate behavior between selected item and focused item.
- Fixed wrong focus set when genlist is focused first time by mouse.
- Fixed wrong scroll movement when the focus highlight is disabled.
- Item selection sets that item focused. So when an item is selected, do
not need to set the focus again.
- Fixed wrong call for _elm_genlist_item_content_focus_set on deleted
item.
Item selection also sets the focus automatically so do not need to set
focus twice. This code needs to be changed later again when the
selection by key arrow becomes optional.
of highlighted_item.
highlighted_item will be NULL after the first click and it is not
useful. To avoid first item focus -> first item unfocus -> clicked
item focus on the first focus to list widget, this patch is needed.
Thanks for the report Ceolin.
Summary:
Currently there is a overlap issue in naviframe in case of multiple push.
This issue will occur if the naviframe edc implements push,defered for
the item transition. The issue occurs becoz of cur,push,deffered is not being
called to the current and intermediate items during multiple item push.
To fix the above issue pass the data as current item that needs to be
out of the aviframe during creating the animator job.
@fix
Reviewers: Jaehyun, seoz, Hermet
Reviewed By: Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D645
Summary: Since explanations of tooltip's APIs are scattered in header or source code, these needs to be cleared up.
Reviewers: seoz, Hermet, woohyun, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D644
Summary:
Selection handlers' position are not updated when entry is scrolled.
You can check on elementary_test -> Entry 3 (or Entry 4 which is scrollable) -> Select some text -> Scroll entry and see.
This patch is submitted to fix this bug. It update selection handlers' position when entry is scrolled and hide them if needed.
@fix
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D640
Summary:
This patch adds a field "no_string" in key binding data structure.
It is necessary for checking "string" field in evas key down event.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D641
CID 1193237
Before Eolian, a Eina_List ** was used and checking ret value was
mandatory. Now that we have a normal Eina_List *, we don't need to check
that anymore.
When focus is changed, focus highlight animation should be started
from the original position of focus highlight object. Not from the
previous focused object's position.
Added two buttons.
1. focus 3rd list item by elm_object_item_focus_set() API after 1.5 seconds.
2. select 3rd list item by elm_list_item_selected_set() API after 1.5 seconds.
Summary:
Type matching for drag and drop targets does not consider drop target objects' types.
For example, we have drag object which provides image type and drop target object which only accepts text type.
For current code, in _x11_dnd_drop function, we only check savedtypes.types with _x11_atoms.
As result, we allows the image to be dropped into text. You can refer to the test in D617.
This path fixes this issue by matching drag object's type with drop targets' types to find suitable one.
@fix
Reviewers: raster, JackDanielZ, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D628
Now, genlist does not autoscroll to last focused/selected item when the genlist
is focused. It tries to find the nearest visible item instead of the
last focused/selected item.
If the type returned by evas_object_type_get is "", no object will be
created. There is no reason why unref would be invoked.
It removes all the bad prints in accessibility tests about obj_id NULL.
@fix
Summary:
Currenlty loading a style that is not present in the system hits the worst case path in elm_theme as it searches through all hirarchy before
reporting that the style is not there. if those styles requested frequently it will be a overhead as it will goes through all the theme files again.
To avoid that I have added a cache which will keep track of the styles whose loading were not sucessfull so that for future request we can simply check the
cache before looking into the hirarchy of theme files.
Reviewers: seoz, raster
Reviewed By: raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D601
Daniel Zaoui
Daniel Juyung Seo
Amitesh Singh
zmike
Daniel Juyung Seo
ChunEon Park
Jaeun Choi
Subhransu Sekhar Mohanty
nirajkr
Ryuan Choi
Bora Hwang
Thiep Ha
WooHyun Jung
Flavio Ceolin
Carsten Haitzler