Commit Graph

148 Commits

Author SHA1 Message Date
Daniel Juyung Seo d9637f96b7 elc_fileselector.c: fixed formatting. 2013-08-22 05:24:46 +09:00
Ryuan Choi 5cfb0d9b7c fileselector: Simple refactoring to fix possible leak.
This fixes "Resource leaks" which was spotted by coverity. CID 1054518
2013-08-06 20:08:16 +09:00
Yakov Goldberg 5ed1390c9f fileselector: unfocus if anchor clicked/entry activated
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
2013-08-06 11:17:40 +03:00
Yakov Goldberg a355c3f3f5 fileselector: fix show filename in anchor for some cases
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
2013-08-06 11:17:40 +03:00
Yakov Goldberg de24d2c5c0 fileselector: fix typo + behavior
- _anchors_do() receive fileselector object as first parameter,
    in _on_text_unfocused cb fileselector passed as 'data' and not as
    'obj';
 - when entry is unfocused, it can contain usual text or anchor-styled text,
   so the only secure way to pass path is to pass sd->path.
2013-08-06 11:17:40 +03:00
Yakov Goldberg b26418ae7d fileselector: added TODO note
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
2013-08-06 11:17:40 +03:00
ChunEon Park 99921e7f7e Revert "elementary/fileselector - added new api. elm_fileselector_entry_entry_get()"
This reverts commit c699ec2158d6ee56fc8cf07c3ded2b2688267f28.

Since "selected" smart callback returns the current entry text,
This is not necessary.
2013-07-29 11:42:23 +09:00
ChunEon Park 71358bdeb4 elementary/fileselector - added new api. elm_fileselector_entry_entry_get() 2013-07-29 01:31:49 +09:00
Daniel Juyung Seo 2e3fb71933 elc_fileselector.c: check null for part name and set the label for another part as well. 2013-07-23 06:11:30 +09:00
ChunEon Park 95ca372382 elementary/fileselector - support elm_object_part_text_set() to set the ok, cancel button label. 2013-07-23 01:51:27 +09:00
Ryuan Choi f12b32955a Revert "Remove redundant check routine what elm_entry_utf8_to_markup() returns."
This commit is invalid.
It just use strdup and strdup may return NULL when memory is not enough.

This reverts commit f579f7fd4b5e863f01a001876e536f5becc40811.
2013-07-18 10:26:27 +09:00
Ryuan Choi 51e684553b Cleanup _on_item_selected
Just return for the exception and avoid unnecessary allocation.
2013-07-18 02:56:50 +09:00
Ryuan Choi d6b87a1859 Remove redundant check routine what elm_entry_utf8_to_markup() returns.
elm_entry_utf8_to_markup() always returns allocated string.
So, we don't need to check what it returns.
2013-07-18 02:01:43 +09:00
Ryuan Choi 0ccfc31ee1 fileselector: Fixed regression of rELM3d2ae6d25ddc
https://phab.enlightenment.org/T198

After rELM3d2ae6d25ddc, buttons are destroyed when ok_cancel_set(true) is
called twice.
Spotted by uartie.
2013-06-29 07:27:23 +09:00
Ryuan Choi 27f6087892 Prefer eina_stringshare_strlen for shared strings 2013-06-27 19:24:18 +09:00
Ryuan Choi 989c343d16 fileselector : Fix Segfault in elementary file_selector_example when closed
https://phab.enlightenment.org/T133

list_itc and grid_itc are static variables, but they were managed by file_selector instance.
For example, they are allocated two times and first allocated classes are dangling
when two file selector are created.

This patch moves their init/deinit logic to constructor/destructor of file selector class.
2013-06-27 15:38:46 +09:00
Ryuan Choi fec9eab52c fileselector: Fix possible leak of _buttons_ok_cancel_set
When called _buttons_ok_cancel_set(true) two times,
buttons are created without release.
2013-06-25 06:08:18 +09:00
Ryuan Choi 2cfa0ce7db file selector:Add support mime type filter 2013-06-24 15:42:51 +09:00
Daniel Juyung Seo c7cfcc43f2 elc_fileselector.c: check null path before fileselector populate.
If no path was selected we don't need to populate fileselector.
This fixes https://phab.enlightenment.org/T132.
Thanks uartie for the report.
2013-06-12 15:03:49 +09:00
Stefan Schmidt 06c869eece elc_fileselector: Small formatting fix.
Spotted by devilhorns. Somehow I feel watched here. ;)
2013-06-11 08:48:20 +01:00
Stefan Schmidt 33eca6e2c0 elc_fileselector: Fix memory leak in _selected_set.
Using ecore_file_dir_get() like this will leak the returned string as we
have no way to control its free'ing. Better use a separate variable for it.
2013-06-10 15:47:54 +01:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
Daniel Juyung Seo 74b3eed5fd elm: print the error message inside elm_widget_sub_object_add().
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
   Elm devs should fix it beforehand.
   So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
Tom Hacohen d75cb616da Change usage of eo_do_super to the new prototype. 2013-03-18 16:15:12 +00:00
Daniel Juyung Seo 78c042cdbe elm *.c: fixed formatting with EINA_LIST_FREE.
EINA_LIST_FREE (xxx) -> EINA_LIST_FREE(xxx)
2013-03-09 13:23:42 +09:00
Gustavo Lima Chaves 312d0217a0 An internal layout error, on a widget set, is a CRITICAL error. 2013-03-01 23:04:31 -03:00
Daniel Zaoui cdd1eea853 Replace supported_types
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 83803
2013-02-10 07:52:31 +00:00
ChunEon Park dacd0c80c1 elementary/fileselector - ++ unused
SVN revision: 82155
2013-01-04 07:38:26 +00:00
Flavio Vinicius Alvares Ceolin 06414efc47 [elm] file_selector: making the widget more desktop
friend

Allowing select dir/file in the entry box.



SVN revision: 82105
2013-01-03 20:48:14 +00:00
Daniel Zaoui 0c915e9023 Cleaning: removed include Eo.h in widgets because it was indirectly included by Elementary.h
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79682
2012-11-26 09:29:01 +00:00
Yakov Goldberg 5c98343198 We have ported to Eo all the widgets of elementary. We didn't change the inheritance itself, only the mechanism, as done previously in Evas, Ecore and Edje. We removed totally the previous inheritance mechanism.
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79668
2012-11-26 06:32:53 +00:00
Daniel Juyung Seo 30dba54610 elm: Fixed indentations for EINA_LIST/INLIST_FOREACH(_SAFE).
SVN revision: 77244
2012-10-01 07:36:27 +00:00
Gustavo Lima Chaves 7347460504 [elm] Remove duplicated code.
SVN revision: 75054
2012-08-09 14:46:58 +00:00
Gustavo Lima Chaves 12f50a523b [elm] File selector now inheritable.
SVN revision: 74756
2012-08-01 21:03:33 +00:00
Carsten Haitzler 84643ee0f2 fix fileselctor to not display > next to files... in expand mode.
SVN revision: 74386
2012-07-25 11:19:59 +00:00
Gustavo Lima Chaves 584c53c1be [elm] New elm_widget_add() usage spread.
SVN revision: 74148
2012-07-18 21:03:39 +00:00
Gustavo Lima Chaves dbd0cb20c9 [elm] Old cosmetical diff flush.
SVN revision: 73992
2012-07-17 14:56:23 +00:00
Michael BOUCHAUD b5e474ebb1 elementary: I think this needs some fixing. fileselector, select the wrong dir
SVN revision: 72834
2012-06-26 00:10:15 +00:00
Davide Andreoli 8babe97704 whops, this file wasnt mean to be committed
SVN revision: 71968
2012-06-11 23:35:05 +00:00
Davide Andreoli 5a1213ec8c evas only handle premul colors (note: not making any news or bp)
SVN revision: 71965
2012-06-11 23:25:43 +00:00
Davide Andreoli 5872d450d7 Fileselector: Add a wheel spinner that show/spin while EIO is working
SVN revision: 71178
2012-05-16 19:40:47 +00:00
Davide Andreoli 0c7ab74390 Simplify file listing when using EIO
SVN revision: 71129
2012-05-15 20:02:59 +00:00
Davide Andreoli be531ba2af * Fileselector: honor folder_only when using EIO
* Fileselector test: add a check to enable/disable buttons

 Updated Changelog and NEW, also add myself as authors...

 btw: the EIO code in the Fileselector is crazy-complex, about 200 
 lines of code just to have the list of files ina dir...  :/



SVN revision: 70965
2012-05-13 12:23:39 +00:00
Gustavo Lima Chaves 6a18b15a1b [elm] Fix booboos for people not having eio,
ewebkit or emotion.



SVN revision: 70749
2012-05-03 22:45:01 +00:00
Gustavo Lima Chaves 7abded1fb1 [Elm] File selector now a layout.
SVN revision: 70742
2012-05-03 22:44:26 +00:00
Carsten Haitzler c0f2f4be91 REVERT!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
this breaks theme api. so NO! come back with a version that doesn't
break it.



SVN revision: 70679
2012-05-03 01:19:05 +00:00
Gustavo Lima Chaves e275948e76 [elm] Fix booboos for people not having eio, ewebkit or
emotion.



SVN revision: 70677
2012-05-02 21:14:28 +00:00
Gustavo Lima Chaves 57b848157f [Elm] File selector now a layout.
SVN revision: 70665
2012-05-02 17:01:48 +00:00
Carsten Haitzler 3a7b769a63 use the new escape text set to clear up issues if theme has TEXT vs
TEXTBLOCK items and handling escapes so text is consistend across elm.
fiuxes the fileselector issues kai reported.



SVN revision: 70362
2012-04-20 12:51:10 +00:00