Stefan Schmidt
2389d7f8ee
ecore_imf: Account for terminating null byte on copy
...
strlen retruns the count with the terminating null byte but strncpy expects
length with it. Account for that.
2014-05-16 13:54:54 +02:00
Stefan Schmidt
6924e3010c
ecore_imf: Avoid potential buffer overrun
...
We can't just blindly copy the full string into a 128 byte buffer. Adding
some check here to actually stay below the buffer limit or return.
CID 1193233
2014-05-16 13:52:26 +02:00
Jérémy Zurcher
9a79d1e864
silence a few warnings
2014-05-08 00:15:53 +02:00
Jihoon Kim
2c0c2b0fed
ximimmodule: fix dereference after null check
...
CID 1162749: Dereference after null check (FORWARD_NULL)
/src/modules/ecore_imf/xim/ecore_imf_xim.c: 1027 in _ecore_imf_xim_preedit_draw_call()
2014-01-22 09:46:24 +09:00
Carsten Haitzler
82541d2c2f
ecore xcim module - don't printf every time you start to add stdout noise
2014-01-15 09:55:05 +09:00
Chris Michael
3ddb62d8d3
Add EINA_UNUSED for unused function parameter
...
Signed-off-by: Chris Michael <devilhorns@comcast.net>
2014-01-04 11:17:01 +00:00
Jihoon Kim
8c819cf214
scimimmodule: remove unused code
...
need_commit_preedit was always false, so those code are useless.
2014-01-03 16:23:50 +09:00
Jihoon Kim
d6d8a910fe
scimimmodule: support super key (between ctrl and alt key)
2014-01-02 15:08:01 +09:00
Jihoon Kim
a37bf01a53
scimimmodule: code refinement related to key modifier and lock
2014-01-02 15:00:51 +09:00
Jihoon Kim
6a5c7dc7a3
ibusimmodule: support CAPS LOCK and NUM LOCK
...
When ibus immodule was used, caps lock and num lock had been not working.
2013-12-31 18:07:36 +09:00
Jihoon Kim
3191776c01
ibusimmodule: fix segmentation fault
...
This patch fixes "free(): invalid pointer issue"
2013-12-31 10:03:45 +09:00
Daniel Juyung Seo
76d8532b54
efl: Unified eina critical manro to CRI.
...
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 12:27:13 +09:00
Jihoon Kim
75e399158c
ibusimmodule: fix dereference after null check issue
...
The variable 'str' was used after checking NULL.
2013-12-19 10:20:42 +09:00
Jihoon Kim
236c9a1520
ibusimmodule: support preedit style
...
This patch will support to display the style of preedit such as underline, reverse.
2013-12-13 20:17:19 +09:00
Rafael Antognolli
15b5497dfa
ecore_imf/wayland: Only call hide_input_panel on im_context_hide().
...
There's no need to call it on text_input_leave too, otherwise this would
be called twice, the one from text_input_leave possibly being called
after the focus was regain already by a text input, causing the bug
described in T237.
This fixes T237.
2013-12-09 14:25:40 -02:00
Jihoon Kim
3dfc3dcd2c
ximmodule: fix issue the cursor of preedit shows the in front of preedit string
...
Before fixing this issue, the cursor of preedit appears the in front of preedit string.
The cursor of preedit string will appear in the proper position.
2013-12-05 16:06:39 +09:00
Jihoon Kim
0eb5cfaa30
ximimmodule: remove useless code in preedit_string_get
...
'cursor_pos' variable will be set in the below code, so 'cursor_pos = 0' is useless.
2013-12-05 16:00:39 +09:00
Jihoon Kim
8fe2ec9d4b
ximmodule: check whether pointer is NULL before accessing in xim_preedit_callback_set
...
ecore_imf_context_data_get () can return NULL, so it should be checked before using the result value.
This fixes CID 1135273
2013-12-03 13:32:15 +09:00
Jihoon Kim
d9e7615a52
xim immodule: fix dereference before NULL check issue in client_window_set
...
The variable 'info' can be NULL, therefore it should be checked before accessing.
This fixes CID 1039640
2013-11-29 11:35:44 +09:00
Jihoon Kim
bab7612bb5
ibusimmodule: check whether pointer is NULL or not before accessing.
...
The pointer variable str can be NULL, therefore we should check whether it is NULL or not
before accessing.
This fixes CID 1132621, 1132622, 1132623
2013-11-29 11:23:29 +09:00
Daniel Juyung Seo
0e0f79c6f2
ecore ibus_imcontext: print the value of cursor_pos only when cursor_pos
...
is not null.
This fixes coverity CID 1132624.
2013-11-27 01:52:21 +09:00
Daniel Juyung Seo
9314b15add
ecore scim_imcontext: do not check null for ic. it was already checked
...
by EINA_SAFETY_ON_NULL_RETURN.
This fixes coverity CID 1132628.
2013-11-27 01:48:58 +09:00
Chris Michael
0e4b25747f
Don't call input panel show/hide methods unless input_panel_enabled is
...
true.
Fixes Phab Ticket T501
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-11-15 08:44:19 +00:00
Rafael Antognolli
18ef47c173
ecore/wayland: Use eina_inlist instead of wl_list for globals.
...
Since we are allocating this list and returning it, let's make it more
EFL-like.
2013-11-04 13:50:04 -02:00
Rafael Antognolli
b77ac9b57e
ecore/wayland: Add ecore_wl_window_keyboard_get().
...
Instead of use direct access to the Ecore_Wl_Window structure, just use
the getter, so we can hide the internals.
2013-11-01 15:51:38 -02:00
Rafael Antognolli
dd18206d86
ecore/wayland: Do not use win->id directly.
...
Use a getter for it instead, so we don't need to expose the
Ecore_Wl_Window struct just because of it.
2013-10-31 21:35:13 -02:00
Rafael Antognolli
e56428f4ad
ecore/wayland: Make Ecore_Wl_Input private.
...
It's mostly only used inside ecore_wayland library anyway.
The only bit needed outside of the library is the "seat" pointer, but a
new function was added to retrieve such pointer from Ecore_Wl_Input.
2013-10-31 21:35:13 -02:00
Rafael Antognolli
35d2f195de
ecore/wayland: Hide Ecore_Wl_Display.
...
This struct is only used inside ecore_wayland itself, so there's no real
reason to expose it. Apparently, hiding it doesn't break anything,
except for the ecore_imf wayland module, which was easily fixed.
If anyone notices a breakage, please let me know.
2013-10-31 21:35:13 -02:00
Jihoon Kim
6ff49dbc70
ecore_imf: Fix memory leak in scim immodule
2013-09-12 11:49:06 +09:00
Chris Michael
4d54c97864
Remove calls to ecore_wl_init and ecore_wl_shutdown.
...
NB: These calls are NOT needed here (they setup and tear down the
actual wayland display fd connections, and are not necessary in order
to use ecore_wl functions).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-01 12:50:41 +01:00
Chris Michael
a48c4cd064
Check for valid text_input object before trying to call wayland
...
functions on it.
NB: Wayland (internal) functions typically do not do Any object
validity checking, so lets be proactive and do it here first.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 09:15:43 +01:00
Chris Michael
47a7f74453
Fix indentation of some if statements
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 09:10:42 +01:00
Chris Michael
345351d736
Fix formatting so I can actually read this code in 80 columns ;)
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 09:08:50 +01:00
Chris Michael
449c0c72b0
Check for valid returns of ecore_wl_registry_get and
...
ecore_wl_globals_get before trying to use them.
After we have bound a text input manager, there is no need to keep
looping the globals, so break out.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 07:23:58 +01:00
Chris Michael
1832bf5c03
Fixup formatting.
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 07:11:32 +01:00
Chris Michael
9103b7e2e3
Check the return of ecore_x_init and error out if that fails.
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:21:33 +01:00
Eduardo Lima (Etrunko)
2d84a8a8fb
WIP
...
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>
2013-06-26 10:58:36 -03:00
Chris Michael
abf8a3b7bf
Format for EFL style
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-06-25 14:14:04 +01:00
Chris Michael
0615dfe4ee
Add missing safety checks for valid proxy objects before trying to
...
call functions on the object
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-06-25 14:14:04 +01:00
Chris Michael
aa54fcf059
Check that ecore_wl_init succeeds before trying to make calls into it.
...
Fix formatting.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-06-25 09:31:52 +01:00
Jan Arne Petersen
f656aa397f
ecore_imf: Add support for wayland
...
Add an input method module supporting the Wayland input method protocol.
In v2:
- Missing call to ecore_wl_shutdown() in im_module_shutdown()
- Access the already stored 'wayland globals' with ecore_wl_globals_get()
- Fixed compilation by adding -I(top_srcdir)/src/efl to CFLAGS
- EFL formatting fixes
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>
2013-06-24 16:14:14 -03:00
Jihoon Kim
373fb30096
ecore_imf/scim: remove unused function declaration
2013-04-13 15:25:00 +09:00
Henrique Dante de Almeida
ca8fc827a3
efl: Fixes to support compiling with CFLAGS=-Werror
...
This allows compiling with gcc 4.7.2 without errors (using the
default configuration).
2013-02-26 10:55:04 -03:00
Stefan Schmidt
b9d18d770b
efl: Switch from deprecated eina_unicode_utf8_get_next to eina_unicode_utf8_next_get
...
SVN revision: 83130
2013-01-23 09:09:57 +00:00
Jihoon Kim
ae19344fc8
efl/ecore_imf/ibus: fix indentation
...
SVN revision: 82707
2013-01-12 16:09:56 +00:00
Jihoon Kim
505a88f3f2
efl/ecore_imf/ibus: fix wrong function definition
...
SVN revision: 82706
2013-01-12 16:07:40 +00:00
Jihoon Kim
8412b59c4b
efl/ecore_imf/scim: remove unused code
...
SVN revision: 82705
2013-01-12 15:51:57 +00:00
Jihoon Kim
95fc2dcc4e
efl/ecore_imf/scim: use EINA_SAFETY macro for checking NULL
...
SVN revision: 82703
2013-01-12 15:44:59 +00:00
Jihoon Kim
5fbfaf9e10
efl/ecore_imf/scim: remove unused variable
...
SVN revision: 82642
2013-01-11 16:05:55 +00:00
Jihoon Kim
d964b7efc0
efl/ecore_imf/scim: remove unused code
...
SVN revision: 82641
2013-01-11 16:01:16 +00:00