Commit Graph

61756 Commits

Author SHA1 Message Date
Xavi Artigas 205193f1ab docs: Add @since 1.22 to all stable classes' EO docs
Summary: Previous @since tags have already been removed from eo files.

Test Plan: Everything builds, but stable classes now have Since tags in the docs.

Reviewers: zmike, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8446
2019-03-22 16:57:36 +01:00
Vincent Torri 10c2342d93 evil: fix wrong values in timeval
Summary: time values are of type long, but a double values was used

Test Plan: compilation

Reviewers: raster, zmike, q66, simotek

Reviewed By: zmike, simotek

Subscribers: simotek, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8444
2019-03-22 09:09:14 -04:00
Jaehyun Cho 44d0cb9260 elm_atspi_bridge: remove all legacy usage from eo files
this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree

ref T7724
2019-03-22 16:04:32 +09:00
Jaehyun Cho 0225db71c0 elm_atspi_app_object: remove all legacy usage from eo files
this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree

ref T7724
2019-03-22 16:04:29 +09:00
Taehyub Kim bb81ccdac1 efl_ui_layout: Eina_Error type has been modified to work correctly.
Summary:
fix Eina_Error type calculation in _efl_ui_layout_base_efl_ui_widget_theme_apply() to behave as before.

@fix

Test Plan: run elementary_test for all widgets

Reviewers: #reviewers, Jaehyun_Cho, Hermet

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8443
2019-03-22 12:38:44 +09:00
Lauro Moura 0881d1524b efl-csharp: Add back I prefix for interfaces.
Summary:
Conforming to C# coding conventions.

For properties, now we only generate a wrapper if its name does not
clash with the name of the class that would be implementing it.

Fixes T7751

Reviewers: vitor.sousa, felipealmeida, segfaultxavi

Reviewed By: vitor.sousa, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7751

Differential Revision: https://phab.enlightenment.org/D8397
2019-03-21 14:48:33 -03:00
Lauro Moura f36d8b9bb1 csharp: Export correct headers and files
Summary:
Some headers and test files were not being exported in autotools.

Also reordered the headers for better tracking.

Test Plan: run make dist and check if resulting tarball builds with --enable-csharp-bindings

Reviewers: stefan_schmidt, zmike, bu5hm4n, segfaultxavi, cedric, devilhorns

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8324
2019-03-21 17:32:33 +01:00
Xavi Artigas cbbc5e5eb6 mono-tests: Fix after latest changes to eolian
Summary: Event payload checking is more strict now.

Test Plan: Check that master can be built

Reviewers: lauromoura, q66

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8437
2019-03-21 17:20:13 +01:00
Daniel Kolesa 5c1ea543bb eolian: assume requires section is legitimate dependencies
Previously these were not considered, which resulted in false
positive warnings.
2019-03-21 16:46:55 +01:00
Daniel Kolesa cef2e337b8 eolian: disallow @owned on events
This is never used anywhere and it does not make sense with the
new type rules for events.
2019-03-21 16:17:06 +01:00
Daniel Kolesa 3f083b3ccb eolian: add event type call convention checks for non-beta classes 2019-03-21 16:00:18 +01:00
Vincent Torri 1066e5be60 Windows, meson build : use posix *printf family function
Summary: the Windows libc has different format flags for the *printf functions, fix this by using the posix version provided with mingw

Test Plan: compilation

Reviewers: zmike, raster, q66

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8432
2019-03-21 11:26:15 +01:00
SangHyeon Jade Lee b747af5181 elm : fix wrong layout class comparing in orientation mode disable
automatic theme lotation is layout base class property which can be applied
layout based widget classes.
currently it only comparing EFL_UI_LAYOUT_CLASS so layout base inherited class
can not be applied this feature properly.

depends D8434

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8436
2019-03-21 10:33:58 +01:00
SangHyeon Jade Lee 7bb702b0df elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set.
current code set the disable EINA_TRUE when disabled,
but once it was set diabled, it never changed EINA_FALSE even we set the orientation_mode_disable as FALSE.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8434
2019-03-21 10:33:57 +01:00
Marcel Hollerbach ab30ff3f9b eolian: enable event redef checking by default
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D8425
2019-03-21 10:33:56 +01:00
Mike Blumenkrantz 13327b4fee ci: disable exit-on-error during configure and also grab stderr
this should resolve some issues where ci was not correctly detecting
changes in env and clearing the config cache during autotools build

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8416
2019-03-21 10:14:51 +01:00
Prasoon Singh e0511c995f elm_gesture_layer: Use flag returned by gesture callbacks
Summary:
Instead of flag returned by gesture callbacks, always EVAS_EVENT_FLAG_NONE
flag was being used.

Test Plan:
As event flag was not being appropriately updated, in some cases expected
behaviour was not seen.

Reviewers: shilpasingh, cedric, Hermet, segfaultxavi

Reviewed By: shilpasingh, segfaultxavi

Subscribers: segfaultxavi, #reviewers, rajeev.jnnce, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8421
2019-03-21 10:08:07 +01:00
Mike Blumenkrantz 5930c5f86e efl_ui_win: avoid triggering legacy forbidden path during window finalize
this (unintentionally) revealed some bugs where apps/examples were mixing
eo and legacy code for elm_win which breaks things pretty badly. I'm only
here so I don't get fined.

ref T7713

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8401
2019-03-20 12:36:59 -07:00
Mike Blumenkrantz fcf2eb2205 efl_ui_win: mark legacy forbidden during bg part load always
calling this function indicates legacy is forbidden, not successfully
loading a file. this is functionally meaningless, as the only way to
trigger the previous codepath would be to have previously set legacy
as forbidden, but perhaps it will be slightly easier to read now

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8400
2019-03-20 12:36:57 -07:00
Mike Blumenkrantz 61e880e57c elm_test: set accel for all glview tests
these otherwise require the user to set ELM_ACCEL or manually change
the config which is cumbersome

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8392
2019-03-20 12:36:55 -07:00
Mike Blumenkrantz 4792bb8239 elm_test: move gl api creation to glview init function
this needs to happen when the gl context is current to avoid a billion
errors and overall general failure

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8390
2019-03-20 12:36:52 -07:00
Mike Blumenkrantz b8ff87fc1d efl_ui_win: fix hw accel detection
the ordering of priority here is supposed to be:

1. env vars
2. global override config
3. window config
4. global config

in the case where 1 and 3 were not set, however, this would end up
mangling the global config values and not using the gl options

@fix

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8389
2019-03-20 12:36:50 -07:00
Mike Blumenkrantz bc03654caf elm_test: use legacy api for glview gears test
mixing interfaces api with legacy api is bad for elm_win

ref T7713

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8388
2019-03-20 12:36:48 -07:00
Xavi Artigas bbd4b6e514 docs: Remove obsolete @since tags from EO files
Summary:
All legacy @since tags have already moved to the *.legacy.h files.
EO files are now devoid of @since tags (except some eldbus still
needed for legacy).
Upcoming patches will add @since 1.22 to those APIs which come out
of beta in this release.
APIs marked @beta do not need @since tags.

Test Plan: Everything builds, EO docs (like DocFX) have no Since tags.

Reviewers: zmike, bu5hm4n, lauromoura, cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8430
2019-03-20 20:16:05 +01:00
Marcel Hollerbach c081825bc8 efl_ui_tab_bar: the type of this event is annotated as object
however, efl_ui_tab_bar does pass in there a int. For now i decided that
we just pass NULL here, if this is not accaptable then we can still add
another event to the object itself.

fix T7758

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8418
2019-03-20 18:50:48 +01:00
Lauro Moura 43a1d79ba8 csharp: Remove test about conflicting events.
Conflictings events won't be allowed anymore on eolian-based classes.

For manually subclassed C# classes that eventually have conflicts, this
should be dealt with in T7744.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8426
2019-03-20 18:44:02 +01:00
Christopher Michael 2d7678074e efl_canvas_vg_object: Fix dereference after null check
Coverity reports that both pname & file variables can be null here,
and that we are potentially passing NULL to strcmp. Check for valid
variables before passing to strcmp

Fixes Coverity CID1399423, CID1399421

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8350
2019-03-20 18:07:07 +01:00
Marcel Hollerbach decfca4f23 efl_ui_selection: give this event a better name
this event does not get emitted when selection per se changes, it gets
emitted when the selection in the window manager changes. we should
prefix this even with that.

ref T7476

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8424
2019-03-20 16:59:39 +01:00
Marcel Hollerbach 7069b0efc0 efl_ui_list_view: remove not used event
this event is not used here, and if it ever is used, then it should
probebly be using efl.ui.selectable.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8423
2019-03-20 16:59:38 +01:00
Marcel Hollerbach c489c1ee87 build: codegen generation should depend on elementary_codegen
Summary:
otherwise buildfailures like :

/usr/bin/env EFL_RUN_IN_TREE=1 /Users/travis/build/Enlightenment/efl/build/src/bin/elementary/elementary_codegen -p=codegen_example src/examples/elementary/codegen_example.edj elm/example/mylayout/default src/examples/elementary/codegen_example_generated.c src/examples/elementary/codegen_example_generated.h

Can appear.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8428
2019-03-20 11:24:44 -04:00
Yeongjong Lee 77f2782d29 ui.box_stack: refactor layout_update
Summary:
This patch remove evas_box function from Efl.Ui.Box_Stack and add unit test.

Depends on D8214

Test Plan:
1. make check
2. elementary_test -to 'efl.ui.box_stack'

Reviewers: zmike, Jaehyun_Cho, cedric

Reviewed By: zmike, Jaehyun_Cho, cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8094
2019-03-20 10:37:42 -04:00
Shilpa Singh e80169a844 efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs
Add attribute_del API, currently there is no provision to delete a particular attribute(key-value pair)
from the attribute list of a widget.
Add test cases for efl_access_attribute_append, efl_access_attributes_get, efl_access_attribute_del and efl_access_attributes_clear API

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Shinwoo Kim <cinoo.kim@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8386
2019-03-20 15:29:04 +01:00
Marcel Hollerbach 89d80ffc52 efl_con: fixup copy'n paste error
please see https://phab.enlightenment.org/D8411#151797, it appears here
was a copy and paste error. This fixes the ecore_con test suite

Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8419
2019-03-20 14:51:27 +01:00
Lauro Moura efb05a3ac8 efl: Add missing docs to parameters.
Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8422
2019-03-20 14:13:22 +01:00
Yeongjong Lee 37c703437a efl.pack_table: inherit efl.pack instead of efl.pack_linear
Summary:
>>! In T5301#110572, @jpeg wrote:
> Quick recap before I leave.
> ...
> ...
>  - Pack interfaces - T5328
>
> Table does not need to inherit from "linear" (1d) layout: this brings unnecessary complexity, for a dubious use case.

We don't have linear layout policy of table(2d) layout. furthermore, i don't
think it will be clearly defined. it is enough for Efl.Pack_Table to support
`efl_pack` which work the same as `efl_pack_end`.

ref T5719, T5328

Test Plan:
- make
- elementary_test -to 'efl.ui.table'
- elementary_test -to 'efl.ui.table(linear api)'

Reviewers: zmike, woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, jpeg, #committers

Tags: #efl

Maniphest Tasks: T5719, T5328

Differential Revision: https://phab.enlightenment.org/D8420
2019-03-20 12:54:25 +01:00
Lauro Moura 0860c4f1d7 csharp: Remove missing doc warning by filling them.
Summary:
Added basic documentation for things that were missing.

Some other files are silent due to a pragma disabling CS1591. They
should be handled later.

Also, removed `Efl.Io.Positioner` from the blacklist as it is referenced
from the `Efl.Io.Reader.eos` event documentation.

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: felipealmeida, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8370
2019-03-20 11:35:58 +01:00
Xavi Artigas 171467b1fa Remove dead code 2019-03-20 11:24:05 +01:00
Xavi Artigas 016e4df78b mono-docs: Use @since tags properly
Summary:
Only the number was being used, and in places were it should not be.
Now the Since version appears only in <summary> tags, with proper
context (Since EFL 1.22).

Test Plan: make && gendoc should produce DocFX pages which make more sense.

Reviewers: lauromoura, zmike, bu5hm4n

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8012
2019-03-20 11:23:41 +01:00
Jaehyun Cho a253f502c7 eolian_mono: apply indentation of if scope 2019-03-20 11:38:25 +09:00
Mike Blumenkrantz 049c65e7ac efl_io_*: apply new event calling convention
Summary:
ref T7758
Depends on D8409

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8410
2019-03-19 16:32:02 -04:00
Marcel Hollerbach 6dec272d31 efl_ui_focus_object: apply new event calling convention
Summary:
ref T7758
Depends on D8408

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8409
2019-03-19 16:31:55 -04:00
Marcel Hollerbach 60384a4d40 evas: apply new event calling convention
Summary:
ref T7758

Depends on D8407

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8408
2019-03-19 16:31:50 -04:00
Marcel Hollerbach 158336d19e efl_ui_tags: apply new event calling convention
Summary:
it appears that this event calling is a bit fishy, the value of the
second callback call was never set, i think the shrink flag here is what
we want to return here.

T7758
Depends on D8406

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8407
2019-03-19 16:31:45 -04:00
Marcel Hollerbach f5fb68e1cd efl_ui_win: apply new event calling convention
Summary:
ref T7758
Depends on D8405

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8406
2019-03-19 16:31:39 -04:00
Marcel Hollerbach e4e14f50db efl_ui_focus_manager_sub: apply new event calling convention
Summary: ref T7758

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7758

Differential Revision: https://phab.enlightenment.org/D8405
2019-03-19 16:31:34 -04:00
Marcel Hollerbach 11003bcae3 efl_ui: rename select and unselected of efl_ui_selectable
Summary:
this was conflicting with a model event. Prefixing it with "item,"
resolves this, and describes better what it does.
Depends on D8413

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8414
2019-03-19 16:30:19 -04:00
Marcel Hollerbach 9a3d4310be elm: do not use eo events here
Summary:
we want to rename it, and this would break legacy behaviour, so better
this way.
Depends on D8412

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8413
2019-03-19 16:29:45 -04:00
Marcel Hollerbach c9cdb916cd Revert "efl_ui_selectable: namespace events to avoid conflicts"
Summary:
This reverts commit f629f11bed.

This breaks legacy events. As the selected event is used in legacy
widgets. Also this commits mixed up two different concepts, selection in
a entry etc. and selection of a item.
Depends on D8411

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8412
2019-03-19 16:29:39 -04:00
Marcel Hollerbach 06863ac18e efl_net: resolve cases where we passed something as event_info
Summary: but the event was annotated to *not* contain any event_info.

Reviewers: cedric, segfaultxavi, zmike

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8411
2019-03-19 16:29:34 -04:00
Marcel Hollerbach bb0290edbe efl_ui_widget: resolve warning about multiple defines
Summary:
the difference here is, that the macro before did not print ERR's the
one now does. Hence this commit remove two error messages.

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8415
2019-03-19 16:28:10 -04:00