Subject: [E-devel] [patch][elementary] multibuttonentry - access feature
i have attached a patch which has access feature for the multibuttonentry.
it was hard time to implement access feature on the multibuttonentry than
others.
SVN revision: 77738
Subject: [E-devel] [Patch] multibuttonentry - data corruption issue of
the box list
here is a problem in the data corruption of the box list in
_box_layout_cb() of the multibuttonentry.
EINA_LIST_FOREACH is used to move and resize the objects.
but if box unpack/pack is called in the EINA_LIST_FOREACH loop,
the data of the box list will be corrupted.
This problem can not be solved immediately due to the structural
problems of
the MBE.
So the attached patch, a workaround, avoids calling unpack/pack in the
EINA_LIST_FOREACH loop.
I am in the process of refactoring MBE but in the mean time,
this patch will resolve the above issue.
SVN revision: 77192
Subject: [E-devel] [Patch] elc_multibuttonentry resize patch.
Currently, there is a problem in the logic of getting the size in the
MBE's
box.
For each line, the height of the line is calculated according to the
biggest
item's height
and is applied to the box size, but problem occurs when the newly added
item's height is larger than the one before.
For example, when the entry is located in the front of the last line,
the line's height is determined by the entry.
When the button is added by the user's input at this state,
because button's height is larger than the entry's height
I have modified each line to have the equal height.
SVN revision: 75453
Dear, all
I've attached a patch that fixed the memory leak.
There is not a free() in _del_hook().
Please review this patch.
Sincerely yours,
Jihyeon Seol
Signed-Off-By: JiHyeon Seol<jiheyon.seol@samsung.com>
SVN revision: 75439
Subject: [E-devel] [E-deve] [Patch] Add new apis for editable set/get
in multibuttonentry
Typically multibuttonentry is used as a composer.
But sometimes, Multibuttonentry can be used as a viewer.
Currently there is no way to use multibuttonentry as non-editable
viewer.
So I added new APIs which are elm_multibuttonentry_editable_set/get().
If editable is true, entry in multibuttonentry is activated and user can
compose item by pressing the return key.
If not, entry is hidden and muttibuttonentry works as a non-editable
viewer.
SVN revision: 73223
Subject: [E-devel] [?Patch]elm_?multibutto?nentry bug fix
I've attached patch to fix bug in multibuttonentry.
When this widget is unfocused, there's no code for making unfocused
entry in multibuttonentry.
Because of that, when multibuttonentry got focus again, entry couldn't
get focus normally.
so I've added code to fix this issue. when it's unfocused.
Also I removed unused value in resize_button() which is 'padding_inner'
SVN revision: 69583
Subject: [E-devel] [Patch]New feature in Multibuttonentry widget
(input panel handles manually)
I've added patch for a new feature in Multibuttonentry widget.
When Multibuttonenetry gets/lost a focus, it shows input panel(virtual
keyboard) using elm_entry_input_panel_show/hide() function.
A multibuttonenetry manually handles input panel.
The reason why it handles manually input panel even though it has entry,
the multibuttonentry must show input panel when entry lost focus and
multibuttonentry widget is focused.
Such as item(button) is clicked.
So I've added this feature.
Please review this patch.
SVN revision: 68688
1. fixed formatting.
2. renamed smart callback "shrank" -> "contracted"
I just renamed this smart callback without backport because multibuttonentry committed recently and backport will be removed in a couple of days (elm 1.0 api freeze)
Signed-off-by: Daniel Juyung Seo <seojuyung@gmail.com>
SVN revision: 68639
Now it returns the bool value to free the widget item.
Some widget items(i,e genlist) should not be deleted directly when elm_object_item_del is called.
So, if the pre_hook function returns EINA_FALSE, then the widget item will not be deleted.
SVN revision: 67565
Subject: [E-devel] [patch] elc_multibuttonentry - checking focus
before elm_widget_show_region_set
In elc_multibuttonentry, there're some elm_widget_show_region_set callings.
However it's not checking whether it got focused or not,
sometimes it's bugging users when the user's trying to move scroller.
So I changed to check focused.
SVN revision: 67285
Subject: [E-devel] [patch] elc_multibuttonentry - clean unused vars
I just clean unused vars of elc_multibuttonentry.
It made that gcc complains :P
SVN revision: 66504
Subject: [E-devel] [patch] elc_multibuttonentry - delayed reset string
I was sent email about elc_multibuttonentry's bug. It reviewed by seoz.
And he found some path can make segfault.
So I changed reset string position in the widget.
I patched resetting internal entry's position, before that some label
are broken by too early resetting.
SVN revision: 66461
Subject: [E-devel] [Patch][elm_map] Mouse wheel bug fix
There is mouse wheel bug. Actually I have made it in previous patch :p
When using mouse wheel, tile size was changed between 0.5 ~ 2.0 before
zoom level is changed. But actually it should be changed between
1.0 ~ 2.0. I have fixed it. If tile size is below 1.0, it does zoom-out.
And if tile size is above 2.0, it does zoom-in.
SVN revision: 66458
CC libelementary_la-elc_multibuttonentry.lo
elc_multibuttonentry.c: In function ‘_set_vis_guidetext’:
elc_multibuttonentry.c:309:20: warning: unused variable ‘en_width’
elc_multibuttonentry.c: In function ‘_resize_button’:
elc_multibuttonentry.c:741:16: warning: unused variable ‘button_text’
elc_multibuttonentry.c: In function ‘_add_button_item’:
elc_multibuttonentry.c:772:40: warning: unused variable ‘h_btn’
elc_multibuttonentry.c: In function ‘_entry_resized_cb’:
elc_multibuttonentry.c:1064:86: warning: unused parameter ‘event_info’
elc_multibuttonentry.c: In function ‘elm_multibuttonentry_item_select’:
elc_multibuttonentry.c:1531:12: warning: suggest explicit braces to avoid ambiguous ‘else’
elc_multibuttonentry.c: In function ‘_resize_button’:
elc_multibuttonentry.c:747:37: warning: ‘padding_inner’ is used uninitialized in this function
^Cmake: *** [libelementary_la-elc_multibuttonentry.lo] Error 1
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65550
---------------------------------------------------
Dear Developers,
I added a new widget called “Multibuttonentry" which could be used as contact button in App
This widget allows a user to insert a text button.
text button is inserted by pressing the "Enter key"
If there is no space in the current row, the new button is entered in the next row. If the button is clicked, it will become focused.
And focused button can be removed by pressing the "backspace" key.
when items are added over 1 lines, if Multibuttonentry lost focus, it becase shrink mode (made it as 1 line)
Please review it's APIs and functionalities.
Thank you,
Goun
---------------------------------------------------
Widget was originally written by Hyunsil Park <hyunsil.park@samsung.com>.
It has been contributed to by the following people:
* Jihoon Kim <jihoon48.kim@samsung.com>
* WooHyun Jung <wh0705.jung@samsung.com>
* deasung.kim <deasung.kim@samsung.com>
* Myungjae Lee <mjae.lee@samsung.com>
* Goun Lee <gouni.lee@samsung.com>
* Mike McCormack <mj.mccormack@samsung.com>
* Daniel Juyung Seo <juyung.seo@samsung.com>
* Seunggyun Kim <sgyun.kim@samsung.com>
* sanghoon80.cho <sanghoon80.cho@samsung.com>
Signed-off-by: 이고은 <gouni.lee@samsung.com>
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65548