Summary:
Set the display mode to none only when both clipboard and keypad is
hidden.
Signed-Off By: Shashank Pandey <shashank.p@samsung.com>
Signed-Off By: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Keypad opened, Clipboard opened, close clipboard
Reviewers: woohyun, CHAN, Hermet
Reviewed By: Hermet
Subscribers: CHAN, Jaehyun, shashank0990
Differential Revision: https://phab.enlightenment.org/D2968
this fix is a fix due to the fix in
933dfca5bcda4943ecdd81ab09dc34989234f7f3 whihc fixed other issues. now
focus is properly set where it should be. this affected rage
@fix
Summary:
The x, y coordinates in pos callback should be relative to
the top-left of the object.
This patch corrects the x,y coordinates and adds poscb to elementary test
to clearly show the bug case.
Test:
Run Genlist Dnd Dflt Anim with the change in this patch.
Drag an item to other genlist and see the printed out item, x, y.
@fix
Reviewers: JackDanielZ
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3063
Summary:
There was override for elm_object_item_part_text_get() only.
This patch implements elm_object_item_part_text_set().
Reviewers: Hermet, cedric
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3054
multibuttonentry is editable
Summary:
Input panel should be controlled only if Multibuttonentry is editable, else causes issues in applications controlling keypad by themselves
@fix
Reviewers: CHAN, Hermet
Reviewed By: Hermet
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3050
Summary: slider is not focused after slider is dragged.
Test Plan: elementary_test -> slider
Reviewers: woohyun, seoz, smohanty, cedric, raster
Differential Revision: https://phab.enlightenment.org/D3057
Add elm_object_focus_next_item_set/get,
elm_object_item_focus_next_object_set/get and
elm_object_item_focus_next_item_set/get.
If the item and object is set at the same time,
the item is preference to object when the focus moves.
This feature is implemented about gengrid.
It will be implemented about ohter widgets.
@feature
Summary:
If file path is wrong, don't need to call the image preload api.
And the result of evas_object_image_load_error_get api is not correct
after calling the image_preload api.
I will check more about it.
Reviewers: cedric, Hermet, jpeg
Reviewed By: jpeg
Differential Revision: https://phab.enlightenment.org/D3039
Summary:
MBE item append logic changed when mirrored set as true.
The item appended from left side of internal box to right side, even mirrored set as true.
@fix
Test Plan:
Precondition : elm_widget_mirrored_set as true.
Run mbe sample in elementary_test.
Add item.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2975
this fixes a bug with horizontal style toolbar items and toolbar code
itself simply emitting the wrong signals that causes 0 height items.
this fixes T2710
@fix
smooth out scrolling and simplifyconfig as well as expose config apis
to configure it all and elm config ui sliders and checkboxes for
related config values etc. etc. - with this it is much smoother if you
use the default values, though latency is a bit worse. it looks nicer
though.
@feature
there is an annoyance in elm that when focus goes back toa window it
restores focus to the last focused widget. if that widget happens to
be invisible in a scroller then this is really annoying as the
scrollers reset. this makes restoring optional. only if there is a
hilight object AND it's visible - then restore, otherwise don't and
revert focus to the window itself again.
@fix
i found that the focus doesnt auto-show when focusing things inside
scrollers and so on. i had to add more points to trigger auto show.
this fixes that
@fix
Summary:
When the calendar view updated(Press next button to activated next month),
a lot of signals process(signal emitted) to calendar edc.
The signals which related with view update, should process in same loop.
If not, the view looks weird.
To ensure signals process same time, i called "edje_object_message_signal_process" after layout sizing eval called.
@fix
Reviewers: Hermet, cedric, woohyun
Subscribers: id213sin
Differential Revision: https://phab.enlightenment.org/D3019
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There are two issues about preload
1. elm_image_preload_disabled_set api does not work.
Always returned before call the evas_object_image_preload()
2. image preload does not work at file_set time.
If image's show property is not TRUE, do not call evas_object_image_preload() at file_set time.
But there is no action when image's show property will be TRUE after call the file_set api.
@fix
Reviewers: Hermet, jpeg
Differential Revision: https://phab.enlightenment.org/D2989
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Fix behaviour for changed, activated, press events.
Forwarders must be set on entry's original events,
so they will call corresponding fileselector entry's callbacks.
@fix
if sd->obj is null then the a zoom timeout has a null data param and
that means we cant get sd data... so dont set up a zoom timeout unless
sd->obj is valid.
@fix
so elm map loads every module it can find in a recursive dir walk of
all elm modules. this si nuts. this can accidentallly load OLD modules
and thats a recipe for disaster. so check module arch dir aagainst
module arch string to load the right version and be quiet if module
doesn thave the right symbols - it's the wrong module type.
@fix
Summary:
When loop is set, the arrows on horizontal/vertical bar
should not be disabled. These arrows show the scrollable direction,
if enabled. Disabled arrows show no more scroll in that direction.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Merge branch 'master' of http://git.enlightenment.org/core/elementary
Test Plan: elementary_test -> scroller -> loop in x axis.
Reviewers: raster, Hermet, singh.amitesh
Subscribers: sachin.dev, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2953
Summary:
fix sub-item position after prepending if parent item has no other
sub-items
Test Plan:
1. add genlist
2. add parent item
3. compare results of following actions:
case 1: append sub-item "child1" and then prepend sub-item "child2"
case 2: prepend sub-item "child2" and then append sub-item "child1"
ExR results are the same
CuR in case 2 sub-items are placed in wrong position
Reviewers: cedric, raster, reutskiy.v.v, SanghyeonLee, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2965
Summary:
Updated genlist to select first item which is not in
DISPLAY_ONLY mode
@fix
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
Following is the test to verify:
1. Create a genlist
2. Make 1st item as ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY
3. Now bring the focus to genlist by key down
4. It should bring focus on 2nd item and not 1st.
Reviewers: raster, Hermet, SanghyeonLee, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2957
Summary:
When text is set on a multibuttonentry item, item does not resize
again based on text.
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan: Set long text to multibuttonentry item, after item is created and shown.
Reviewers: woohyun, CHAN, Hermet
Reviewed By: CHAN, Hermet
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D2967
Summary:
When push is in progress, block popping until
push is complete to allow animation to complete.
@fix
Reviewers: Hermet
Subscribers: subodh6129, shashank0990
Differential Revision: https://phab.enlightenment.org/D2966
Summary:
This reverts commit bba4c217f2ce4f032fca6298cc8b2fc6ff3d7c19.
"x and y position variable assumes values ranging from min to max " is right.
but in looping behavior, x and y are able to have value bigger than max or smaller than min.
@fix
Test Plan:
1. elementary_test -> scroller
2. on Loop in X axis
3. scrolling page to left.
4. page is moved last page directly.
Reviewers: SanghyeonLee, tanwar.umesh07, raster, cedric, jaehwan, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2977
Summary:
Size or offset spacer make hover be able to move its swallows to right positions.
In elm_layout_sizing_eval() for hover, moving and resizing spacers are done
after moving and resizing hover.
It causes in hover's move or resize callback, geometry can not be got correctly.
Reviewers: SanghyeonLee, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2999
Summary:
Item layout will be added in elm focus tree.
evas_object_focus_set is no meaning here for MBE operation.
So i changed focus API from "evas_object_focus_set()" to "elm_object_focus_set()"
elm_object_focus_allow_set() already called in item adding function.
@fix
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2993
Summary:
The focus movement is wrong when down key press
is done of first item of last row, intsead of
taking the focus out, it moves the focus to next
item (right).
@fix
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
1. Launch elementary_test -> Gengrid 2 sample
2. Add a few items such that there are 2 items in last row
3. Do a down key press on 1st item of last row
4. Observe focus movement
Reviewers: raster, Hermet, SanghyeonLee, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D3001
Item expandend state need to be resetted (contracted) when the
item goes in the items cache, otherwise when the item will be reused
it will have unwanted state (expanded).
Quite visible in the "Genlist Tree and Decorate All Mode" test
@fix
resize object was not getting focused in case of mouse click.
Steps to reproduce:
1. elementary_test -to "toolbar focus".
2. set focus to toolbar item via mouse.
3. focus does not come to toolbar.
fixes T2697
@fix
There is no need to loop when reorder mode is enabled. This looks
ugly and nobody wants it. This fault was introduced in 7aaa5c8d0a4a5714b4f1bf79e
This patch also fixes following crash
1. elementary_test -to "Gengrid 2".
2. Enable all the options available.
3. Do reorder of item via keys.
4. Observe segv on reordering edge items.
@fix
Steps to reproduce:
1. elementary -> gengrid focus
2. change mode to horizontal
3. set focus to one of item in 2nd column.
4. Press Left direction key
issue: focus moves out of gengrid.
@fix
Summary:
since the variable 'preferred_rot' is checked its validation in _elm_win_xwin_update(),
so, should be initialize it before invoking.
@fix
Reviewers: jypark, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2987
Summary:
Added the following examples:
* bg_cxx_example_01
* bg_cxx_example_02
* bubble_cxx_example_01
* button_cxx_example_00
* button_cxx_example_01
* calendar_cxx_example_01
* calendar_cxx_example_02
* calendar_cxx_example_03
* calendar_cxx_example_04
* calendar_cxx_example_05
* clock_cxx_example
* datetime_cxx_example
* glview_cxx_example_01
* hoversel_cxx_example_01
* icon_cxx_example_01
* location_cxx_example_01
* menu_cxx_example_01
* popup_cxx_example_01
* radio_cxx_example_01
* separator_cxx_example_01
* slider_cxx_example
* spinner_cxx_example
* table_cxx_example_01
* table_cxx_example_02
* thumb_cxx_example_01
Added documentation for the above examples, as well as how using lambdas
with C++ elm binding. How to use autohide feature and how to use the C++
wrappers to create windows, widgets and call Eo functions from them with
automatic C++ type conversion and how to use signals from C++.
':' is usually regarded as the delimetr for new theme path
but it uses to look up the drive, ie, c: on windows, on the other hand.
this patch fixes to determine wheter ':' is used for drive name or delimeter.
@fix
Summary:
if app sets available rotations before invoking elm_win_alpha_set(),
wm rotation doesn't work.
this patch fixes it.
Test Plan: N/A
Reviewers: jypark
Reviewed By: jypark
Differential Revision: https://phab.enlightenment.org/D2946
Summary:
The original code did not consider the case where the text will be
reapplied by chunks. The repositioning of the cursor should be postponed
to when the idler work is done, or not required at all.
Fixes T2646.
@fix
Reviewers: NikaWhite
Reviewed By: NikaWhite
Maniphest Tasks: T2646
Differential Revision: https://phab.enlightenment.org/D2952
This is an example of classic code copy and paste mistake.
Probably inspired from similar code in genlist/gengrid.
We were actually deleting the other items (except selected one) in
viewport in _elm_list_nearest_visible_item_get() which results into crash
while deleting the list object.
@fix
Resolves: T2662
Summary:
After item looping, Gengrid item was getting selected.
So, checked for item_select_on_focus_disable flag and
accordingly set focus state or selected state of Gengrid item.
@fix
Signed-off-by: Yeshwanth Reddivari <r.yeshwanth@samsung.com>
Reviewers: raster, Hermet, singh.amitesh, SanghyeonLee
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2937
performing strlen() on potential non-string data is not recommended and can
even lead to crashes. nul terminating non-string data is pointless and enables
bad application behavior such as calling strlen() on potentially non-string data
@fix
previously the drop format was chosen in a manner unrelated to what
the offered format was, leading to applications receiving either the correct
data with the wrong format, the wrong data with the wrong format, or
the wrong data with the correct format. by comparing the drop handler
types with the offered type and ensuring that there is a match, the
correctness of the format that the application receives is more reliable
@fix
In the widget code, focus origin is added. It can know
the focus movement is originated by which action.
The widgets can choose the item focus moves to last focused item
or geometrically nearby item by focus origin.
In gengrid, focus moves to last focused item if focus origin is
ELM_FOCUS_REVERT. It moves to nearby item if focus origin is from
ELM_FOCUS_UP to ELM_FOCUS_LEFT.
TODO: widgets have items should add the direction feature if it
want the focus to move to nearby item.
@feature
When the focus is move to the object in scroller, it is scrolled
to show the focus region as a widget.
If the focus region want to be shown as an item,
set the mode ELM_FOCUS_REGION_SHOW_ITEM.
If then, it will be scrolled as an item.
TODO: Widgets have items are added on_focus_region function.
@feature
This commit is related to 4d553d2bcf2157053433994ca3facb56bd670da9.
It doesn't work if item_select_on_focus_disable is 1.
So _item_focus_down is changed like _item_single_select_down.
@fix
Summary:
do not return yet in case of edge items if looping
is disabled. try to select/focus last item.
Signed-off-by: Jyotiprakash Sahoo <jp.sahoo@samsung.com>
@fix
Test Plan: elementary_test -> Gengrid 2
Reviewers: raster, singh.amitesh, cedric, SanghyeonLee
Reviewed By: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2865
Summary:
When user set min max as 50, 150 with %d format, then value set as 100.
The spinner value set as '0'
Because the sd->val type is double.
Spinner entry has same problem.
@fix
Test Plan:
Set spinner format as %d.
Check the spinner value.
It's not supported.
Reviewers: Jaehyun_Cho, cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2898
Conflicts:
src/lib/elm_spinner.c
Summary:
When icon is set, icon size is calculated without considering
edje base scale. This can lead to a miscalculation when
base scale is set other than 1.0.
@fix
Reviewers: seoz, woohyun, cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2798
Summary:
_elm_access_say() does not free the given text.
But, the text from eina_strbuf_string_steal() is not cared
from outside of _elm_access_say(), too.
It should be changed to eina_strbuf_string_get().
Test Plan: N/A
Reviewers: cedric, woohyun, kimcinoo, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2918
Summary:
Calling the elm_config_accel_preference_get api with "none" as parameter,
it means user does not want to use acceleration.
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2920
If we want to run from the local build dir without make install before
elm_module would fail to load the modules as it is expecting them in the
final install location.
We can now change this by setting ELM_RUN_IN_TREE to force it load the not
yet installed modules.
ref T2028
Summary:
elm_list, elm_genlist widgets are handle focus highlight
relying on only elm_widget_focus_highlight_enabled_get() API.
The API is not considered about auto focus highlight feature.
So, we need to check a flag for auto focus from _elm_config.
It resolves T2555.
@fix
Test Plan: elementary_test -> List Focus or Genlist Focus
Reviewers: raster, cedric, SanghyeonLee, singh.amitesh
Reviewed By: SanghyeonLee, singh.amitesh
Maniphest Tasks: T2555
Differential Revision: https://phab.enlightenment.org/D2914
Summary:
When editable set is set to FALSE, there is no need to specifically
hide the keypad as keypad will automatically hide when entry is hidden.
@fix
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
Reviewers: woohyun, Hermet, CHAN, cedric
Reviewed By: cedric
Subscribers: subodh6129, navnbeet
Differential Revision: https://phab.enlightenment.org/D2907
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently, the first item is marked selected when
the colorselector is added. However, this is not normal behavior
since the first item is not shown selected.
Moreover, always selecting the first item during creation does not
sound natural.
Reviewers: cedric, Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2906
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The numerical formula below is calculated with the double type.
-> ELM_SCALE_SIZE(x) (int)(((double)(x) / elm_app_base_scale_get()) * elm_config_scale_get())
But if number of significant figure of the return value goes over 15, the epsilon error will happen.
Because of that, it is better to divide to do later.
Reviewers: woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2900
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The evas box swallowed in "elm,swallow,index" part.
Then the each index item will be appended into evas_box when elm_index_go called.
If user make the line or dot for that swallow part for resize same as internall box.
edje_size_min_calc always give the '0'value for it.
Box will be swallowed the only on swllow part for desicion index layout size.
So the index min value should follow the box size.
Test Plan:
Run any index sample.
Get the index min size and check the value.
It gets always wrong before.
Reviewers: cedric, Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2896
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
An item size calculated with scale value when item appended.
This code is not need.
@fix
Reviewers: Hermet, woohyun, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2840
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
I add the APIs for supporting multi language on index.
"elm_index_item_priority_set()" API can give the priority value for each item.
it will be grouping with each priority items when index start to draw the item.
It can get a 0 or 1 (default : -1) -1 priority item show always even priority changed.
"elm_index_priority_set()" API can changed the current priority in manually.
priority will be up automatically when user send move event into last of priority 1 group item.
otherwise, priority will be down automatically when user send move event into first of priority 0 group item.
"elm_index_priority_get()" API can get a current index priority.
@feature
Test Plan:
I added the test application in test_index with give the name as "test_index3"
(It's for only show how to handle the priority APIs and show the how does it works for multi language
so it doesn't operate with genlist.)
You can check the how it works and how APIs works for it as well.
Reviewers: eunue, seoz, woohyun, Hermet
Subscribers: SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2729
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently, hoversel shows all items at the same time, but to limit
the size of contents and make it scrollable is neccesary to some users.
elm_hoversel_scroll_enabled_set/get() API makes the contents of hoversel
scrollable or not.
Test Plan:
The newly added scroll function is enabled for the second hoversel
in "hoversel" sample of elementary_test.
Reviewers: Hermet, raster, herdsman, cedric, tasn
Subscribers: JackDanielZ, cedric, Hermet
Differential Revision: https://phab.enlightenment.org/D2603
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If name of theme has ".",example "abc.def.edj", it would fail to check the file name.
So, I changed the strchr functions to strrchr function.
Reviewers: seoz, raster, Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2285
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This patch is code refactoring for genlist item cache logic
as same as gengrid item cache and removing unnecessary
Item_Cache properties.
{selected, disabled, expanded} exist in Item_Cache,
but _item_cache_find ignore those flagged properties,
so _elm_genlist_item_status_update will not working with
itc properties(all itc properties are EINA_FALSE).
Test Plan: Need to check elementary_test genlist sample working properly.
Reviewers: raster, Hermet, seoz, jaehwan, cedric
Reviewed By: cedric
Subscribers: cedric, singh.amitesh, eagleeye
Differential Revision: https://phab.enlightenment.org/D2660
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no way to give padding between each items, previously.
So i added horizontal, vertical padding here.
I will add APIs for set, get padding size set, get.
@feature
Test Plan:
Change the horizontal, vertical paddidng value in multibuttonentry.edc
Run elementary_test
Execute multibuttonentry sample.
Add items.
Check the padding between items.
Reviewers: woohyun, seoz, Hermet, raster
Reviewed By: Hermet, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2534
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently when user clicks on the radio, and when api value_set() called by
the developer we emit "elm,state,radio,*" signal. To support value change animation when
user interacts with radio. There is no way to distinguish the action in EDC.
This "elm,activate,radio,*" is a way which edc can make use to distinguish the state change signal
by the user action or due to api call.
Reviewers: Hermet, raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2829
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently when user clicks on the checkbox, and when api state_check() called by
the developer we emit "elm,state,check,*" signal. To support state change animation when
user interacts with check box. There is no way to distinguish the action in EDC.
This "elm,activate,check,*" is a way which edc can make use to distinguish the stae change signal
by the user action or due to api call.
Reviewers: woohyun, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: id213sin
Differential Revision: https://phab.enlightenment.org/D2817
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Test Plan:
1. Install previous version of elementary
2. Remove config from homedir
3. Build new config with elemetnary_config app
4. Install patched version of elementary
5. run elementary_test Hoversel test
6. Space end Enter should open hovesel
Reviewers: seoz, jaehwan, singh.amitesh, cedric
Reviewed By: cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2787
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
SIG_CAHANGED notify user to
genlist is now changed their items and properties and all
calculation is finished, so user can get correct values in
that callback.
This SIG_CHANGED smart callback already supported in gengrid.
Test Plan:
N/A
This patch is addition of new smart callback.
Reviewers: raster, seoz, singh.amitesh
Subscribers: Hermet, cedric, eagleeye
Differential Revision: https://phab.enlightenment.org/D2773
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Entry has only number text when activated and value changed, Even user registered special value to each spinner value.
If the user registered special value, we should check then showing the special value instead of number text.
Its will more helpful to expect the result when user set a spinner value using spinner entry.
@fix
Test Plan:
There is a spinner sample in elementary_test.
Changing editable value as TRUE for the last spinner object.
Click the spinner to activated entry and check the result.
Reviewers: Hermet, Jaehyun, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2844
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
set scroller size in content_set.
Resolves: T2623
@fix
Test Plan:
1. run ecrire
2. Add some text in newfile
3. Close ecrire
4. a almost zero size popup.
Reviewers: tasn, herdsman, raster, SanghyeonLee, stefan_schmidt
Reviewed By: stefan_schmidt
Subscribers: stefan_schmidt, herb, seoz
Maniphest Tasks: T2623
Differential Revision: https://phab.enlightenment.org/D2901
Summary: This fixes T2624 where ecore_wl_window_update_location was
being called inside the Ecore_Evas too often. It is now only called
from the Elementary window whenever we update the opaque region. This
should help to fix the resize issue that we are seeing in wl.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
We should steal the focus while setting focus to subobjects from parent.
This issue is reproducable in case of setting focus on one of items of hoversel
on expanded cb of hoversel.
@fix
Summary:
Two different behaviour are observed with clicked event.
1. When scroller is not present:
a. Mouse down over object,
b. mouse move outside the object
c. mouse up, clicked happens
2. When scroller is present:
a. Mouse down over object,
b. mouse move outside the object
c. mouse up, clicked NOT happens
So clicked callback should happen over the object only i.e when mouse move out of the objcet clicked should be ignored, and behaviour will be consistent
@fix
Test Plan: NA
Reviewers: shilpasingh, cedric
Differential Revision: https://phab.enlightenment.org/D2856
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently, radio is set EINA_FALSE when radio is disabled.
This causes unexpected behavior when the radio is selected and
get disabled. Using elm_radio_value_get() API will return
the value of disabled radio. This is not consistent with setting
EINA_FALSE when radio is disabled. Thus, disabled radio should
also have selected and unselected states.
Reviewers: woohyun, smohanty, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2880
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Changed docsw of elm_frame.eo according to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2885
Summary:
Changed docs of elm_flipselector.eo and elm_flipselector_item.eo to new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2884
Summary:
Converted docs of elm_fileselector_entry.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2882
This fixes a crash in edje_inspector as:
- delete callback is called on the object
--> this unloaded elm
- destructor is called on the object
--> this did some elm stuff, in particular read the config
from _elm_config (now NULL).
Instead, shutdown elm after del, during free.
Also reset hash pointer to NULL after free.
Summary:
Even user sets empty string here for text, label still packed in box with min size(finger size).
label_set internal logic is not clear before.
ex: object min set, resize check the string length then sending signal, min set again.
so i deleted the signal emit code here, we can handle label show, hide status in code and it's more clear.
Besides "sd->label" is always true all of the case. we need to check whether it's packed or not.
The label will be added to parent's sub object when it's packed into box.
label_set as empty string in adding time also meaningless.
@fix
Test Plan:
Run multibuttonentry sample.
Set a text somthing for it then set an empty string here.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2841
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When spinner change it's value it should call callbacks for
colorselector but not for spinner.
@fix
Reviewers: raster, reutskiy.v.v, cedric
Reviewed By: reutskiy.v.v, cedric
Subscribers: NikaWhite
Differential Revision: https://phab.enlightenment.org/D2780
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
In some MBE use case, Application can append item using only item_append API.
in that case, the end text(item count) doesn't update properly.
So, i add a code for fix it.
@fix
Test Plan:
1. Add a button for call "elm_multibuttonentry_item_append()" in test_multibbutonentry.c
2. Make MBE shrink mode.
3. Click button to append item to shrinked MBE.
4. Check the MBE end text state.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2848
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If there is a uneditable MBE, the MBE doesn't have to get a entry inside of the box.
It breaks MBE box layout, resize logic.
And check the box focus, entry visible is not enough to cover MBE is uneditable case.
If MBE is uneditable, box_resize callback called when item added. in this case,
we need to check what view type user want. if its not shrink view here, do not make
MBE to shrink mode.
@fix
Test Plan: Run elementary_test -> execute multibuttonentry sample with editable set as false.
Reviewers: Hermet, seoz, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2824
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: It has been observed that while scrolling of genlist with entry, clipping is not happening and "hit_rect" comes over navi item title. e.g. During theme change such scenario comes.
@fix
Test Plan: Scenario not in elementary test. Entry as content of genlist item. Same genlist should be the content of naviframe item. In this scenario genlist height must be grater than viewport sie so scrolling possible.
Reviewers: cedric, raster, Hermet, woohyun
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D2836
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The numerical formula below is calculated with the double type.
-> h_pad / edje_object_base_scale_get(wd->resize_obj) * elm_widget_scale_get(obj) * elm_config_scale_get()
But if number of significant figure of the return value goes over 15, the epsilon error will happen.
Because of that, it is better to divide to do later.
Reviewers: woohyun, raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2872
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
We don't have event block area in mbe.
Item clicked callback is not called when user clicked the item in mbe shrinked state.
However, item press effect will be shown.
@fix
Test Plan:
Delete the line always calling expanded set API in MBE clicked callback.
Execute MBE sample in elementary_test.
Check the item got a click event but not call the clicked callback.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2870
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
After applying eo to elm_flipselector_item,
APIs in elm_flipselector_common.h are generated by eolian.
elm_flipselector_common.h is no more necessary.
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2867
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_calendar_weekdays_names_set() API is generated by eolian,
but its prototype is defined in both elm_calendar_common.h and
elm_calendar.eo.legacy.h.
Remove duplicated reference from elm_calendar_common.h
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2866
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
strftime is quite a bad POSIX API. You won't know the size it needs to put the strings in
until you did give it enough byte and it could also fail without a clear way to detect it.
So this patch work around that and introduce a currently internal helper that will be moved
later to Eina.
This patch has been triggered by the issue reported and the attempt fix from D2877.
Summary:
Converted docs of elm_diskselector.eo and elm_diskselector_item.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2864
Summary:
Converted docs of elm_ctxpopup.eo and elm_ctxpopup_item.eo to new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2862
Summary:
Converted docs of elm_dayselector.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2863
Summary:
Updated docs of elm_container.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2852
Summary:
Converted docs of elm_clock.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2849
Summary:
Changed the docs of elm_calendar.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2846
* convert opaque region theme part to SPACER
- add rels for shaded/maximized state
* namespace opaque region theme part
* update opaque region only on pre-render
- fixes race condition between render size and opaque size
ref T2575
Summary:
Fix genlist crash issue of T2553 which happened by dangling pointer
access after deletion in item_select.
after item_focused callback, user call deletion and item_select din't
cover those cases.
Resolves: T2553
@fix
Test Plan: elementary_test -> genlist focus -> choose Genlist Cear on Focus
then originally crash will be happened. This patch will solve that problem.
Summary:
If x coordinate is equal to 0, key action is no more
effective as EINA_FALSE is returned. This is creating problem
in looping. Looping will be done when x < 0, but as soon as
x == 0, _key_action_move starts returning EINA_FALSE. Same
thing applies to y coordinate and other extremities.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan: elementary_test -> Scroller -> Loop in X axis -> scroll left using left key(looping does not happen)
Reviewers: raster, Hermet, cedric, singh.amitesh, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: sachin.dev, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2778
Title icon of popup is not getting shown.
steps to reproduce:
1. elementary_test -to "popup"
2. click "popup bottom title + text + 3 buttons"
In the test popup example, the initial parent of icon is popup.
The title_icon is reset to null while adjusting elm parent from popup
to main_layout (elm_widget_sub_object_add which calls sub_object_del of popup)
on swallowing icon to main_layout.
Resolves: T2581
@fix
Summary: This patch fixes opaque region setting under wayland in a
more proper/accurate way. This now sets the opaque region to be Just
what is visible (ie: only the dialog).
NB: This does not actually fix T2575 as that problem is inside E itself.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fixes T2575 more accurately (combined with previous
theme adjustments). Previous code would use a spacer object to help
calculate window opaque region. This is no longer necessary due to the
previous theme changes, and now calculates window opaque region to
coincide with what Enlightenment is expecting.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Changed the docs of elm_bubble.eo and elm_button.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2827
Without this, apps can't set a GLView to be in COPY mode.
COPY mode allows the glview to "poke holes" in the backbuffer of
the window, without the need for other objects below (eg. a
transparent rectangle in COPY mode).
Summary:
Converted docs of elm_bg.eo to new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Differential Revision: https://phab.enlightenment.org/D2819
Summary:
Converted docs of elm_app_server.eo and elm_app_server_view.eo to
new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2816
Summary:
Converted docs of elm_app_client.eo and elm_app_client_view.eo to
new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2814
The issue was introduced in 28e6878f7cce36efae1438b5e032eb9c0878016a.
While this is a fix in the sense that it reverts to the previously
defined behaviour (defined both in docs and code), the previous
behaviour was stupid and inconsistent. So now we are back to stupid and
inconsistent.
I can't fix this further, because unfortunately, the fix requires
intrusive changes that are just too dangerous to make this late in the
release cycle. Luckily for us, the issues only surface in a very
specific case that is quite uncommon. In order to trigger the bug you
need to set a very long piece of text on an entry that has text filters
set.
Fixes T2561
@fix
In most cases the code would not crash (I can't understand why),
but in some cases Eo would complain about call stack overflow.
Yep, that's a lot of recursive calls.
The mouse_down callback was trying to cancel its triggering
event and then send again the same mouse_down event. Why? I guess
because it was easier that also having a callback for move (drag
the colorselector arrows). Ugly...
This widget is in dire need for some love.
Hosang Kim
Amitesh Singh
Shilpa Singh
Prince Kumar Dubey
Carsten Haitzler
Andy Williams
Daniel Zaoui
Thiep Ha
Jaehwan Kim
Jee-Yong Um
Mike Blumenkrantz
Daniel Juyung Seo
jiin.moon
Woochan Lee
ChunEon Park
Lukasz Stanislawski
Yakov Goldberg
Daniel Zaoui
WooHyun Jung
Umesh Tanwar
Andrii Kroitor
Vaibhav Gupta
Vivek Ellur
Davide Andreoli
Vincent Torri
Tom Hacohen
Seunghun Lee
Luciana Magno de Almeida
Felipe Magno de Almeida
Stefan Schmidt
Daniel Hirt
Cedric BAIL
Anand
Yeshwanth Reddivari
Jérémy Zurcher
Daniel Kolesa
Jyotiprakash Sahoo
Sung-Taek Hong
Youngbok Shin
Stefan Schmidt
Jaehyun Cho
j_yong.hwang
SangHyeon Lee
Subhransu Mohanty
SangHyeon Lee
Nicolas Aguirre
Florent Revest
Chris Michael
Subodh Kumar
Jean-Philippe Andre
Vitalii Vorobiov
Prince Kumar Dubey
Derek Foreman
Vincent Torri