Commit Graph

90 Commits

Author SHA1 Message Date
Daniel Juyung Seo e756f97dae elm: Longwaited trailing white space removal. Clean elm up! 2013-09-30 22:15:01 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
ChunEon Park fe0f0a445e elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary setups again when obj <-> sub has connected.
2013-08-27 00:29:45 +09:00
Carsten Haitzler e663eb4411 clean up some multibutton ugliness - this breaks theme api...
multibuttonentry really didnt follow elm conventions - it didnt use
namespacing for most singals/swallows - it dug into objects reading
object part geometry where it just should have calced min size and be
done. it did all sorts of other things it shouldnt/didnt need to.. so
i fixed that now... and dark theme has the support.
2013-08-23 23:33:06 +09:00
Daniel Juyung Seo c5b0d63838 fixed documentation for consistency. Gets -> Get.
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
2013-08-22 05:24:46 +09:00
Carsten Haitzler 59e8bc5a35 Fix elm to use key not keyname (so xmodmap works) 2013-07-31 15:16:41 +09:00
Shinwoo Kim c47ef1b7fe [access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information 2013-07-31 12:57:49 +09:00
Jaehwan Kim 5e7742d4c3 Fix the wrong parameter in multibuttonentry. 2013-07-23 18:48:09 +09:00
Daniel Juyung Seo ecf6eff9a4 elm: formatting fix for consistency. 2013-07-23 06:05:16 +09:00
Daniel Juyung Seo cc9a5b3f06 elc_multibuttonentry.c: fixed dereference null return value issue which was spotted by coverity. CID 1040023.
elm_widget_item_new() can return NULL on error so it's better to check NULL.
2013-07-06 12:07:51 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
ChunEon Park ff10726141 elementary/ctxpopup, hoversel, naviframe, multibuttonentry, popup, diskselector, list, menu, segment_control, toolbar - support widget item language change 2013-04-23 20:30:15 +09:00
Daniel Juyung Seo 74b3eed5fd elm: print the error message inside elm_widget_sub_object_add().
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
   Elm devs should fix it beforehand.
   So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
Stefan Schmidt 9840d67f6a elm: No need for two set of parentheses in a simple comparison.
Seems this got copied around. Better fix it now before it widespreads more.
2013-03-22 08:44:15 +00:00
Tom Hacohen d75cb616da Change usage of eo_do_super to the new prototype. 2013-03-18 16:15:12 +00:00
Daniel Juyung Seo 78c042cdbe elm *.c: fixed formatting with EINA_LIST_FREE.
EINA_LIST_FREE (xxx) -> EINA_LIST_FREE(xxx)
2013-03-09 13:23:42 +09:00
Gustavo Lima Chaves 312d0217a0 An internal layout error, on a widget set, is a CRITICAL error. 2013-03-01 23:04:31 -03:00
Cedric BAIL 1aaa6e41e1 elementary: as previously stated sizeof (long) != sizeof (void*)
SVN revision: 84014
2013-02-17 03:53:02 +00:00
Daniel Zaoui cdd1eea853 Replace supported_types
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 83803
2013-02-10 07:52:31 +00:00
ChunEon Park e68959696d elementary/multibuttonentry - fix memory leak
SVN revision: 82439
2013-01-09 08:28:03 +00:00
Daniel Juyung Seo ffa9c1e793 elm: Refactoring.
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.

SVN revision: 82228
2013-01-04 19:10:19 +00:00
Shinwoo Kim f10fb3e115 [access] export some APIs,and remove unnecessary lines.
+ elm_access_object_register();
  + elm_access_object_unregister();
  + elm_access_text_set();
  + elm_access_text_get();
  + elm_access_cb_set();

These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();


SVN revision: 81659
2012-12-23 14:50:56 +00:00
Stefan Schmidt 94fd96be35 elm/multibuttonentry: Don't leak memory if the filter was already there.
SVN revision: 80879
2012-12-13 15:20:22 +00:00
WooHyun Jung 2bbb2dac16 [elementary/multibutton_entry] Fix focus problem in multibuttonentry.
Entry can get focus only when multibuttonentry is focused.


SVN revision: 80433
2012-12-07 10:54:04 +00:00
Cedric BAIL 3ef34e5dac elementary: eo_data_get can return NULL if the object is dead.
SVN revision: 80418
2012-12-07 08:44:47 +00:00
Daniel Zaoui 0c915e9023 Cleaning: removed include Eo.h in widgets because it was indirectly included by Elementary.h
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79682
2012-11-26 09:29:01 +00:00
Yakov Goldberg 5c98343198 We have ported to Eo all the widgets of elementary. We didn't change the inheritance itself, only the mechanism, as done previously in Evas, Ecore and Edje. We removed totally the previous inheritance mechanism.
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79668
2012-11-26 06:32:53 +00:00
Sanjeev BA 5d488c8ffb change returned value from -1 to EINA_FALSE.
Author:    KoziarekBeata <b.koziarek@samsung.com>

SVN revision: 78142
2012-10-18 00:55:19 +00:00
Jihoon Kim d19a9669c3 remove trailing spaces and fix coding style
SVN revision: 77838
2012-10-11 00:35:00 +00:00
Cedric BAIL 2c6d0a57c9 elementary: better fix for data corruption in multibuttonentry.
Patch by Jihyeon Seol <jihyeon.seol@samsung.com>


SVN revision: 77742
2012-10-10 09:44:38 +00:00
Kim Shinwoo 0864af3230 From: Kim Shinwoo <kimcinoo.efl@gmail.com>
Subject: [E-devel] [patch][elementary] multibuttonentry - access feature

i have attached a patch which has access feature for the multibuttonentry.
it was hard time to implement access feature on the multibuttonentry than
others.



SVN revision: 77738
2012-10-10 09:37:50 +00:00
Daniel Juyung Seo 30dba54610 elm: Fixed indentations for EINA_LIST/INLIST_FOREACH(_SAFE).
SVN revision: 77244
2012-10-01 07:36:27 +00:00
Jihyeon Seol ca35233c07 From: Jihyeon Seol <jihyeon.seol@samsung.com>
Subject: [E-devel] [Patch] multibuttonentry - data corruption issue of
the box list

here is a problem in the data corruption of the box list in
_box_layout_cb() of the multibuttonentry.

EINA_LIST_FOREACH is used to move and resize the objects. 
but if box unpack/pack is called in the EINA_LIST_FOREACH loop, 
the data of the box list will be corrupted.

This problem can not be solved immediately due to the structural
problems of
the MBE. 
So the attached patch, a workaround, avoids calling unpack/pack in the
EINA_LIST_FOREACH loop.

I am in the process of refactoring MBE but in the mean time, 
this patch will resolve the above issue.



SVN revision: 77192
2012-09-28 09:28:18 +00:00
Gustavo Lima Chaves 7f8d2e218e [elm] Multibuttonentry now a layout.
SVN revision: 75895
2012-08-30 16:46:12 +00:00
Jihyeon Seol de77d3aa99 From: Jihyeon Seol <jihyeon.seol@samsung.com>
Subject: [E-devel] [Patch] elc_multibuttonentry resize patch.

Currently, there is a problem in the logic of getting the size in the
MBE's
box.

For each line, the height of the line is calculated according to the
biggest
item's height 
and is applied to the box size, but problem occurs when the newly added
item's height is larger than the one before.

For example, when the entry is located in the front of the last line, 
the line's height is determined by the entry. 

When the button is added by the user's input at this state, 
because button's height is larger than the entry's height 
I have modified each line to have the equal height.



SVN revision: 75453
2012-08-20 08:02:47 +00:00
ChunEon Park 11e03b096f elementary/multibuttonentry - [E-devel] [Patch] elc_multibuttonentry memory leak patch
Dear, all

I've attached a patch that fixed the memory leak.

There is not a free() in _del_hook().

Please review this patch.

Sincerely yours,

Jihyeon Seol

Signed-Off-By: JiHyeon Seol<jiheyon.seol@samsung.com>




SVN revision: 75439
2012-08-20 05:22:06 +00:00
Minseok Kim 06be3e5ab6 From: Minseok Kim <minseok3.kim@samsung.com>
Subject: [E-devel] [E-deve] [Patch] Add new apis for editable set/get
in multibuttonentry

Typically multibuttonentry is used as a composer.
But sometimes, Multibuttonentry can be used as a viewer.
Currently there is no way to use multibuttonentry as non-editable
viewer.
So I added new APIs which are elm_multibuttonentry_editable_set/get().
If editable is true, entry in multibuttonentry is activated and user can
compose item by pressing the return key.
If not, entry is hidden and muttibuttonentry works as a non-editable
viewer.



SVN revision: 73223
2012-07-03 11:22:46 +00:00
Minseok Kim db61fd9dbb elementary/multibuttonentry: add focus handling at clicked,
and remove box region show. 

Signed-off-by: Minseok Kim <minseok3.kim@samsung.com>


SVN revision: 72484
2012-06-19 14:48:05 +00:00
Carsten Haitzler 3a7b769a63 use the new escape text set to clear up issues if theme has TEXT vs
TEXTBLOCK items and handling escapes so text is consistend across elm.
fiuxes the fileselector issues kai reported.



SVN revision: 70362
2012-04-20 12:51:10 +00:00
Daniel Juyung Seo 7908a77ad8 elm: Fixed formatting.
SVN revision: 69700
2012-03-28 09:02:22 +00:00
Daniel Juyung Seo 728ecc1b32 elm multibuttonentry: Deprecated elm_multibuttonentry_item_data_get/set. Use elm_object_item_data_get/set instead.
SVN revision: 69622
2012-03-26 00:07:28 +00:00
Daniel Juyung Seo 84edf10d93 elm multibuttonentry: Refactoring. Use more descriptive name for variable. current -> selected_it.
SVN revision: 69621
2012-03-26 00:07:14 +00:00
Daniel Juyung Seo 346aec5ad5 elm multibuttonentry: Fixed formatting.
SVN revision: 69607
2012-03-25 08:51:12 +00:00
GoUn Lee b655b831d3 From: GoUn Lee <gouni.lee@samsung.com>
Subject: [E-devel] [?Patch]elm_?multibutto?nentry bug fix

I've attached patch to fix bug in multibuttonentry.
When this widget is unfocused, there's no code for making unfocused
entry in multibuttonentry.
Because of that, when multibuttonentry got focus again, entry couldn't
get focus normally.
so I've added  code to fix this issue. when it's unfocused.

Also I removed unused value in resize_button() which is 'padding_inner'
 


SVN revision: 69583
2012-03-23 07:49:14 +00:00
ChunEon Park 2e43c4d488 elementary/multibuttonentry - let use signal callback description table
SVN revision: 69273
2012-03-13 00:45:01 +00:00
Jiyoun Park df7de15c06 remove deprecated code related with
elm_multibuttonentry_shrink_mode_get/set
elm_multibuttonentry_guide_text_get/set
function.


SVN revision: 69243
2012-03-12 10:20:42 +00:00
Jiyoun Park 8e57190579 remove code related with
elm_multibuttonentry_label
elm_multibuttonentry_item_label
elm_multibuttonentry_item_del
which was deprecated


SVN revision: 69107
2012-03-09 14:10:16 +00:00
Daniel Juyung Seo 543d234a2b elm multibuttonentry: Changed smart callback name. Discussed with multibuttonentry contributor. 'shrink,state,changed' -> 'expand,state,changed'.
Signed-off-by: Daniel Juyung Seo <juyung.seo@samsung.com>

SVN revision: 68882
2012-03-07 07:00:56 +00:00
Sanjeev BA 6f2249d9e9 add todo for elc_multibuttonentry.
Signed-off-by: Sanjeev BA <eflelev8@gmail.com>

SVN revision: 68878
2012-03-07 06:20:18 +00:00