Commit Graph

22832 Commits

Author SHA1 Message Date
Chris Michael 0701304205 Fix memleak reported by Coverity and replace some XFree calls with
just free.

NB: Fixes Coverity CID1039275

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:39:48 +01:00
Chris Michael d7600cfbee Fix memleak of window_prop_property_get
NB: Fixes Coverity CID1039274

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:34:28 +01:00
Chris Michael a01ce5e409 Fix memleak of window_prop_property_get
NB: Fixes Coverity CID1039273

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:30:34 +01:00
Chris Michael e33391ef56 Replace XFree with just free.
NB: XFree calls 'free' anyway, so this saves us a function call

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:28:15 +01:00
Chris Michael d7193f2830 Fix memleak reported by Coverity
NB: Fixes Coverity CID1039272

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:27:40 +01:00
Chris Michael 0d12ab48be Fix memleak spotted by Coverity: ecore_x_window_prop_property_get can
allocate space for 'data'. If we return before using it, then free
'data'. If we use it later for XGetAtomName, then we can free if After
we have gotten the atom names and sent the event. (NB: XGetAtomName
will allocate it's own space for the returned name, so this is safe).

NB: Fixes Coverity CID1039271

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:24:21 +01:00
Chris Michael 5969c97f7a Fix memleaks reported by Coverity: ecore_x_window_prop_property_get
allocates space for 'data'. We need to free that if we are going to
return before using it.

NB: Fixes Coverity CID1039270

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:17:58 +01:00
Chris Michael aea9e86eb4 Fix several memleaks reported by Coverity
NB: Fixes Coverity CID1039268

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:12:48 +01:00
Chris Michael 4ea1ea5bf4 Fix memleak spotted by Coverity
NB: Fixes Coverity CID1039267

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:58:15 +01:00
Chris Michael 02f545ecc6 Fix memleak. If we error out here, then we should free the data
returned from window_prop_property_get (as that does an allocation).

NB: Fixes Coverity CID1039266

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:47:13 +01:00
Chris Michael e6088e2361 Fix memleak reported by Coverity: If we are going to error out when
getting window netwm types, then free any atoms returned by
prop_atom_list_get.

NB: Fixes Coverity CID1039265

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:44:23 +01:00
Chris Michael e28f298dbd Fix memleak reported by Coverity: If we error out because we have a
hash with no key, then free the previously allocated data_stream.

NB: Fixes Coverity CID1039262

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:34:58 +01:00
Chris Michael b72e694573 Fix memleak reported by Coverity
NB: Fixes Coverity CID1039261

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:31:17 +01:00
Chris Michael 57924e5824 Fix memleak reported by Coverity: Close the descriptor returned by
popen if we are going to error out.

NB: Fixes Coverity CID1039184

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:25:59 +01:00
Chris Michael aeb4b7f7b9 Fix memleak reported by Coverity: If we fail to allocate a new
internal menu, then free the previously allocated memory for xml file.

NB: Fixed Coverity CID 1039183

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:19:37 +01:00
Chris Michael c04cfde0e5 Fix mem leak reported by Coverity: If we fail to create a new internal
menu, then free the previously allocated xml file.

NB: Fixes Coverity CID 1039182

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:17:13 +01:00
Chris Michael 2aa12782b6 If we open a file for copying, then we should also Close that file
when the copy is done.

NB: Fixes Coverity CID1039181

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:13:56 +01:00
Chris Michael a8bb3ec5ce Add common wayland function to get the pointer xy from wayland
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:02:58 +01:00
Chris Michael 4d2de522fa Add pointer_xy_get function to engine functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:00:28 +01:00
Chris Michael f0e47a2219 Add pointer_xy_get function to engine functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:59:20 +01:00
Chris Michael fca4267ae4 Add functions to X engine for ecore_evas_pointer_xy_get and
ecore_evas_pointer_warp

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:57:00 +01:00
Chris Michael 362d89e05c Add ecore_evas_pointer_xy_get and ecore_evas_pointer_warp functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:56:02 +01:00
Chris Michael 5e988cc8cf Add pointer_xy_get and pointer_warp to engine functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:52:34 +01:00
Chris Michael 950dd9684c Update ChangeLog for Ecore_Evas pointer abstractions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:51:58 +01:00
Chris Michael 5c223328d4 Add ecore_evas_pointer_xy_get and ecore_evas_pointer_warp API functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:51:23 +01:00
Chris Michael 0c759d8093 Update ChangeLog for ecore_evas pixmap_new/get functions
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:49:55 +01:00
Chris Michael 6ea61e3e56 Fix formating ... Wow, how did this get sooo screwed ? :(
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:16:09 +01:00
Chris Michael 5f71c0afb1 Begone Vile Formatting !!!
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 10:01:38 +01:00
Chris Michael 6900d83095 Remove blank line
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:53:04 +01:00
Chris Michael 9103b7e2e3 Check the return of ecore_x_init and error out if that fails.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:21:33 +01:00
Jean-Philippe Andre ee037d3586 evas/cserve2: Add infix to shm filenames
Minor change
So, we can distinguish between image, font and index shm files.
2013-07-08 17:16:04 +09:00
Carsten Haitzler 9e459ef9d6 fix new ecore_x_pixmap typedef clashes in ecore_x 2013-07-08 17:15:11 +09:00
Mike Blumenkrantz b8e16b8f4a +eina_tiler_area_size_get
also fix docs for eina_tiler_area_size_set
2013-07-08 09:08:04 +01:00
Chris Michael 2a1b993162 Fix "Allocation size mismatch" reported by Coverity (short version: we
declared our 'roots' variable as Ecore_X_Window, but were allocating
as 'Window').

buffer_alloc: "malloc(num * 8UL)" allocates memory.
CID 1039601: Allocation size mismatch (SIZECHECK)
5. incorrect_multiplication: Allocating a multiple of 8 bytes to
pointer of type Ecore_X_Window, which needs 4 bytes.

NB: Fixes Coverity CID1039601

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:00:45 +01:00
Chris Michael 9fb63c761f Fix "Allocation too small" errors reported by Coverity. (Basically, if
we are going to allocate space for a variable of a certain type, then
lets make sure we Declare that variable as the proper type).

NB: Fixes Coverity CIDs 1039602, 1039603, 1039604

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:52:50 +01:00
Chris Michael 6011703bf5 Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:50:45 +01:00
Chris Michael 461e406b91 Fix memleak reported by Coverity.
NB: Fixes Coverity CID1039652

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:43:24 +01:00
Chris Michael 1ea718c283 Fix memleak reported by Coverity.
NB: Fixes Coverity CID1039654

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:38:54 +01:00
Chris Michael eabc1482f9 Fix memleak reported by Coverity.
NB: Fixes Coverity CID1039657

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:35:33 +01:00
Chris Michael 4e103fd858 Fix mem leak reported by Coverity (don't just free fdata if size > 0).
NB: Fixes Coverity CID1039665

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:30:26 +01:00
Chris Michael 72347e539b Fix copy/paste error in gl_common_context_push. (I beleive that texm
texture was wanted here, not tex texture).

MB: Fixes Coverity 1039670

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:26:08 +01:00
Chris Michael ff60a233d2 Fix unintended operator precedence... I do believe != 4 is what was
wanted here...Or (!(ob->map->cur.map->count == 4)) ... but not much
difference either way ;)

NB: Fixes Coverity CID1039673

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:22:23 +01:00
Chris Michael 8280ef3730 Remove the grab from any lists Before we free it.
NB: Fixes Coverity CID 1039888

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:08:10 +01:00
Jean-Philippe Andre c6db8ba782 evas/cserve2: Implement fast(er) scaling of images
In its current model, cserve2 will reopen, reload and scale an
image whenever a new scaled version is requested by the client.

Instead, we can load the original image when too many scaled
versions are requested, and place the original in the LRU.
2013-07-08 16:06:08 +09:00
Jean-Philippe Andre cf61319ae1 evas/cserve2: Minor fixes from Coverity check
- CID 1042303
- CID 1039912
- CID 1039285
2013-07-08 16:06:08 +09:00
Jean-Philippe Andre 8b257d0238 evas/cserve2: fix error parameter usage
The error pointer could be NULL but still dereferenced in case of
failure. Also, it wasn't reset in case of success.
2013-07-08 16:06:08 +09:00
Chris Michael bb30cd58ce We cannot use dname in the error message if we have already freed it
above, so fix. On a mkpath failure, print out the message, Then free
dname. Be sure to also free dname if we do not error.

NB: Fixes Coverity CID1039893

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 08:01:58 +01:00
Chris Michael b0fa8b6563 Remove timer and animator from the list Before freeing the variables.
NB: Fixes Coverity CID1039906 and CID1039906

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:50:35 +01:00
Chris Michael 10897713ea Remove dead code. In the error goto, im2 cannot exist here else we
would not have gotten to this error handler if it did (so no point in
checking for it and calling functions using it).

NB: Fixes Coverity CID1039926

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:39:44 +01:00
Chris Michael 9d60d6ccff Check return value of lseek call for errors.
NB: Fixes Coverity CID 1040029

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 07:31:50 +01:00