Commit Graph

64942 Commits

Author SHA1 Message Date
Carsten Haitzler 444f7eed01 elm - fix filesel deferred unref to not crash
@fix
2020-01-18 00:14:58 +00:00
Carsten Haitzler 3aa250e17f evas - fix access-after-free where during destroy hash item not cleared
leave it in the hash unfreed as it will be freed when the hash is soon
after durint destruction.

@fix
2020-01-18 00:14:58 +00:00
Hosang Kim fbb77e7d1c efl_ui_scrollbar: change scrollbar state when theme is reloaded.
Scrollbar visible state is not synchronized when theme is reloaded.

Differential Revision: https://phab.enlightenment.org/D10649
2020-01-17 17:21:09 +01:00
Marcel Hollerbach bac185e8f3 Introduce Separator
Summary:
this is just like elm_separator, just written for unified widgets.
This inherits from item, which has the advantage that this separator can
also be added into item container.

Reviewers: zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11125
2020-01-17 16:10:40 +01:00
Felipe Magno de Almeida 25e52f8106 C++: Fix use of @c_type tag in struct definition
Summary: Depends on D11090

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11099
2020-01-17 09:51:24 -05:00
Marcel Hollerbach 4250494f11 efl_ui_suite: fix test code of grid
Summary:
this test code seemed buggy, we used the iterator *after* the content
was changed. Additionally, we freed the iterator with free instead of
eina_iterator_free.

This fixes test test suite.
Depends on D11123

Reviewers: raster, zmike, cedric, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11124
2020-01-17 09:49:13 -05:00
Ali Alzyod cf45cbf6dd efl: correct class description name of simple class
Name of Efl_Class_Description should be eo-style class name.

related to D11115

Reviewed-by: YeongJong Lee <cleanlyj@naver.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11117
2020-01-17 14:03:25 +01:00
Xavi Artigas a0523ebba5 docs: Typo in Efl.Text_Cursor 2020-01-17 12:56:51 +01:00
Yeongjong Lee 478863862a efl_text_cursor: correct class description name of simple class
Summary:
Name of `Efl_Class_Description` should be eo-style class name.
Please check there is no segmentation fault on Test code below.

Thanks to @woohyun for reporting and test case.

Test Plan:
```
//mcs test.cs -out:test.exe `pkg-config --libs efl-mono`

using System;

class Program
{
   public static void Main() {
      Efl.All.Init(Efl.Csharp.Components.Ui);

      Efl.Ui.Win win = new Efl.Ui.Win(null);
      Efl.Ui.Box box = new Efl.Ui.Box(win);
      Efl.Ui.Textbox tb = new Efl.Ui.Textbox(win);

      Efl.Ui.Button btn = new Efl.Ui.Button(box);
      btn.Text = "Click Me!";
      btn.ClickedEvent += (s, e) =>
      {
         Efl.Text.Cursor cur1, cur2;

         tb.GetSelectionCursors(out cur1, out cur2);
         cur1.SetPosition(3);
         cur2.SetPosition(7);
      };

      box.Pack(btn);
      box.Pack(tb);

      win.SetContent(box);
      win.SetSize(new Eina.Size2D(200, 400));
      Efl.Ui.Config.Run();
      Efl.All.Shutdown();
   }
}
```

Reviewers: woohyun, ali.alzyod, bu5hm4n

Reviewed By: woohyun

Subscribers: cedric, #reviewers, #committers, woohyun

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11115
2020-01-17 15:06:18 +09:00
Hermet Park 0a61d5a44b canvas vector: fix to refresh svg file of vector object.
previously, svg file is not refreshed though the file is changed.

Let changed flag true properly to re-render properly.

@fix
2020-01-17 10:48:24 +09:00
Xavi Artigas bdaf20fb4c docs: Give some love to progress bar docs.
Differential Revision: https://phab.enlightenment.org/D11112
2020-01-16 16:36:43 +01:00
Ali Alzyod e92ee40b2f efl.ui.textbox: update _part_is_efl_ui_textbox_part
efl.ui.textbox: update _part_is_efl_ui_textbox_part

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11109
2020-01-16 16:36:42 +01:00
Ali Alzyod 250c7bd30d efl.ui.textbox: theme code cleanup
>You should not theme in _efl_ui_textbox_efl_object_finalize, but rather in theme_apply
>All part swallow things should be done in theme_apply.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11103
2020-01-16 16:36:39 +01:00
junsu choi 2f4ca46544 Efl.Ui.Vg_Animation: Change property name autorepeat to looping
Summary:
autoplay and autorepeat look similar and can be confusing.
so change autorepeat to looping.

ref T8476
Depends on D11022

Test Plan: N/A

Reviewers: Hermet, bu5hm4n, kimcinoo, segfaultxavi, zmike

Reviewed By: Hermet, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8476

Differential Revision: https://phab.enlightenment.org/D11061
2020-01-16 20:11:49 +09:00
a.srour 05bb02cbb0 Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys
Summary:
This should fix the behaviour of Ctrl+Backspace & Ctrl+Delete key down on `Efl.Ui.Textbox`.
Also added two tests for it.

Reviewers: woohyun, ali.alzyod, cedric, bu5hm4n

Reviewed By: woohyun

Subscribers: ProhtMeyhet, stefan_schmidt, segfaultxavi, bu5hm4n, #committers, #reviewers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11040
2020-01-16 17:53:36 +09:00
junsu choi 3a4c5cf6a5 tests: Add test cases for Efl.Ui.Vg_Animation
Add test cases for Efl.Ui.Vg_Animation APIs
 - vg_anim_playing_control
 - vg_anim_frame_control

ref T8476

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11022
2020-01-16 09:50:24 +01:00
WooHyun Jung 0b389a8338 efl_ui_textbox: rename efl_ui_text_part to efl_ui_textbox_part
ref T8522

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11107
2020-01-16 09:50:10 +01:00
Marcel Hollerbach 3ee174a5bf theme: remove not yet used groups
these groups are not used yet. So remove the groups for now.

ref T8501

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11077
2020-01-16 09:18:16 +01:00
Marcel Hollerbach 3af2b57fd2 efl_ui_progressbar: fix theming of progressbar
There was code in progressbar that parsed its own theme name, applied a
change, reassembed it, and set it again. However, when we simply stick
to the theme apply code path that we have in efl.ui.layout_base, we can
simply set the horizontal / vertical part to be the element, the rest is
the class. This safes a lot of code, additionally, the setting of the
spacer had to be moved to the theme_apply method, as this would not work
otherwise.

ref T8501

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11076
2020-01-16 09:18:11 +01:00
Marcel Hollerbach b57d0aa571 efl_ui_progressbar: do not allow parts on unified widgets
this only allows the default part to be gotten when running the unified
widget. A later widget can then be used to expose the second progressbar
part.

ref T8501

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11075
2020-01-16 09:18:08 +01:00
Jihoon Kim 008517645e ecore_imf: Deprecated autofill enums in input hints
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
2020-01-16 13:26:08 +09:00
Ali Alzyod bbecc6662d efl.ui.textbox: part implementation comments clean up!
Summary:
We did not use the **ELM_PART_OVERRIDE_** because it produces compilation error

```
../src/lib/elementary/efl_ui_textbox.c:3603:40: error: ‘EFL_UI_TEXTBOX_PART_CLASS’ undeclared (first use in this function)
 ELM_PART_OVERRIDE_PARTIAL(efl_ui_text, EFL_UI_TEXTBOX, Efl_Ui_Textbox_Data, _part_is_efl_ui_text_part)
```

Reviewers: woohyun, bu5hm4n

Reviewed By: woohyun

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8522

Differential Revision: https://phab.enlightenment.org/D11102
2020-01-16 09:12:01 +09:00
Carsten Haitzler ee6cc91a03 eina - fix eina_strndup test passing 2020-01-15 19:23:44 +00:00
Carsten Haitzler eb72593bbc eina - rmeove dup EINA_PRINTF
sorry for the noise...
2020-01-15 18:10:24 +00:00
Carsten Haitzler ffb6085816 eina - eina_strndup - use universal impl because strndup is an issue
freebsd/clang report strndup is not defined and string.h doesnt seem
to help if its included so move to the universal re-implementation
that was there for win32 anyway
2020-01-15 19:06:07 +01:00
Carsten Haitzler d990ab7dba eina - enable EINA_PRINTF for clang as well as gcc 2020-01-15 19:06:07 +01:00
Christopher Michael e2ba332866 tests/ecore_wl2: Add test for ecore_wl2_input_pointer_xy_get function
ref T8016
2020-01-15 11:05:22 -05:00
Christopher Michael 4c232f12d7 tests/ecore_wl2: Remove test of ecore_wl2_window_hint_aux functions
These functions are now internal to EFL and do not require tests.

ref T8016
2020-01-15 10:20:54 -05:00
Christopher Michael ae8673628d ecore-wl2: Move ecore_wl2_window_aux hint functions to be internal
These functions are unused outside of EFL (not used in Enlightenment
or Tizen), so there is no need to expose them publicly.

ref T8013
2020-01-15 10:20:54 -05:00
Christopher Michael db25045ffb tests/ecore_wl2: Minor formatting fix 2020-01-15 10:20:54 -05:00
junsu choi e71cfba201 elementary_test: Apply changed event related to Efl.Ui.Vg_Animation
Summary:
Events has changed from Efl.Ui.Vg_Animation to Efl.Player.
Apply the changes.

ref T8476
Depends on D11080

Test Plan: elementary_test -to "Vector Graphics Animation"

Reviewers: zmike, Hermet, kimcinoo

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, segfaultxavi, bu5hm4n

Tags: #efl

Maniphest Tasks: T8476

Differential Revision: https://phab.enlightenment.org/D11100
2020-01-15 09:24:12 -05:00
Mike Blumenkrantz a63306a908 efl/player: merge in and rework events from vg_animation
Summary:
this adds comprehensive events for the player interface which can be used
to provide details about the state of the playback

ref T8476

Depends on D11098

Reviewers: jsuya, bu5hm4n

Reviewed By: jsuya

Subscribers: jsuya, segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8476

Differential Revision: https://phab.enlightenment.org/D11080
2020-01-15 09:24:07 -05:00
Mike Blumenkrantz 2f7eef14d8 elm/animation: correctly implement legacy class
Summary: cmon.

Reviewers: bu5hm4n, jsuya

Reviewed By: jsuya

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11098
2020-01-15 09:23:59 -05:00
Jaehyun Cho 090df4331b evas_gesture: change getter methods to read-only properties
Summary:
From language bindings' perspective, it seems better that read-only
properties are provided instead of getter methods.

ref T8557

Reviewers: segfaultxavi, CHAN

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8557

Differential Revision: https://phab.enlightenment.org/D11094
2020-01-15 14:40:38 +01:00
WooHyun Jung e1a329a3e9 efl_text_cursor: update doc for Efl.Text.Cursor_Type
Summary: ref T8566

Reviewers: segfaultxavi, ali.alzyod

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8566

Differential Revision: https://phab.enlightenment.org/D11105
2020-01-15 14:19:34 +01:00
Carsten Haitzler 72a8a2ce40 ecore_exe/efl_exe - implement exit with parent on bsds with procctl 2020-01-15 12:14:31 +00:00
Felipe Magno de Almeida 77db0820e3 c#: Remove warning about unused variable
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11097
2020-01-15 11:16:39 +01:00
Jaehyun Cho 7661473f28 efl_canvas_animation_group: preserve each animation's duration
To preserve each animation's duration, group animation's duration is
copied to each animation's duration only if group animation's duration
is set.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11104
2020-01-15 11:09:21 +01:00
Ali Alzyod 4386a70177 efl.ui.textbox: paste in mouse button 2
efl.ui.textbox: paste in mouse button 2 work on primary instead of clipboard

Differential Revision: https://phab.enlightenment.org/D11068
2020-01-15 11:03:52 +01:00
Ali Alzyod 1a1868ce57 efl.ui.textbox: replace hoversel with popup
efl.ui.textbox: replace hoversel with popup
**I think this may need some changes, please let me know what you think**

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11072
2020-01-15 10:49:58 +01:00
Jaehyun Cho 76631f502a efl_mono: remove class ExtensionTag
Summary:
Since class BindablePart and class BindableProperty use generic type
constraint as "where T : <class name>", class ExtensionTag is no longer
needed.

Reviewers: SanghyeonLee, felipealmeida, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11101
2020-01-15 18:45:38 +09:00
Ali Alzyod a53ef37c54 efl.ui.textbox: add efl.input text as composite interface
Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8522

Differential Revision: https://phab.enlightenment.org/D11092
2020-01-15 09:19:14 +09:00
WooHyun Jung 04d4aeb8b7 edje_entry: fix some preediting bugs
1. Attributes can come with random sequence.
   So, attribute list should be sorted based on start_index.
2. None tag can be used for some languages' preediting.
   So, the tag also needs to be handled the same with other tags.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11059
2020-01-14 17:19:58 +01:00
WooHyun Jung d412f73a99 efl_ui_textbox: mark @beta to cnp_mode and item_factory
After stabilizing efl_ui_textblox, these properties should be
kept as @beta.

ref T8522

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11093
2020-01-14 17:19:54 +01:00
Woochanlee 2010c2ce13 tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions
Summary:
Add below APIs.
ecore_wl2_window_commit
ecore_wl2_window_frame_callback_add, del
ecore_wl2_window_free
ecore_wl2_window_hide
ecore_wl2_window_shell_surface_exists
ecore_wl2_window_show
ecore_wl2_window_update_begin

+ Fix ecore_wl2_activated_get()

ref T8016

Reviewers: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8016

Differential Revision: https://phab.enlightenment.org/D11007
2020-01-14 08:33:03 -05:00
Yeongjong Lee ae30d3c57b eina_mono: replace eina_list and eina_array with IList
Summary:
Eina.List<T> => System.Collections.Generic.IList<T>
Eina.Array<T> => System.Collections.Generic.IList<T>

ref T8486

Depends On D10785

Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: felipealmeida, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8486, T8488

Differential Revision: https://phab.enlightenment.org/D10902
2020-01-14 17:17:05 +09:00
Ali Alzyod e894c9bff8 efl.input.text: add variation enums + remove @since word
Summary: efl.input.text: add variation enums + remove @since word

Reviewers: woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8541

Differential Revision: https://phab.enlightenment.org/D11066
2020-01-14 10:42:06 +09:00
Marcel Hollerbach f5fd009992 Revert "efl_ui_spin_button: add tests for direct input feature"
This reverts commit f62cee28cb.

This seems to cause trouble on the CI - lets recheck that.
2020-01-13 18:59:35 +01:00
Marcel Hollerbach 2f8029412d eina_types: declare unicode type stable
this is needed in order to get text stable.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11074
2020-01-13 15:57:29 +01:00
Marcel Hollerbach 6a9a390d13 efl_ui_spin_button: test that max can be reached by clicking inc
this is esp. testing if this is possible with step not beeing a multiple
of max.

Differential Revision: https://phab.enlightenment.org/D11011
2020-01-13 15:57:25 +01:00