Summary:
Selection handlers' position are not updated when entry is scrolled.
You can check on elementary_test -> Entry 3 (or Entry 4 which is scrollable) -> Select some text -> Scroll entry and see.
This patch is submitted to fix this bug. It update selection handlers' position when entry is scrolled and hide them if needed.
@fix
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D640
This deferred recalc job is considered for wrap mode.
if the wrap mode is disabled, this job should be discarded.
since the wrap mode is enabled in default.
the job would be performed even the wrap mode was changed later.
@fix.
Summary:
In elm entry, cursor handlers are placed and moved incorrectly if we do selection from bottom to top.
Ex: In elementary_test -> Entry -> Right click -> choose Select -> do selection from bottom to top (or press Shift + <- keys to do selection).
Look at selection handlers: they are incorrectly placed.
Try to move selection handlers: They suddenly move to near each other.
Minor: Remove unused variable.
@fix
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D583
Summary:
Magnifier is displayed incorrectly when mouse down on selection handler
Reproduce way: Right click on entry (eg Entry), choose Select, select some text, press left mouse
on selection handler (do not move the mouse), take a look at magnifier position.
Reason: Magnifier position is set to mouse down position in entry.
Fix: Check mouse down status and place correct position for magnifier.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D573
Summary:
Issue 1: If you drop text to elm_entry, text is inserted twice.
Reason: Drop callbacks are registered multiple times in elm_entry.
Resolve: Register only one drop callback at entry side.
Issue 2: Even thought entry is disabled, non-editable, you still can drop text, image file. (Example, run Entry Scrolled and drop text, image file to disabled or non-editable entries).
Reason: Drop callback are registered but not remove when entry is set to disabled, non-editable mode.
Resolve: Correct registering and removing drop callbacks in entry.
Reviewers: JackDanielZ, raster
Reviewed By: raster
CC: woohyun
Differential Revision: https://phab.enlightenment.org/D565
Initial select mode was not properly set, as was just left to default.
This, in combination with the following from the efl repo:
commit 211845c885
commit c061e76927
fixes T861.
Summary:
in case of GTK, it provides API to select a region of text (gtk_editable_select_region).
However, there are only API to select all or none in EFL.
This API will provide the way to select a region of text.
Test Plan: elementary_test > entry3 > press 'Region' button
Reviewers: woohyun, tasn, id213sin
Reviewed By: tasn
Differential Revision: https://phab.enlightenment.org/D520
Summary: Fix a bug with finding the proper geometry when reporting anchor
interaction. It's easy to see in entry anchor2 test in elementary_test
when clicking on the lower border of the anchor.
Anchor geometries are relative to the textblock object. The problem was
that this was accounted for using the edje object's geometry instead of
the textblock geometry thus causing an offset.
Reviewers: JackDanielZ, tasn
CC: seoz
Differential Revision: https://phab.enlightenment.org/D436
TAsn: Commit message edited by me.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.
This makes reducing duplicated code and supporting language,chagned from all widgets.
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
If edje_object_part_text_get gives different text from original one,
length of text can be changed. So the last position of tmpbuf should
be calculated again refering to the current text to be returned.
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
Summary:
In TTS mode, when the entry is highlighten and double tap to the entry,
the entry will be focused. But "clicked" smart callback is not called, input panel is not shown.
So I we need to call the callback and show input panel in smart activate.
Reviewers: seoz, Hermet, woohyun, tasn, jaehwan, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D465
Summary:
Default theme of entry does not have any disabled state in "elm/scroller/entry/*" styles.
But EFL developer can make any custom style for entry and scroller and it can has disabled state.
So _elm_entry_smart_disable has to emit "*disabled" signal to scr_edje.
Reviewers: woohyun, tasn, seoz, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D464
This API sets the attribute to show the input panel in case of only an user's explicit Mouse Up event.
It doesn't request to show the input panel even though it has focus.
Using the elm_scrollable_interface_content_viewport_resize_cb_set in
scrollable entry widget. this only happens in mobile profile when you
drag the content with your finger left/right when the content is
smaller than the gap between icons.
This accepts D187
and removed unnecessary local variable.
- Do not need to call the same function with same parameter many times.
Use local variable for them.
- Remove unnecessary local variable if it is not needed.
This API sets the attribute to show the input panel in case of only an user's explicit Mouse Up event.
It doesn't request to show the input panel even though it has focus.
Summary:
Add "rejected" smart callback.
Applications using the *filter_accept_set didn't know when the input was rejected.
This smart callback can provide a simple information to applications.
Reviewers: woohyun, tasn, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D413
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
use the fill_set instead of the clipper.
soon after 1.8, proxy just created the filled area buffer, then magnifier surface size will be fixed regardless of the entry source.
Daniel Zaoui
Thiep Ha
Daniel Juyung Seo
ChunEon Park
Carsten Haitzler
Jaehwan Kim
Tom Hacohen
Jihoon Kim
Daniel Hirt
Youngbok Shin
WooHyun Jung
Yakov Goldberg
Jihoon Kim
Daniel Juyung Seo
Ryuan Choi