Summary:
This patch fixes the issue of month wrapping due to summer time correction is some locales
by ignoring day light saving mode in mktime
Signed-off by: M.V.K Sumanth <sumanth.m@samsung.com>
@fix
Test Plan: Change the date for month were day light saving mode is applied and observe the wrapping.
Reviewers: seoz, Hermet, raster
Reviewed By: raster
CC: govi, raster
Differential Revision: https://phab.enlightenment.org/D590
@bugfix: Previous elm config messages did not echo if drm was
detected. This adds some (auto)detection, and some output to say if it
was found.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
In elm entry, cursor handlers are placed and moved incorrectly if we do selection from bottom to top.
Ex: In elementary_test -> Entry -> Right click -> choose Select -> do selection from bottom to top (or press Shift + <- keys to do selection).
Look at selection handlers: they are incorrectly placed.
Try to move selection handlers: They suddenly move to near each other.
Minor: Remove unused variable.
@fix
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D583
This use the infrastructure of Edje to set the AUTHORS of the theme. It now
make sense to track who did contribute to the theme only. Maybe we could use
those information into Enlightenment About Theme dialog.
Summary:
Previously text colors were specfied in the form color: XXX XXX XXX AAA throughout all the edc files, eg color: 255 255 255 255 this made it imposible to write a script to change text colors with sed as it changed many other parts of the theme as well.
Some colors had been defined in fonts.edc and in some places these were used but not many. This change means that all non textblock font colors are defined in fonts.edc and the defined names are used throughout the entire code base. This means that sed only needs to be run on 1 file to change the text color or it is easy to do manually
textblock colors were not done for 2 reasons
1. They hadn't been done in the past so there was no standard for me to follow.
2. They are all specified in html notation eg #FFFFFF which means that they can be changed with sed without effecting the rest of the theme.
If a standard can be come up with for doing this and people think it is worthwhile i can probably fix them at a later date
Reviewers: raster, zmike
Reviewed By: raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D577
Conflicts:
data/themes/edc/battery.edc
data/themes/edc/xkbswitch.edc
Summary:
Emit "elm,state,visible" "elm" signal to edc file when first item is pushed.
Above signal can be used if an application wants to do something when the first view is shown on the screen.
@fix
Reviewers: Hermet, seoz, raster
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D483
Summary:
The soon to be deleted item 'it' is removed from the list at line 356.
So the first item of the list can never be the same one with it,
which means else statement is unreachable.
Test Plan: None
Reviewers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D597
Summary:
The code was missing null check of sd->items list.
If the deleted item is the only item of the list,
sd->items becomes empty after removing it.
In that case, sd->selected_item should be set as NULL.
@fix
Fixes T988
Test Plan: execute diskselector_example_02 > click "Delete item" button 3 times
Reviewers: raster, seoz
Reviewed By: seoz
CC: seoz
Maniphest Tasks: T988
Differential Revision: https://phab.enlightenment.org/D595
- return EINA_TRUE when the event is processed. return EINA_FALSE
otherwise.
- use 'else if' statement without successive 'if' statement.
- removed unnecessary casting.
- marked on_hold flag to processed event.
- Reduced the if statement depth.
- Introduced new macro ELM_RECTS_POINT_OUT that checks if the point(xx,
yy) stays out of the rectangle(x, y, w, h) area.
Summary:
support color classes for runtime color changes.
It works like text classes and is also added in configuration files.
Reviewers: seoz, Hermet, cedric, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D541
@fix
Hover itself does not get key event. It should just forward the event to
the internal objects. So make it unfocusable.
Special thanks to Woohyun Jung.
Summary:
Problem: list theme (elm/list/base/default) is an alias of scroller
base theme (elm/scroller/base/default) in which focus_highlight is set to "on".
Solution: Now focus highlight in_theme is set by list item theme.
Test Plan: elementary_test->"List Focus"
Reviewers: seoz, woohyun
Reviewed By: seoz
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D572
Summary:
# Added code to handle the case of disabled items.
# Code refractoring of _item_focused_next().
Test Plan: elementary_test->"list focus"
Reviewers: seoz, woohyun
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D571
@feature
Summary:
# Added "item,focused" and "item,unfocused" smart callbacks.
# Added elm_object_focused_item_get() in elm_widget
# Added elm_object_item_focus_set and elm_object_item_focus_get() APIs for
# Added one argument in existing _focus_highlight_geometry_get(...,is_next)
This is required to find out previous and current widget item.
# Added a elm_win function _focus_highlight_start() which starts the focus
Test Plan: elementary_test->List Focus , List Horizontal Focus
Reviewers: seoz, woohyun
Reviewers Comments: SeoZ - there are some known bugs. we will actively
fix them in a near future.
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D532
@feature
Summary:
1. Added "item,focused" and "item,unfocused" callbacks for widget item since
VIEW(item) is a elm layout.
2. Added sd->box into focus chain to enable the focus movement on widget items.
Test Plan: elementary_test -> popup -> "popup-center-title + items + 3 buttons"
Reviewers: seoz, woohyun
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D563
Summary:
Magnifier is displayed incorrectly when mouse down on selection handler
Reproduce way: Right click on entry (eg Entry), choose Select, select some text, press left mouse
on selection handler (do not move the mouse), take a look at magnifier position.
Reason: Magnifier position is set to mouse down position in entry.
Fix: Check mouse down status and place correct position for magnifier.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D573
Code should look compact, why use small fonts otherwise?
Reduce the gap between code lines (stored as separate <div>)
to 70%. This looks about right.
See rEFL0a97a74319256db53fb6e8704b77eb21f92e95a8
Yes, I know. Someone hates large fonts.
But the ones currently used are so SMALL!
Also, this will just revert back to what's defined in e.css,
because body and list font size aren't even consistent.
Also, display the page titles like titles: big fat blue letters.
See rEFL642f2ecca9350548c6f260edfcd7e2f58d2de662
If a param description is long and spans on multiple lines,
then the param name should be aligned to the first description
line. Otherwise the layout becomes confusing.
Align [in] and [out] vertically like params.
See rEFL0471c9a8353b4847bb2f00be5757868cb3195b7a
if the object is added twice to the one transit,
the obj_remove_cb would be called twice.
in this case it will try to access the freed obj_data and crashed up.
now it's fixed.
Watchwolf was removed as he was in there twice. For the newly added I hope
I did not add duplicates or missed someone. If you spot a problem please
go ahead and fix it.
Before
elm_tooltip_move_lock_set()
elm_tooltip_move_lock_get()
After
elm_tooltip_move_freeze_push()
elm_tooltip_move_freeze_pop()
elm_tooltip_move_freeze_get()
we're likely to use the freeze rather than lock among the entire apis.
it's already discussed in the mailing list.
Summary:
when style is set to be different one, spinner didn't update its min size.
So there was an issue that spinner has wrong position since it wasnt' check the updated size
Reviewers: Hermet, seoz
Reviewed By: seoz
CC: raster, cedric
Differential Revision: https://phab.enlightenment.org/D569
Summary:
Issue 1: If you drop text to elm_entry, text is inserted twice.
Reason: Drop callbacks are registered multiple times in elm_entry.
Resolve: Register only one drop callback at entry side.
Issue 2: Even thought entry is disabled, non-editable, you still can drop text, image file. (Example, run Entry Scrolled and drop text, image file to disabled or non-editable entries).
Reason: Drop callback are registered but not remove when entry is set to disabled, non-editable mode.
Resolve: Correct registering and removing drop callbacks in entry.
Reviewers: JackDanielZ, raster
Reviewed By: raster
CC: woohyun
Differential Revision: https://phab.enlightenment.org/D565
Add minimum comments for Eo API to make Eolian correctly
process methods and parameter directions
There are still exist not/half implemented functions, for which
I didn't add comments.