Commit Graph

278 Commits

Author SHA1 Message Date
Daniel Juyung Seo e7528a2e78 naviframe: Use elm_widget_item_del() when you want to delete the item
data.

It will call del_pre_func and free the item data.
Special thanks to glima for the report.
2014-01-22 23:33:47 +09:00
Jaehyun Cho 404093c701 [naviframe] Fix to enable item deletion in pop_cb
Summary: Fix to enable item deletion in the registered pop_cb function

Reviewers: Hermet

Reviewed By: Hermet

CC: seoz

Differential Revision: https://phab.enlightenment.org/D487
2014-01-22 22:13:51 +09:00
Jaehyun Cho 1ca6d33e08 [naviframe] do not size evaluate during deletion
Summary: Author: Shinwoo Kim <cinoo.kim@samsung.com>  2012-12-11 20:13:39

Reviewers: Hermet

CC: seoz

Differential Revision: https://phab.enlightenment.org/D485
2014-01-22 22:09:16 +09:00
Jaehyun Cho ef93bf6616 [naviframe] Fix to hide the previous view by emitting signal
Summary:
Previously, previous view was hidden by evas_object_hide.
         However, this method is no longer correct because size calculation of naviframe causes evas_object_show.
         Now, previous view is hidden by emitting signal to naviframe theme and clipper hides the previous view.

Reviewers: Hermet

Reviewed By: Hermet

CC: seoz

Differential Revision: https://phab.enlightenment.org/D484
2014-01-22 22:07:31 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
ChunEon Park 812bdae606 elementary - don't use __UNUSED__ anymore 2014-01-15 14:36:55 +09:00
Jaehyun Cho afef2271fd [naviframe] Replace naviframe title visible APIs to naviframe title enabled APIs
Summary:
To support naviframe title transition effect, naviframe title enabled APIs are applied.
         To remove the duplicate functionalities, naviframe title visible APIs are deprecated.

Reviewers: Hermet

Reviewed By: Hermet

CC: seoz, raster

Differential Revision: https://phab.enlightenment.org/D426
2014-01-15 14:29:05 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Jaehyun Cho d29dc290f0 [naviframe] Fix not to re-load previous item view's theme
Summary: Calling elm_widget_sub_object_add after calling elm_widget_sub_object_del may cause theme loading even though the sub object's theme is the same as the parent object's theme. This commit prevents the previous item view's theme re-loading.

Reviewers: Hermet, seoz

Reviewed By: seoz

CC: seoz

Differential Revision: https://phab.enlightenment.org/D267
2013-10-18 19:53:16 +09:00
Carsten Haitzler 09f2edaa24 fix uninitialized memory usage in naviframe 2013-10-17 22:17:02 +09:00
Jaehyun Cho db2d711d64 [elm_widget] Enable not to add resize object to or delete resize object from sub object when the resize object is set.
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.

Reviewers: Hermet, seoz

CC: Jaehyun_Cho, seoz, raster

Differential Revision: https://phab.enlightenment.org/D265
2013-10-17 01:19:40 +09:00
Carsten Haitzler 95fdc9cc88 fix up namespace for many signal while keeping old versions for compat 2013-10-05 21:35:27 +09:00
Daniel Juyung Seo 13be068cf8 elc_naviframe.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:12:56 +09:00
Daniel Juyung Seo cec2f74648 elc_naviframe.c: Check value before dereferencing it.
This fixes coverity CID 1099698.
2013-09-30 22:16:34 +09:00
Daniel Juyung Seo e756f97dae elm: Longwaited trailing white space removal. Clean elm up! 2013-09-30 22:15:01 +09:00
WooHyun Jung ec5c1c7b3b elementary/naviframe.c : Because naviframe is focusable, it should set focus to itself when the new item is unfocusable. 2013-09-30 10:09:23 +09:00
ChunEon Park 99f85556a7 elementary/naviframe - don't delete the animator.
if it removed the pushing animator then the item will be left with invalid state.
2013-09-27 00:41:02 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
Jaehyun Cho aabd3e7f27 [naviframe] Enable item pop during item push.
Enable item pop during item is pushing (during item push transition).
2013-09-18 02:20:33 +09:00
Jaehyun Cho 0c304508ba [naviframe] - Set hint min size of the naviframe as the top item's min size
Signed-Off-By: JaeHyun <jae_hyun_cho@naver.com>
2013-09-06 02:32:08 +09:00
ChunEon Park f7adffc8fa elementary/naviframe - Revert "elementary/naviframe - update only theme changed views"
This reverts commit dcc392cb9e2a0baa738804de0c1ffb66b3d7b472.

They should be done since all the edc states are reset whenever theme is changd.
2013-08-21 11:43:39 +09:00
ChunEon Park 301dd870e5 elementary/naviframe - update only theme changed views 2013-08-10 13:58:17 +09:00
Carsten Haitzler 59e8bc5a35 Fix elm to use key not keyname (so xmodmap works) 2013-07-31 15:16:41 +09:00
Shinwoo Kim c47ef1b7fe [access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information 2013-07-31 12:57:49 +09:00
ChunEon Park b331eeb660 elementary/naviframe - eeek. please keep the smart member order. 2013-07-29 19:51:44 +09:00
Daniel Juyung Seo ecf6eff9a4 elm: formatting fix for consistency. 2013-07-23 06:05:16 +09:00
ChunEon Park 66a489a14d elementary/naviframe - If the current item is added as the resize object, the previous will be canceled.
Now, keep the smart members always.
2013-06-30 17:42:59 +09:00
Daniel Willmann df2b8a24a0 elc_naviframe: Use ! instead of ?-operator in _resize_object_reset()
Shorter and easier to understand this way.

Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-06-27 09:40:06 +01:00
Daniel Willmann a856be3c59 elc_naviframe.c: Correctly call _resize_object_reset()
Incorrect use of the ?-operator...

Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-06-26 16:45:54 +01:00
ChunEon Park 5488d7c1b4 elementary/naviframe - dont' be popped if the event is freezed and popping is going on. 2013-06-16 19:57:19 +09:00
ChunEon Park eaa94c2688 elementary/naviframe - oops, here more proper check. 2013-06-13 16:36:13 +09:00
ChunEon Park 5263213062 elemenatry/naviframe - keep the current view on top to have events and don't try to add member for the deleted dummy. 2013-06-13 15:46:16 +09:00
ChunEon Park 7982138843 elementary/naviframe - more clean code 2013-06-12 22:28:40 +09:00
ChunEon Park 3edbacc7d4 elementary/naviframe - it's not intended code. remove it. 2013-06-11 21:55:44 +09:00
ChunEon Park 2368f82e31 elementary/naviframe - Keep the smart members of the naviframe views whenever resize object is changed.
This prevents the dangling view objects of the naviframe and keep the layer consistency.
2013-06-11 18:08:10 +09:00
ChunEon Park a1d3265cad naviframe - keep the animator just one. 2013-06-11 12:20:10 +09:00
Daniel Juyung Seo f1b685897d elm: do not declare SIG_FUCSED/SIG_UNFOCUSED if the const char is not used more than once.
ctxpopup, fileselector_button, naviframe, player, popup, bubble, button, calendar, check, clock, colorselector, datetime, diskselector, flipselector, gengrid.
2013-06-10 14:13:55 +09:00
Daniel Juyung Seo 7b71bd1973 ctxpopup, fileselector_button, naviframe, player, popup, bubble, button: added "focused" and "unfocused" documentations. 2013-06-09 18:54:43 +09:00
ChunEon Park d260935270 elementary/naviframe - don't ignore the subtitle case 2013-06-08 18:13:26 +09:00
ChunEon Park 16bcf540b2 elementary/naviframe - return as soon as possible 2013-06-08 18:11:09 +09:00
ChunEon Park 8c7b28b4ed elementary/naviframe - try to read the titles only when title is set and title_area is visible 2013-06-08 18:10:17 +09:00
ChunEon Park 76465a7fdd elementary/naviframe - no! don't have the keyboard dependenccy with naviframe. 2013-06-08 17:40:39 +09:00
ChunEon Park bfc63634c1 elementary/naviframe - fix the naviframe to recover the focus when top item is deleted 2013-06-05 16:31:49 +09:00
ChunEon Park 1e9ef8aa5b elemenatry/naviframe - don't pop the view if the freeze_event is enabled and some views are alreadying popping. 2013-05-20 20:43:22 +09:00