Summary: This fixes ticket T2573 where an extra new line was being
added after dropping an item in the Genlist DnD tests. There's really
no need to be appending a '\n' on each item here as that ends up
adding an extra blank item to the drop.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Changed the docs of elm_calendar.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2846
* convert opaque region theme part to SPACER
- add rels for shaded/maximized state
* namespace opaque region theme part
* update opaque region only on pre-render
- fixes race condition between render size and opaque size
ref T2575
Summary: This fix adjusts the shadow spacer elementary when we
maximize/unmaximize a window. When in a maximized state, we do not
have to reserve space for the window shadow. This partially fixes
T2578. I say partially because there is still a little bit of blank
space around a maximized window.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Fix genlist crash issue of T2553 which happened by dangling pointer
access after deletion in item_select.
after item_focused callback, user call deletion and item_select din't
cover those cases.
Resolves: T2553
@fix
Test Plan: elementary_test -> genlist focus -> choose Genlist Cear on Focus
then originally crash will be happened. This patch will solve that problem.
Summary:
If x coordinate is equal to 0, key action is no more
effective as EINA_FALSE is returned. This is creating problem
in looping. Looping will be done when x < 0, but as soon as
x == 0, _key_action_move starts returning EINA_FALSE. Same
thing applies to y coordinate and other extremities.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan: elementary_test -> Scroller -> Loop in X axis -> scroll left using left key(looping does not happen)
Reviewers: raster, Hermet, cedric, singh.amitesh, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: sachin.dev, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2778
Title icon of popup is not getting shown.
steps to reproduce:
1. elementary_test -to "popup"
2. click "popup bottom title + text + 3 buttons"
In the test popup example, the initial parent of icon is popup.
The title_icon is reset to null while adjusting elm parent from popup
to main_layout (elm_widget_sub_object_add which calls sub_object_del of popup)
on swallowing icon to main_layout.
Resolves: T2581
@fix
Summary: This patch fixes opaque region setting under wayland in a
more proper/accurate way. This now sets the opaque region to be Just
what is visible (ie: only the dialog).
NB: This does not actually fix T2575 as that problem is inside E itself.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: Elementary does not support toggling of shadows on windows,
but Enlightenment does so we need to use the proper program signal for
that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fixes T2575 more accurately (combined with previous
theme adjustments). Previous code would use a spacer object to help
calculate window opaque region. This is no longer necessary due to the
previous theme changes, and now calculates window opaque region to
coincide with what Enlightenment is expecting.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fix addresses the issue of Elementary's Wayland border
theme not match close enough to E's. Now they are very much identical
with the exception of the program and signal names.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This adjusts the focus frame of Elementary applications to
more closely match what is done in X11. T2575 says that the focus
rectangle was larger than expected by a few pixels, so this slight
adjustment compensates for that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Changed the docs of elm_bubble.eo and elm_button.eo to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2827
Without this, apps can't set a GLView to be in COPY mode.
COPY mode allows the glview to "poke holes" in the backbuffer of
the window, without the need for other objects below (eg. a
transparent rectangle in COPY mode).
Summary:
Converted docs of elm_bg.eo to new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Differential Revision: https://phab.enlightenment.org/D2819
Summary:
Converted docs of elm_app_server.eo and elm_app_server_view.eo to
new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2816
Summary:
Converted docs of elm_app_client.eo and elm_app_client_view.eo to
new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2814
The issue was introduced in 28e6878f7cce36efae1438b5e032eb9c0878016a.
While this is a fix in the sense that it reverts to the previously
defined behaviour (defined both in docs and code), the previous
behaviour was stupid and inconsistent. So now we are back to stupid and
inconsistent.
I can't fix this further, because unfortunately, the fix requires
intrusive changes that are just too dangerous to make this late in the
release cycle. Luckily for us, the issues only surface in a very
specific case that is quite uncommon. In order to trigger the bug you
need to set a very long piece of text on an entry that has text filters
set.
Fixes T2561
@fix
In most cases the code would not crash (I can't understand why),
but in some cases Eo would complain about call stack overflow.
Yep, that's a lot of recursive calls.
The mouse_down callback was trying to cancel its triggering
event and then send again the same mouse_down event. Why? I guess
because it was easier that also having a callback for move (drag
the colorselector arrows). Ugly...
This widget is in dire need for some love.