Several APIs are marked as not documented simply because the doxygen
documentation mentions a parameter named "foo" while the spelling in the
prototype is something like "fooh". An example correction is
- * @param fsize Finger size
+ * @param sz Finger size
Nothing very complicated and there are also a couple typo fixes I noticed
while going over the files.
In some cases, like having a drop target inside an inwin (looks like it
can be other containers too) can cause an infinite loop (as described in
the report). The reason for that is that while the drop target was added
when there was an X window available, the X window ws now gone, so the
non X path was being called which didn't have the code to remove the
item from the list being iterated. Yes, definition of spaghetti and
false assumptions.
Elm dnd/cnp need a massive overhaul, they are disgusting.
See the ticket for more information on the issue.
Fixes T1702
Before screaming "don't expose this", here's the reasoning:
There will be a few new APIs in evas-gl (support pbuffer, ...)
that require a pointer to the Evas_GL to be called. So, instead
of exposing each and every one of these evas gl functions in
a dummy wrapper in elm_glview, we just give access to the real
pointer.
GLView will always be a wrapper around evas_gl, because that's
what it is by definition.
Summary:
if translatable is FALSE and _translate_string_data_get returns NULL, ts
would be NULL which results into crash.
@fix
Reviewers: seoz, raster, Hermet
Reviewed By: Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1543
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
Summary:
There were wrong checkings in elm_win_size_base_get and
elm_win_size_step_get
@fix
Reviewers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1533
Summary:
Since the sd->image is swallowed to the edje object, it's position and size will be managed by edje smart object.
in the bg side, it doesn't need to care the position and size of the image.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1525
Summary: First page's number is 0. So I changed '+' to '-'.
Reviewers: seoz, jaehwan, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1530
Summary:
When fileselector is opened, it would be nice to be able to provide initial filename.
Like "Untitled Document" in Gedit, when save for the first time.
More details in Gedit,
Gedit provies default name, "Untitled Document" and does not change default name
while navigating directories.
Once we selected any file, Gedit changes value of name entry to selected filename and
it is not also changed while navigating directories.
@feature
Reviewers: seoz, yakov-g
Reviewed By: yakov-g
Subscribers: seoz
Maniphest Tasks: T1664
Differential Revision: https://phab.enlightenment.org/D1504
eo_add()'s counterpart is eo_del, not eo_unref. Regardless of that, some
objects were being double-deleted which spew out some eo errors. These
things should now be fixed.
bc6b6aa457 is the relevant EFL commit.
Summary:
Added this example which demonstrate the exact behavior or "changed" in radio button.
After changing the documentation of "changed" as in https://phab.enlightenment.org/D1445, thought the example might be useful, so added this.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns, stefan_schmidt, seoz
Differential Revision: https://phab.enlightenment.org/D1490
This is a fix upon 6e7686c030fab162edb3128de005ec00ea8c0ffc.
This correctly deletes the list even if the windows are still referenced
and even if they are deleted from under out feets.
Summary:
Setting layer of a smart member is not required as it would remain
on same layer of slider.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1447
This reverts commits 123ca6a8744729525889bbc09ee1aff4b2b97b75, 0d527b03f4f630e81ab4480d7160bbf6352b0bac
this is still unusable even after being fixed so the fix was unnecessary to begin with
Summary:
Right now we cannot have a designated build directory and we should build in the source directory. So the proposed solution lets you to build from any directory.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: raster, cedric
Differential Revision: https://phab.enlightenment.org/D1395
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
ecore_x, ecore_wl, ecore_drm etc. were being linked to clients as they
were added to the pc file - they should not have been. elm hides
these. it's meant to hide them. remove them from the pc file.
Summary:
Changed the text for Radio "changed" event to:
This is called when the radio object is selected.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: stefan_schmidt, seoz
Reviewed By: stefan_schmidt, seoz
Subscribers: stefan_schmidt
Maniphest Tasks: T1657
Differential Revision: https://phab.enlightenment.org/D1445
The scale is used for the application to be scaled.
If the application isn't made on the basis of scale 1.0,
the application layout will be scaled inappositely. So if the
application set the base scale, it is applied when the application is scaled.
this should have been done with the module rename, and this release is the last chance to get it fixed before it has to be permanently maintained with wrong names
This was leading to never enter the cnp functions dedicated to Wayland,
as the given object was not a window. The Copy And Paste test was not
working for this reason.
Summary:
If item select callback is elm_genlist_clear and genlist object have many item, elm_genlist_clear was broken.
This reason is due to incorrect code. In Old code, check the item focus after an item was deleted. So, I changed the order of the code.
Before item was deleted, Check the item focus.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, SanghyeonLee, seoz
Reviewed By: seoz
Subscribers: bluezery, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D1418
I'll reintroduce this in a moment, was just easier this way in order to
merge Vincent's changes.
This reverts commit d46fa601ef45d579d1448b19887d02ff2dfbb576.
Summary:
Label size is incorrectly calculated (text does not wrap) if
elm_label_line_wrap_set() is called before elm_label_wrap_width_set().
@fix
Test Plan:
The label3 test case is added to show the bug case.
In label3 test case, if we switch the calling sequence of
elm_label_line_wrap_set() and elm_label_wrap_width_set(),
the result is different.
Reviewers: raster, seoz, woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D1369
Summary: Removed all global variables for item class
Reviewers: zmike, raster, seoz
Maniphest Tasks: T1482
Differential Revision: https://phab.enlightenment.org/D1318
Summary:
If gengrid select mode is not ELM_OBJECT_SELECT_MODE_ALWAYS, ELM_OBJECT_SELECT_MODE_ALWAYS mode for
elm_genlist_item_select_mode was broken. In the item select routine, item mode(it->mode) was not checked.
So, I added the check routine there.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: SanghyeonLee, bluezery
Differential Revision: https://phab.enlightenment.org/D1372
This completely breaks automatic UI mirroring. The code there was
correct. Please, before removing code, contact the original author and
make sure you don't break things down. Especially if your reason for
removing is "this doesn't make sense to me" instead of "this breaks X
Y."
This reverts commit 24983fed239a3b37c05cc3c65ed9c56953a7176b.
thre are still all the old engines supported inside, but docs dont say
so so effectively deprecated. also handle a NULL engine. this is part
of our engine/display system cleanup.