forked from enlightenment/efl
df304d0155
Before screaming in horror (C++...) here's why we may need this: Efl.Part.part API returns an object that is by definition valid for a single function call only. Enforcing this in practice is actually quite hard as all implementation functions must manually take care of the life-cycle. This is a lot of code in many places and a lot of opportunities to forget to properly handle that life-cycle. Also, this means any invalid function call on a part will leak an object. This API absolutely must remain either "internal" or "beta" and definitely not become abused by applications. On top of that such an API can cause great trouble for bindings like C++. As a consequence, only specially crafted APIs like efl_part() should return an object marked as auto_unref. Alternatively this API could be defined in Eo.h or some other Eo_Internal.h. I placed it in efl_object.eo because it's much more convenient :) (read: I'm lazy) **** Performance notes: Tested with clang & gcc (with -O2), I had a look at the output of perf top, in particular the asm view. I used eo_bench in a loop. My conclusions are: - EINA_LIKELY/UNLIKELY actually works. The jump statement varies according to the expectation. I highly doubt all those ugly goto in eo.c / Eo.h are even useful. - The impact of auto_unref on a call_resolve is so small it doesn't even appear in the trace. It is significant inside call_end, though (obviously, that function is just a few lines long). That function accounts for ~1% to ~4% of all CPU time. The impact of auto_unref in call_end is ~4% of the function time. This means ~0.16% of all CPU time (worst measured case). _efl_object_op_api_id_get simply doesn't show up because of caching, so the extra check there is negligible. PS: I also tested EINA_LIKELY/UNLIKELY by compiling with -O2 and looking at the output with objdump. The flag is well respected, and the jump instructions are what you would expect (no jump for LIKELY and jump for UNLIKELY). Conclusion: The goto's in eo.c only make the code harder to read... |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| eo_error_msgs.c | ||
| eo_error_msgs.h | ||
| eo_suite.c | ||
| eo_suite.h | ||
| eo_test_call_errors.c | ||
| eo_test_class_behaviour_errors.c | ||
| eo_test_class_errors.c | ||
| eo_test_class_simple.c | ||
| eo_test_class_simple.h | ||
| eo_test_class_singleton.c | ||
| eo_test_class_singleton.h | ||
| eo_test_domain.c | ||
| eo_test_domain.h | ||
| eo_test_event.c | ||
| eo_test_general.c | ||
| eo_test_init.c | ||
| eo_test_threaded_calls.c | ||
| eo_test_value.c | ||