forked from enlightenment/efl
46acbce93e
Subject: Patch to address some focus and disabling issue in elementary widgets We have observed some generic issues in Elementary widgets. 1. Widgets not getting disabled if we call elm_object_disabled_set(ob, EINA_TRUE) followed by elm_object_style_set(obj, <style_name>); This works fine if we disable the widget after changing the style(call to theme_hook happens here). It happens because we are not sending the edje signal in theme_hook of the widgets, if the widget is already in disabled state. I have added this code in theme_hook of elm_button as an example and we will need to apply the similar stuff in all other widgets if needed. 2. The widget gets focused in a particular scenario even though we call elm_object_focus_allow_set(obj, EINA_FALSE). The code snippet to explain the scenario which we observed was like this: Evas_Object *button = NULL, *icon = NULL; button = elm_button_add(parent); elm_object_focus_allow_set(button, EINA_FALSE); icon = elm_icon_add(button); elm_icon_file_set(icon, EDJE_PATH, "test.icon"); elm_button_icon_set(button, icon); An icon object does not take focus by default. But still whenever the focus returned to the parent(layout in this case) after closing some popup, the button gets focused though we had disabled it explicitly. The reason is in this case, when we call elm_icon_add(button), icon gets added to button as a sub-object and in this call, we set sd->child_can_focus for button(the parent) as true because till now, the focus property for icon has not been set to false which by default is true. This was set later in the function elm_icon_add() as follows: elm_widget_can_focus_set(obj, EINA_FALSE); Actually this should be set before adding icon as sub-object of the parent which in this case is a button. I have done the required modification in the function elm_icon_add(). Attached to this mail is the patch file for these two issues.The revision from which I have created this patch file is 53129. We may need to do similar changes in other widgets if required. SVN revision: 53137 |
||
|---|---|---|
| .. | ||
| Elementary.h.in | ||
| Elementary_Cursor.h | ||
| Makefile.am | ||
| elc_anchorblock.c | ||
| elc_anchorview.c | ||
| elc_fileselector.c | ||
| elc_fileselector_button.c | ||
| elc_hoversel.c | ||
| elc_notepad.c | ||
| elc_scrolled_entry.c | ||
| elm_animator.c | ||
| elm_bg.c | ||
| elm_box.c | ||
| elm_bubble.c | ||
| elm_button.c | ||
| elm_calendar.c | ||
| elm_carousel.c | ||
| elm_check.c | ||
| elm_clock.c | ||
| elm_cnp_helper.c | ||
| elm_config.c | ||
| elm_conform.c | ||
| elm_entry.c | ||
| elm_flip.c | ||
| elm_flippicker.c | ||
| elm_frame.c | ||
| elm_gengrid.c | ||
| elm_genlist.c | ||
| elm_hover.c | ||
| elm_icon.c | ||
| elm_image.c | ||
| elm_index.c | ||
| elm_label.c | ||
| elm_layout.c | ||
| elm_list.c | ||
| elm_main.c | ||
| elm_map.c | ||
| elm_mapbuf.c | ||
| elm_menu.c | ||
| elm_module.c | ||
| elm_notify.c | ||
| elm_pager.c | ||
| elm_panel.c | ||
| elm_panes.c | ||
| elm_photo.c | ||
| elm_photocam.c | ||
| elm_priv.h | ||
| elm_progressbar.c | ||
| elm_radio.c | ||
| elm_scroller.c | ||
| elm_separator.c | ||
| elm_slider.c | ||
| elm_slideshow.c | ||
| elm_spinner.c | ||
| elm_table.c | ||
| elm_theme.c | ||
| elm_thumb.c | ||
| elm_toggle.c | ||
| elm_toolbar.c | ||
| elm_widget.c | ||
| elm_widget.h | ||
| elm_win.c | ||
| els_box.c | ||
| els_box.h | ||
| els_cursor.c | ||
| els_icon.c | ||
| els_icon.h | ||
| els_pan.c | ||
| els_pan.h | ||
| els_scroller.c | ||
| els_scroller.h | ||
| els_tooltip.c | ||