kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
efl/src/lib/ecore
History
Carsten Haitzler a57c7f7510 Revert command line array object because it's broken by design 
Revert "ecore: get rid of commands in efl_task."
  This reverts commit 616381e9cf.
Revert "ecore: here comes a command line object"
  This reverts commit 48e5684b3c.

1. this is broken:

EOLIAN static const char*
_efl_core_command_line_command_get(const Eo *obj EINA_UNUSED, Efl_Core_Command_Line_Data *pd)
{
   return eina_strdup(pd->string_command);
}

it returns a const char * BUT it duplicates it on return. no. a big
fat honking NO. return a char * or don't duplicate. pick.

2. _efl_core_command_line_command_array_set() is broken by design. it
accepts an array of strings, but the strings are owned by the caller
who creates the array (requiring they free them up themselves after
this call) but the array becomes owned by the callee. the code here frees the
incoming array but doesn't care about the string content of it. it's
leak heaven waiting to happen (or bugs when someone wants to access
the array they create to walk it to free the strings they put into it
after it is set).

i brought this up and it was dismissed. now exactly he issue i brought
up is there with mixed ownership and the added complexity as well as
transfer of some ownership but not others.

go back and think about this so it isn't broken by design.
 		2019-02-12 19:54:35 +00:00
..
Ecore.h
…
Ecore_Common.h docs: Fix assorted typos in legacy documentation 2019-01-28 13:14:20 +01:00
Ecore_Eo.h Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
Ecore_Getopt.h
…
Ecore_Legacy.h doc: remove since_tizen. 2018-12-06 14:41:51 +09:00
Efl_Core.h
…
ecore.c
…
ecore_alloc.c
…
ecore_anim.c ecore: remove duplicated conditions 2018-10-26 19:25:09 +09:00
ecore_app.c
…
ecore_event_message.c
…
ecore_event_message.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
ecore_event_message_handler.c
…
ecore_event_message_handler.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
ecore_events.c
…
ecore_exe.c
…
ecore_exe.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
ecore_exe_posix.c
…
ecore_exe_private.h
…
ecore_exe_ps3.c
…
ecore_exe_win32.c
…
ecore_getopt.c
…
ecore_glib.c
…
ecore_idle_enterer.c
…
ecore_idle_exiter.c
…
ecore_idler.c
…
ecore_internal.h
…
ecore_job.c ecore: remove duplicated conditions 2018-10-26 19:25:09 +09:00
ecore_main.c
…
ecore_main_common.h
…
ecore_main_timechanges.c
…
ecore_pipe.c
…
ecore_poller.c ecore: remove duplicated conditions 2018-10-26 19:25:09 +09:00
ecore_private.h efl_task: remove env from this object 2019-02-12 11:19:28 +01:00
ecore_signal.c ecore: check fcntl return. 2019-01-29 19:30:45 +09:00
ecore_thread.c ecore thread - fix warn - callback prototypes to match correct type 2018-11-09 11:43:59 +00:00
ecore_throttle.c
…
ecore_time.c
…
ecore_timer.c
…
efl_accelerate_interpolator.c efl_interpolator: rename subclasses of Efl.Interpolator 2018-11-23 21:44:34 +09:00
efl_accelerate_interpolator.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_app.c efl_task: remove efl.io.* interfaces 2019-01-25 13:47:21 -06:00
efl_app.eo Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_appthread.c
…
efl_appthread.eo Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_boolean_model.c efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_boolean_model.eo efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_bounce_interpolator.c efl_interpolator: rename subclasses of Efl.Interpolator 2018-11-23 21:44:34 +09:00
efl_bounce_interpolator.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_composite_model.c efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_composite_model.eo efl: Change non required constructors to @optional. 2019-02-07 18:05:00 +01:00
efl_composite_model_private.h efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_container_model.c efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_container_model.eo efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_container_model_item.c efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_container_model_item.eo efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_container_model_private.h efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_core_env.c efl_task: remove env from this object 2019-02-12 11:19:28 +01:00
efl_core_env.eo ecore: here comes a env object 2019-02-12 11:19:28 +01:00
efl_core_proc_env.c ecore: here comes a env object 2019-02-12 11:19:28 +01:00
efl_core_proc_env.eo ecore: here comes a env object 2019-02-12 11:19:28 +01:00
efl_cubic_bezier_interpolator.c efl_interpolator: rename subclasses of Efl.Interpolator 2018-11-23 21:44:34 +09:00
efl_cubic_bezier_interpolator.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_decelerate_interpolator.c efl_interpolator: rename subclasses of Efl.Interpolator 2018-11-23 21:44:34 +09:00
efl_decelerate_interpolator.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_divisor_interpolator.c efl_interpolator: rename subclasses of Efl.Interpolator 2018-11-23 21:44:34 +09:00
efl_divisor_interpolator.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_exe.c Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_exe.eo Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_general.h
…
efl_generic_model.c efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_generic_model.eo efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_io_buffered_stream.c Make Efl.Ui.Closer an interface instead of mixin 2019-01-17 13:59:57 -05:00
efl_io_buffered_stream.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_io_closer_fd.c
…
efl_io_closer_fd.eo efl: refactor all mixins 2019-01-11 12:37:27 +01:00
efl_io_copier.c Make Efl.Ui.Closer an interface instead of mixin 2019-01-17 13:59:57 -05:00
efl_io_copier.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_io_file.c
…
efl_io_file.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_io_positioner_fd.c
…
efl_io_positioner_fd.eo efl: convert all mixins to new eolian syntax 2019-01-18 16:31:28 +01:00
efl_io_reader_fd.c
…
efl_io_reader_fd.eo efl: convert all mixins to new eolian syntax 2019-01-18 16:31:28 +01:00
efl_io_sizer_fd.c
…
efl_io_sizer_fd.eo efl: convert all mixins to new eolian syntax 2019-01-18 16:31:28 +01:00
efl_io_stderr.c
…
efl_io_stderr.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_io_stdin.c
…
efl_io_stdin.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_io_stdout.c
…
efl_io_stdout.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_io_writer_fd.c
…
efl_io_writer_fd.eo efl: convert all mixins to new eolian syntax 2019-01-18 16:31:28 +01:00
efl_linear_interpolator.c efl_interpolator: rename subclasses of Efl.Interpolator 2018-11-23 21:44:34 +09:00
efl_linear_interpolator.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_loop.c Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_loop.eo efl_task: remove env from this object 2019-02-12 11:19:28 +01:00
efl_loop_consumer.c ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data. 2019-01-16 14:33:26 -08:00
efl_loop_consumer.eo docs: Add links to Efl.Loop_Consumer 2019-01-30 16:16:37 +01:00
efl_loop_fd.c
…
efl_loop_fd.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_loop_handler.c
…
efl_loop_handler.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_loop_message.c
…
efl_loop_message.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_loop_message_future.c
…
efl_loop_message_future.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_loop_message_future_handler.c
…
efl_loop_message_future_handler.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_loop_message_handler.c
…
efl_loop_message_handler.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_loop_model.c efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_loop_model.eo efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_loop_timer.eo Efl.Loop.Timer.interval is a constructor property 2019-01-19 18:04:14 +01:00
efl_model_accessor_view.c
…
efl_model_accessor_view_private.h
…
efl_select_model.c efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_select_model.eo efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_sinusoidal_interpolator.c efl_interpolator: rename subclasses of Efl.Interpolator 2018-11-23 21:44:34 +09:00
efl_sinusoidal_interpolator.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_spring_interpolator.c efl_interpolator: rename subclasses of Efl.Interpolator 2018-11-23 21:44:34 +09:00
efl_spring_interpolator.eo efl: convert all classes to the new eolian syntax 2019-01-18 16:31:26 +01:00
efl_task.c Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_task.eo Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_thread.c Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_thread.eo Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00
efl_threadio.c
…
efl_threadio.eo
…
efl_view_model.c efl_model : rename all efl_model based classes. 2019-01-31 14:59:37 +09:00
efl_view_model.eo efl: Change non required constructors to @optional. 2019-02-07 18:05:00 +01:00
meson.build Revert command line array object because it's broken by design 2019-02-12 19:54:35 +00:00