forked from enlightenment/efl
4c89d5021b
Summary:
When there is circular dependency in edc, a bunch of CRI log is printed.
This patch fixes it.
```
ERR<10159>:edje lib/edje/edje_calc.c:3919 _edje_part_recalc() Circular dependency in the group 'test' : longpartname -> longpartname -> longpartname2
ERR<10159>:edje lib/edje/edje_calc.c:3896 _edje_part_recalc() Circular dependency when calculating part "longpartname". Already calculating XY [03] axes. Need to calculate Y [02] axes
CRI<10159>: lib/eina/eina_share_common.c:559 _eina_share_common_node_from_str() *** Eina Magic Check Failed at 0x7fb7c93ebf60 !!!
Input handle is wrong type.
Expected: 98761254 - Eina Stringshare Node
Supplied: 2f736e6f - (unknown)
CRI<10159>: lib/eina/eina_share_common.c:559 _eina_share_common_node_from_str() *** Eina Magic Check Failed at 0x7fb7c93ec5d1 !!!
Input handle is wrong type.
Expected: 98761254 - Eina Stringshare Node
Supplied: 5f747261 - (unknown)
```
If string is already stored, `eina_stringshare_add` increase its reference count.
Test Plan:
test.c
```
//edje_cc test.edc && gcc -o test test.c `pkg-config --libs --cflags elementary`
#include <Elementary.h>
int main(int argc, char **argv)
{
elm_init(argc, argv);
Evas_Object *win = elm_win_util_standard_add("test", "test");
Evas_Object *layout = elm_layout_add(win);
elm_layout_file_set(layout, "./test.edj", "test");
elm_win_resize_object_add(win, layout);
evas_object_show(layout);
evas_object_resize(win, 200, 200);
evas_object_show(win);
elm_run();
elm_shutdown();
return 0;
}
```
test.edc
```
collections {
group { name: "test";
parts {
rect { name: "longpartname";
desc { "default";
rel1.to: "longpartname2";
}
}
rect { name: "longpartname2";
type: RECT;
desc { "default";
rel2.to: "longpartname";
}
}
}
}
}
```
Reviewers: SanghyeonLee, zmike
Reviewed By: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8717
|
||
|---|---|---|
| .. | ||
| Edje.h | ||
| Edje.hh | ||
| Edje_Common.h | ||
| Edje_Edit.h | ||
| Edje_Eo.h | ||
| Edje_Legacy.h | ||
| edje_box_layout.c | ||
| edje_cache.c | ||
| edje_calc.c | ||
| edje_callbacks.c | ||
| edje_convert.c | ||
| edje_convert.h | ||
| edje_data.c | ||
| edje_edit.c | ||
| edje_edit_eo.c | ||
| edje_edit_eo.h | ||
| edje_edit_eo.legacy.h | ||
| edje_embryo.c | ||
| edje_entry.c | ||
| edje_external.c | ||
| edje_global.eo | ||
| edje_legacy.c | ||
| edje_load.c | ||
| edje_lua.c | ||
| edje_lua2.c | ||
| edje_lua_script_only.c | ||
| edje_main.c | ||
| edje_match.c | ||
| edje_message_queue.c | ||
| edje_misc.c | ||
| edje_module.c | ||
| edje_multisense.c | ||
| edje_part.c | ||
| edje_part_box.c | ||
| edje_part_external.c | ||
| edje_part_helper.h | ||
| edje_part_invalid.c | ||
| edje_part_swallow.c | ||
| edje_part_table.c | ||
| edje_part_text.c | ||
| edje_private.h | ||
| edje_program.c | ||
| edje_signal.c | ||
| edje_smart.c | ||
| edje_text.c | ||
| edje_textblock.c | ||
| edje_textblock_styles.c | ||
| edje_types.eot | ||
| edje_util.c | ||
| edje_var.c | ||
| efl_canvas_layout.eo | ||
| efl_canvas_layout_eo.legacy.c | ||
| efl_canvas_layout_eo.legacy.h | ||
| efl_canvas_layout_part.eo | ||
| efl_canvas_layout_part_box.eo | ||
| efl_canvas_layout_part_external.eo | ||
| efl_canvas_layout_part_invalid.eo | ||
| efl_canvas_layout_part_swallow.eo | ||
| efl_canvas_layout_part_table.eo | ||
| efl_canvas_layout_part_text.eo | ||
| efl_layout_calc.eo | ||
| efl_layout_group.eo | ||
| efl_layout_group_eo.legacy.c | ||
| efl_layout_group_eo.legacy.h | ||
| efl_layout_signal.eo | ||
| meson.build | ||