Commit Graph

460 Commits

Author SHA1 Message Date
Michael Jennings 5d475d0105 src/*.c, Eterm.spec: Various build fixes
Several changes here to make it build on RHEL/CentOS 8:
 - Replace outdated MEMSET() macro with (g)libc memset()
 - Update Release field to use `git describe` just like LibAST
 - Fix `make distcheck` by adding an uninstall-hook for src/gdb.scr
 - At long last, remove the ancient RPM %changelog content
 - Fix incompatibility with my traditional choices for CFLAGS
   (-O0 -g3) and modern RHEL security/hardening goop which, due to
   being implemented in the GCC optimizer, is rendered non-functional
   by building with -O0!
 - Rename backgrounds tarball so that it doesn't have the Eterm
   version in its name since, shockingly, it never changes based on
   the version of Eterm!
2020-02-28 17:06:54 -07:00
Michael Jennings 557e0c7a1d Fix possible uninitialized variable usage caught by David Binderman <dcb314@hotmail.com>. 2014-10-24 17:59:17 -07:00
Boris Faure 4b35c31087 fix infinite loop while closing file descriptor when too many available 2014-07-29 20:32:47 +02:00
Michael Jennings 31233f31d8 Patch from Pavel Sanda <ps@ucw.cz> to fix copy/paste behavior with
some Qt-based apps (e.g., LyX).
2014-03-26 09:00:45 -07:00
Mike Frysinger 4b79984674 eterm: add GNU stack markings to mmx asm code to avoid implicitly enabling executable stacks
https://bugs.gentoo.org/440618

SVN revision: 78911
2012-11-05 08:03:46 +00:00
Boris Faure c8cd7d1824 remove .cvsignore files
SVN revision: 60246
2011-06-12 21:38:37 +00:00
Michael Jennings 21375413fa Tue Mar 15 23:08:26 2011 Michael Jennings (mej)
Fix for CVE-2011-0768, an off-by-one error in handling large pixmap
filenames which resulted in an overflow of a single NUL character if
the filename exceeded PATH_MAX bytes.  This bug is NOT exploitable.
Again, thanks to Jonathan Brossard and the team at Toucan System for
responsibly disclosing this vulnerability and to CERT for assisting
with coordination and disclosure.
----------------------------------------------------------------------


SVN revision: 59414
2011-05-15 21:24:19 +00:00
Michael Jennings e096c4df0f Tue Mar 15 23:03:57 2011 mej
Fix for CVE-2011-0409 (CERT VU#285156), a use-after-free error in the
XIM code.  This only affects versions where XIM support is compiled in
(which it is by default).  There are no known exploits for this bug,
but it is theoretically exploitable.  Thanks to Jonathan Brossard and
the team at Toucan System for responsibly disclosing this
vulnerability and to CERT for assisting with coordination and
disclosure.
----------------------------------------------------------------------


SVN revision: 59413
2011-05-15 21:19:59 +00:00
Lucas De Marchi 369e95c1df Revert and re-apply badnull patch
Revert previous patch generated by badnull.cocci script, and apply the new one.
The main difference is that assert and assert-like functions are not touched
anymore.




SVN revision: 51650
2010-08-26 01:34:13 +00:00
Michael Jennings d3bb74d029 Revert coccinelle changes.
Using !! instead of != NULL results in significantly and unacceptably
less readable code, and I refuse to accept those changes.
Unfortunately, since they were all done at once, I have to revert the
whole thing.  Oh well. :(


SVN revision: 51583
2010-08-23 17:55:09 +00:00
Lucas De Marchi 3f375e63e2 Convert (hopefully) all comparisons to NULL
Apply badzero.cocci, badnull.coci and badnull2.cocci

This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:

code before patch               ||code after patch
===============================================================

return a == NULL;                 return !a;

return a != NULL;                 return !!a;

func(a == NULL);                  func(!a);

func(a != NULL);                  func(!!a);

b = a == NULL;                    b = !a;

b = a != NULL;                    b = !!a;

b = a == NULL ? c : d;            b = !a ? c : d;

b = a != NULL ? c : d;            b = a ? c : d;


other cases:

a == NULL                         !a
a != NULL                         a




SVN revision: 51487
2010-08-21 13:52:25 +00:00
Kim Woelders c81f5795de Eliminate use of Xmu.
This causes the following change:
In script.c and term.c XA_CLIPBOARD(Xdisplay) used to expand to
XA_PRIMARY, i.e. the identifier of the "PRIMARY" atom, now it will
be the identifier of the "CLIPBOARD" atom.

SVN revision: 50969
2010-08-10 18:08:44 +00:00
Michael Jennings 8f2dd859a6 Sun Aug 8 16:32:44 2010 Michael Jennings (mej)
Modified patch from Paolo Ferrario <skooks@tiscali.it> based on input
from Kim Woelders <kim@woelders.dk> to allow Eterm to respond to
selection requests in UTF-8, compound text, or string only.
Previously, exotic selection request types would receive a string
back, but it would claim to be whatever type was requested.  Now it
claims to be a string, which is probably more correct.  This should
also eliminate server round-trips when clients ask for UTF-8, get a
string, then ask for a string (Opera).
----------------------------------------------------------------------


SVN revision: 50916
2010-08-08 23:37:54 +00:00
Michael Jennings d9da90c06d Thu Nov 12 22:11:49 2009 Michael Jennings (mej)
Additional debugging and proper bracing.
----------------------------------------------------------------------


SVN revision: 43652
2009-11-13 06:11:52 +00:00
Michael Jennings 10842b025d Sun Oct 25 14:07:07 2009 Michael Jennings (mej)
Fix off-by-one error that was causing crashes with visual bell.  Found
by d_willsc@cojobo.bonn.de.
----------------------------------------------------------------------


SVN revision: 43285
2009-10-25 21:07:43 +00:00
Michael Jennings 7dea24910a Sun Oct 25 14:02:14 2009 Michael Jennings (mej)
Revert bad change to borderless code.  We're now doing best effort
borderless with no override_redirect (which may come back some day as
a separate option if there's a need) based on advice from raster and
kwo.
----------------------------------------------------------------------


SVN revision: 43284
2009-10-25 21:03:18 +00:00
Michael Jennings f4494790e2 Sun Oct 25 13:52:40 2009 Michael Jennings (mej)
Support font effects in 8 directions.  Patch supplied by Joern
Bernhardt <Joern.Bernhardt@gmx.net>.
----------------------------------------------------------------------


SVN revision: 43283
2009-10-25 20:53:47 +00:00
Michael Jennings e59a5a4e95 Sun Oct 25 12:39:34 2009 Michael Jennings (mej)
Fix for scrolling limitations from Cliff Miller <cbm@whatexit.org>.
----------------------------------------------------------------------


SVN revision: 43282
2009-10-25 20:33:35 +00:00
Michael Jennings 42a135456a Sun Oct 25 12:36:01 2009 Michael Jennings (mej)
Patch for FreeBSD UNIX98 pty support from Ed Schouten <ed@80386.nl>.
----------------------------------------------------------------------


SVN revision: 43281
2009-10-25 20:30:06 +00:00
Michael Jennings c6ff25f5f1 Sun Oct 25 12:29:32 2009 Michael Jennings (mej)
Re-enable SIGPIPE after fork() for child processes who might not
re-enable it on their own.
----------------------------------------------------------------------


SVN revision: 43280
2009-10-25 20:23:24 +00:00
Michael Jennings c23b7ce6aa Sun Oct 25 12:08:16 2009 Michael Jennings (mej)
Fix some bad replacements.
----------------------------------------------------------------------


SVN revision: 43278
2009-10-25 20:01:27 +00:00
Hannes Janetzek abdb6c1591 break when property was found, fix formatting
SVN revision: 42897
2009-10-06 00:02:16 +00:00
Hannes Janetzek a26cde7b3d check wm supporting hints for mwm:
make borderless also work with window managers that do not pretend to be mwm


SVN revision: 42896
2009-10-05 23:54:53 +00:00
Kim Woelders 07e0c8b22b Yet another attempt to fix selection issues on 64 bit systems.
SVN revision: 41918
2009-08-21 16:50:52 +00:00
Mike Frysinger 05997662cd add patch from fedora to try and fix qt copy & paste problems on 64bit systems
SVN revision: 41896
2009-08-20 18:40:47 +00:00
Mike Frysinger 652f8f3a86 do not redefine _GNU_SOURCE if configure already set it up for us
SVN revision: 41895
2009-08-20 18:38:38 +00:00
Mike Frysinger 8ed6bd1597 drop NETDISP_IDENT since netdisp.c was dropped a while ago
SVN revision: 41894
2009-08-20 18:34:55 +00:00
Michael Jennings f5e3dbacf6 Tue Jan 6 01:08:47 2009 Michael Jennings (mej)
Update copyright dates and fix a bad license.
----------------------------------------------------------------------


SVN revision: 38480
2009-01-06 09:08:48 +00:00
Michael Jennings e53c4775f6 Tue Jan 6 01:03:35 2009 Michael Jennings (mej)
Prevent blank Escreen buttonbar on startup.
----------------------------------------------------------------------


SVN revision: 38479
2009-01-06 09:03:36 +00:00
Michael Jennings 0261bd001b Mon Jan 5 23:50:28 2009 Michael Jennings (mej)
Remove fontset fallbacks.  I think this might help speed up the load
time slowness some people are seeing.  Let's find out.
----------------------------------------------------------------------


SVN revision: 38477
2009-01-06 07:51:15 +00:00
Michael Jennings 9a7cd3adac Tue Dec 16 22:03:54 2008 Michael Jennings (mej)
Fix compile errors related to the removal of unnecessary typecasting
macros.
----------------------------------------------------------------------


SVN revision: 38171
2008-12-17 06:04:15 +00:00
Michael Jennings 883b2660af Wed May 14 16:09:04 2008 Michael Jennings (mej)
(Correct) fix for CVE-2008-1692.  Eterm no longer defaults to using
":0" for $DISPLAY due to the possibility that an attacker can create a
fake X server on a shared system, intercept the Eterm X connection,
and send fake keystrokes to the victim's Eterm to execute arbitrary
commands as that user.

The previous fix, while it did indeed correct the vulnerability, broke
the --display option.  The original fix from Bernhard Link was more
correct, albeit not quite on target.
----------------------------------------------------------------------


SVN revision: 34574
2008-05-14 23:16:54 +00:00
Michael Jennings 1b91d07318 Wed May 14 15:26:13 2008 Michael Jennings (mej)
Patch from Emmanuel Anne <emmanuel.anne@gmail.com> to fix cut/paste
with KDE applications.
----------------------------------------------------------------------


SVN revision: 34573
2008-05-14 22:26:36 +00:00
Michael Jennings c7a352b0c0 Wed May 14 14:54:16 2008 Michael Jennings (mej)
Modified patch from hsim@gmx.li to allow setting of the "Urgent" hint
on beep.
----------------------------------------------------------------------


SVN revision: 34572
2008-05-14 21:54:45 +00:00
Michael Jennings 3df02b2205 Wed May 14 12:42:51 2008 Michael Jennings (mej)
Patch from Kim Woelders <kim@woelders.dk>:

    There is a race problem with Eterm during startup related to the
    shell LINES/COLUMNS env vars.

    If the WM changes the window size (e.g. due to saved settings)
    before mapping the window, sometimes the shell will set LINES and
    COLUMNS according to the old/incorrect size and sometimes to the
    new/correct size, depending on wheter the call to tt_winsize() at
    command.c line 2322 (by the shell child process) or the
    tt_resize() (by the Eterm process) due to the ConfigureNotify
    caused by the resize (or WM ICCCM ConfigureNotify) operation
    happens first.

The call in question was added by Azundris for Escreen.  So far
Escreen seems to be behaving properly with this patch applied, but all
my Eterm windows (Escreen and otherwise) are pre-sized with -g anyway.
So I'm going to keep my eye on it for awhile.  In case of trouble,
change the "#if 0" to "#ifdef ESCREEN" to revert to previous behavior
when in Escreen mode.  Normal operation should not require the call in
question.
----------------------------------------------------------------------


SVN revision: 34568
2008-05-14 19:49:22 +00:00
Mike Frysinger b9f3a99c56 fix from Nico Golde from Debian for deb bug #473127 and gentoo bug #216833
SVN revision: 34279
2008-04-16 03:23:27 +00:00
Michael Jennings 03ceed41a5 Mon Oct 30 16:11:47 2006 Michael Jennings (mej)
Patch from Jason McCarver <slam@parasite.cc> to support -S/--sticky
option for "sticky" (i.e., present on all desktops) startup.
----------------------------------------------------------------------


SVN revision: 26874
2006-10-30 21:12:12 +00:00
Michael Jennings 3ccf45d5af Wed Oct 18 13:35:18 2006 Michael Jennings (mej)
Fixed a typo and some logic errors in libscream located by Mike
Frysinger <vapier@gentoo.org>.
----------------------------------------------------------------------


SVN revision: 26691
2006-10-18 17:36:10 +00:00
Michael Jennings 517985c4a9 Tue Sep 19 17:07:28 2006 Michael Jennings (mej)
libscream.c is licensed just like Eterm.
----------------------------------------------------------------------


SVN revision: 25979
2006-09-19 21:07:40 +00:00
Michael Jennings a46cf0774d Tue Aug 22 14:07:23 2006 Michael Jennings (mej)
Forgot one.
----------------------------------------------------------------------


SVN revision: 25039
2006-08-22 18:07:32 +00:00
Michael Jennings edf3577888 Fri Aug 18 13:41:14 2006 Michael Jennings (mej)
Addressed licensing concerns.
----------------------------------------------------------------------


SVN revision: 24877
2006-08-18 17:41:19 +00:00
Michael Jennings ddd7611608 Sat Jun 17 23:06:03 2006 Michael Jennings (mej)
Daniel Macks <dmacks@netspace.org> noticed that gdb.scr wasn't being
installed.  Oops.  Fixed now.
----------------------------------------------------------------------


SVN revision: 23491
2006-06-18 03:06:27 +00:00
Michael Jennings 6c1e5b3b6c Fri May 19 16:46:02 2006 Michael Jennings (mej)
Fixed a problem that's been bugging me for ages:  Instead of a
hard-coded delay, wait until we can connect to the ssh forwarding port
before starting the Escreen session via ssh.

Add usleep() to system() wait so as to not peg the CPU while sitting
and spinning.
----------------------------------------------------------------------


SVN revision: 22752
2006-05-19 20:45:42 +00:00
Michael Jennings cc5392df86 Wed May 17 15:42:28 2006 Michael Jennings (mej)
Patch from Kim Woelders <kim@woelders.dk> to optimize transparent
Eterms moved an even multiple of the desktop size (i.e., to another
desktop area).
----------------------------------------------------------------------


SVN revision: 22674
2006-05-17 19:42:39 +00:00
Michael Jennings e7117e77bf Fri Feb 24 16:58:43 2006 Michael Jennings (mej)
Add fallback attempt to open display in case NEED_LINUX_HACK is set
and shouldn't be.
----------------------------------------------------------------------


SVN revision: 20766
2006-02-24 21:58:58 +00:00
Michael Jennings 7537403997 Mon Feb 13 14:51:56 2006 Michael Jennings (mej)
Update to libast 0.6+ API.
----------------------------------------------------------------------


SVN revision: 20440
2006-02-13 19:52:45 +00:00
Michael Jennings fccdc9bb52 Mon Feb 6 17:15:49 2006 Michael Jennings (mej)
DragonFly BSD fixes from Joerg Sonnenberger <joerg@britannica.bec.de>.

Also some type mismatch fixes.
----------------------------------------------------------------------


SVN revision: 20313
2006-02-06 22:16:50 +00:00
Michael Jennings f7397a0611 Mon Feb 6 01:02:15 2006 Michael Jennings (mej)
Fixed paste from clipboard.
----------------------------------------------------------------------


SVN revision: 20304
2006-02-06 06:00:19 +00:00
Michael Jennings 0ae1a05f4b Thu Jan 5 14:50:53 2006 Michael Jennings (mej)
Fixed firewall bounce port checking from 2005-12-05.
----------------------------------------------------------------------


SVN revision: 19542
2006-01-05 19:49:32 +00:00
Michael Jennings b8cf59b892 Wed Jan 4 04:22:13 2006 Michael Jennings (mej)
Update copyright dates.
----------------------------------------------------------------------


SVN revision: 19522
2006-01-04 09:22:41 +00:00