Revert previous patch generated by badnull.cocci script, and apply the new one.
The main difference is that assert and assert-like functions are not touched
anymore.
SVN revision: 51650
Using !! instead of != NULL results in significantly and unacceptably
less readable code, and I refuse to accept those changes.
Unfortunately, since they were all done at once, I have to revert the
whole thing. Oh well. :(
SVN revision: 51583
Apply badzero.cocci, badnull.coci and badnull2.cocci
This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:
code before patch ||code after patch
===============================================================
return a == NULL; return !a;
return a != NULL; return !!a;
func(a == NULL); func(!a);
func(a != NULL); func(!!a);
b = a == NULL; b = !a;
b = a != NULL; b = !!a;
b = a == NULL ? c : d; b = !a ? c : d;
b = a != NULL ? c : d; b = a ? c : d;
other cases:
a == NULL !a
a != NULL a
SVN revision: 51487
Modified patch from hsim@gmx.li to allow setting of the "Urgent" hint
on beep.
----------------------------------------------------------------------
SVN revision: 34572
Patch from Jason McCarver <slam@parasite.cc> to support -S/--sticky
option for "sticky" (i.e., present on all desktops) startup.
----------------------------------------------------------------------
SVN revision: 26874
Merged in previous autoFUCK changes from libast.
Added a feature to specify a command to be run in place of the normal
PC speaker beep.
----------------------------------------------------------------------
SVN revision: 13484
The benefits of being a passenger on a long road trip... The
beginnings of EWMH opacity (a la xcompmgr) support and (hopefully)
UTF-8 support. Both as yet untested.
----------------------------------------------------------------------
SVN revision: 12471
Patch from David Lloyd <dmlloyd@tds.net>. Removed the NO_BRIGHTCOLOR
and NO_BOLDOVERSTRIKE defines. If you want to do NO_BRIGHTCOLOR, set
colors 8-16 the same as 0-7. :P For bold overstrike, it's now an
option (--overstrike-bold). There are also options to deactivate the
"bold" and "blink" attributes' setting of high-intensity colors, and
to allow non-default foreground colors to be bolded.
SVN revision: 7377
I redid the options variables and constants to try and make things
more standardized, and to make room for future toggles as well. This
should make David Lloyd a bit happier, 'cause now we can get his patch
in here. :)
Hopefully I didn't break anything....
SVN revision: 7370
Added bbar_dock and bbar_font directives to escreen context so that
users can alter the dock location and font of the Escreen buttonbar.
This should be it for feature additions and last-minute code changes.
I need to update the docs, but that's about it.
SVN revision: 6433
LibAST 0.5 is now required to build Eterm. Hope everyone updated. By
the way, this fixes that old font-starts-with-a-hyphen bug along with
some compiler warnings the resulted from a change in the way the
ASSERT() macro worked.
SVN revision: 6407
Ran reformat-code on the tree.
Also merged in Azundris' Escreen patch. It's disabled by default for
the moment pending further testing, but you can enable it manually by
defining ESCREEN.
SVN revision: 6202
Several changes here, many of which come from the Debian bug list or
from bug reports on IRC. First off, I believe I've fixed an install
issue with the bg/ directory. I also put an alternative acsc line in
the terminfo file to see if it fixes anything on Debian. (RH works
fine.) I removed the "main" context from all the theme files...which
is something I should've done ages ago, but I forgot.
I made a couple things options which were not previously configurable.
The proportional font thingie which shrank the character cell width is
now the --proportional option. The automatic window gravity on resize
is now the --resize-gravity option. Both are boolean, and both are
documented in the man page.
And finally, I added the kill() function to the script language. At
this point it can only take signals as numbers, but that's good enough
for now.
SVN revision: 4857
There is now a new mechanism for dealing with the background image
collection, including a new update script. Please read the newly-
rewritten bg/README.backgrounds for details.
Also, I'm trying to flesh out the Contributors list in that file, but
my memory isn't cooperating. So if you contributed one of the
backgrounds, or know someone who did, please let me know.
SVN revision: 4810
Okay, first off, I removed 3 scaled backgrounds. See www.kainx.org or
my post to enlightenment-devel for details.
Second, I redid the default bindings for the mouse wheel. Basically,
the wheel alone will scroll by pages. Ctrl+wheel will scroll by pages
in groups of 5. Shift+wheel will scroll by a single line. If you
hold down the Alt key, the same combinations will work the same way,
but instead of scrolling within Eterm, they'll scroll the application
in the terminal (by sending PgUp/PgDn and up/down arrows). This works
in less, bash, and any other application which groks those keys.
I also added a --without-mousewheel option to configure that will turn
off the default scrollwheel bindings. Of course, you can always use
action bindings in the config file to bind/rebind these any way you
like.
While I was at it, I found and fixed a bug in the handling of the
Alt and Meta keys.
I added a scroll() function to the script stuff which allows you to
bind keys/buttons to scroll up and down. While I was at it, I added
comments to script.c for each function you can use.
And finally, the config file parser was moved to libast.
SVN revision: 4806
Moved the HAVE_SAVED_UIDS define into a configure option so that the
FreeBSD folks will have an easier time with it.
Fixed "make distcheck" which broke at some point.
That X stuff in clean_exit() should only happen if we're debugging.
Nobody but me should have to deal with those random hangs. :-)
Added a patch for multibyte cursor support from Michael C. Wu
<keichii@iteration.net> and Sung-Hyun Nam <namsh@lgic.co.kr>, along
with some other FreeBSD-related patches from Mr. Wu.
SVN revision: 4065
VA bought some licenses for Insure++, so I've been using it to audit
Eterm. These are just the initial results of the collaboration; there
will most likely be more. So far things are looking pretty good. I
just wish Insure++ had more helpful messages. I'd really love to be
able to track down those reads/writes involving freed pointers that
it claims to have found in Imlib2....
I also had to try and make the build work without MMX. I did so; I
just hope it still works *with* MMX.... =)
SVN revision: 3895
Since someone wanted it, if no name is given but an exec line (the -e
option) is given, the name defaults to the first word in the exec line
instead of "Eterm-<version>". For example, Eterm -e ssh foo would get
the title "ssh". NOTE: Most Eterm themes already specify a name, so
this will not work with those themes.
SVN revision: 3886
Massive reorganization/rewrite to libmej. It should now be 100%
independent of Eterm. There still may be some gremlins in the memory
debugging code, so don't use too high a number with --debug....
SVN revision: 3282
Two more patches from Marius Gedminas <mgedmin@takas.lt>. The first
one allows for customization of the message displayed when Eterm goes
into pause mode. There are actually two; one goes in the titlebar,
and the other is displayed in the text window.
His second patch makes Eterm's behavior a little smarter when it
resizes itself. It tries to figure out which quadrant of the screen
it's on and resizes in the most appropriate direction. (For example,
Ctrl-GreaterThan on an Eterm in the lower right corner will cause the
upper left corner of the Eterm to move; the lower right corner will
stay put.)
Thanks again to Marius for saving me time by sending patches. :-)
SVN revision: 2912
Marius Gedminas <mgedmin@takas.lt> reported a couple of issues back
when he was on his bug-spotting binge that I didn't have time to fix
just then. Well, now I've fixed them. ~/.Eterm/user.cfg will now
be found if there isn't a theme-specific one; this allows you to have
a single user.cfg which specifies some options you want all your
Eterms to have.
Along those same lines, the action code now searches for duplicate
bindings and changes the existing one rather than adding a new one
to the end of the list. This allows bindings in user.cfg to override
those in theme.cfg (as they should). Also, bindings are added in
reverse order, so newer ones (like in user.cfg) take precedence over
older ones (like in theme.cfg) if there is a conflict (e.g., if your
theme.cfg binds "anymod button2" and user.cfg binds "ctrl button2,"
user.cfg wins).
SVN revision: 2901
Okay, first off I need to thank Marius Gedminas <mgedmin@takas.lt>.
Not only did he point out several issues, he was even willing to send
a patch. :-)
This commit includes Marius' patch which keeps MappingNotify events
from overriding users' modifier settings. It also includes a fix to
a seg fault that he pointed out when menus were loaded without the
menu imageclass having been defined.
He also pointed out that --pause tends to sit and spin, taking up 100%
of the CPU time. Funny how E-Cpu never seemed to get too bent out of
shape over it, but he was indeed correct.
Thus I have fixed it, and while doing so, I have changed the way it
works. It no longer waits for a keypress per se. Actually, it just
ignores the fact that its child went away and keeps right on taking
X events. There are a few exceptions though. Either ESC or Ctrl-C
will exit a paused Eterm. Any other input that doesn't have special
meaning to Eterm will be ignored. (Shift-PgUp and Shift-PgDn still
work however, as do any action bindings you may have.)
SVN revision: 2739
There are now two different sets of settings you can save. You can
save user settings, which are the things that one would generally
consider to be user-specific (toggles, text colors, etc.). You can
also save theme settings, which saves *everything*, including the
stuff that user settings don't include (like imageclasses, menus,
etc.). Settings are saved to user.cfg and theme.cfg, respectively.
Also, Eterm will now detect if it cannot write to the location from
which it got the theme (i.e., a system-wide directory), and will fall
back on ~/.Eterm/themes/<theme>. It WILL create this directory tree
if it does not already exist.
Hopefully this will make more people happy. :-)
SVN revision: 2440
Quick little option -q/--no-input. It keeps Eterm from accepting
keyboard input, and keeps the window manager from focusing it. Useful
for log tailers and such, maybe. This feature was requested by
Peter Ward <than@ilm.com>. I will be adding an escape sequence to
toggle this.
SVN revision: 2398
Added a new option. -0 (that's a zero) or --itrans will invoke the
immotile optimization for transparency, so named because it works best
on windows that don't move around much on the desktop. It works even
better for windows that are sticky between desktops. So if you have
logging windows (running tail -f and the like) that are shaded/tinted,
you definitely want to have this. It will even benefit ordinary Eterm
windows, provided you don't move them around a lot. Eterms that do
not change desktops may be better off with the other way; Eterms that
are not shaded or tinted at all will not behave any differently.
Here's the technical explanation for those who are interested. The
old (and still the default) behavior is for Eterm to check to see if
any color modifiers are applied to the image_bg class, and if so, to
make a copy of the *entire* desktop image which is then shaded/tinted
appropriately. It then snapshots a portion of that for the actual
background. This way, if the Eterm window is moved, all the shading
and tinting will have already been done, so all it has to do is grab
another portion of the desktop and use it. However, this involves a
LOT of calculations (one per pixel of the desktop pixmap) on startup
and at every desktop switch.
The immotile optimization is intended to reverse that logic by
optimizing for windows that do not move (hence the term "immotile").
It takes the snapshot of the desktop pixmap and applies any shading
or tinting *after* taking the portion it needs. This requires much
fewer calculations on startup and when changing desktops, but the
entire set of calculations must be repeated whenever the window is
moved. This is fine for small windows or windows that don't move
very often, but that's not always the case. So it is to your
advantage to pick one or the other depending on how you use each
particular theme or window.
Two notes. One, keep in mind that the -0/--itrans option doesn't
*activate* transparency; you still need -O/--trans for that. Two,
this does not affect Eterms with no color modifiers applied to the
background. In that case, Eterm still references the existing
desktop pixmap to save memory.
SVN revision: 2191
Okay, I've added a new option to configure. --config-buffer-size=NNNN
will set the theme parser's line buffer size. What does this mean?
Well, this determines how big a line being parsed can get at any one
stage of parsing. So if you use %dirscan() on a large directory, or
you use %random() on a large list, or you simply have some very large
lines in your config file, making this buffer size larger will enable
them to be handled. The down side to this is that your Eterms will
appear to take up more memory. In reality they don't, since all that
memory gets freed, but it isn't returned to the OS until Eterm exits,
and the RSS won't go down unless part or all of Eterm is swapped out
by the OS. So you've been warned. :-)
For those who didn't go digging by themselves, what I added yesterday
were three new builtin functions:
%get(variable) Retrieves the value of a theme variable
%put(variable value) Sets the value of a theme variable
%put(variable) Removes a theme variable
%dirscan(directory) Returns a list of the files in a directory
Everything here should be fairly self-explanatory. The variables
are internal to Eterm. They will last until Eterm exits, so you
can refer to them in later theme files, unless of course you call
%put() with a variable but no value (which removes the variable).
Also note that %dirscan() returns only the filenames, not the
full pathnames. This is for two reasons: One, you already know the
path to the file since you specified it. Two, it enables handling of
directories with larger numbers of files since the path isn't
uselessly duplicated for each entry it generates.
These new functions will be the backbone for a new random background
system since the *.list files are rather clumsy in a lot of ways. I
am not yet sure how it will work exactly, but I know I'll need these
functions to do it. :-)
SVN revision: 2104
Fixed a bug in the menu code reported by Sung-Hyun Nam
<namsh@lgic.co.kr>. There's also some new stuff here, but I haven't
tried testing it at *all*, so I'm not prepared to talk about it.
SVN revision: 2093
This is the first public availability of the work thus far on Eterm
0.9.1. There's quite a bit of new stuff here.
* Added scrollbar thumb support.
* Completely redid the terminfo/termcap stuff. The terminfo file is
now compiled (by tic) and installed by default (unless you specify
--without-terminfo). The config files still say xterm, though,
because some programs (like SLang and GNU mc) use the silly algorithm
of "Is $TERM set to xterm?" to detect mouse reporting support in a
terminal. =P But if you don't ever use xterm, you can use Eterm's
termcap and just name it "xterm" instead. Thanks to Marius Gedminas
<mgedmin@takas.lt> for his patch that started this whole revamp.
* Added the kEsetroot script for KDE users from Dax Games
<dgames@isoc.net>.
* You can now configure the Home and End emulation via --with-home=
and --with-end= options to configure. The --with-terminfo option is
also new, and --enable-xim is now the default.
* Added a new image state, disabled, for when Eterm loses focus. This
is supported by all widgets (well, all those that could possibly be
on screen when Eterm lost focus), even the background image. So you
could actually have all your images darken on focus out and restore
to normal on focus in.
* Widget colors formerly dealt with as colors (menu text color,
scrollbar color, etc.) are now handled by the imageclasses. Each
image state can have a foreground and background color defined. The
current exception is the background image; I hope to add that later.
The foreground is the text color and the background is the object
color (for solid color mode). So menu text color is set by the menu
imageclass. And again, for unfocused colors, use the disabled state
of the imageclass.
* Proportionally-spaced fonts are now handled much better. They are
still forced into evenly-spaced columns (it's a terminal for crying
out loud!) but at least you don't end up with Eterm's wider than your
screen. :-)
* Home on refresh is gone, as is home on echo. It's now much simpler.
There are two options: home on output, and home on input, the former
being a combination of echo and refresh. Also, keypresses that don't
necessarily have corresonding output can trigger a home on input,
like Ctrl-End or whatever...ones that don't have special meaning.
Credit to Darren Stuart Embry <dse@louisville.edu> for pointing out
this issue and the one with "m-" in font names.
* I finally got around to re-merging the new parser stuff from my
work on the Not Game. Closed up some old potential behavior quirks
with theme parsing.
* Added a new escape sequence to fork-and-exec a program. Also added
a scrollback search capability to highlight all occurances of a string
in your scrollback buffer. Use the new "Etsearch" utility to access
it. "Etsearch string" to search for a string, then "Etsearch" by
itself to reset the highlighting.
* And of course, the biggie. Eterm now supports a completely-
customizeable buttonbar. Not a menubar, a buttonbar. It can have an
arbitrary number of buttons, and each button can perform an action,
just like a menuitem. So a button could bring up a menu (like a
menubar) or launch a program (like a launchbar) or perform an
operation (like a toolbar). Each button can have an icon, text, or
both. And you can have buttons left- or right-justified in the
buttonbar. You will eventually be able to have an arbitrary number
of buttonbars, but I'm still working on that.
As with any change this big, things could very easily be broken. So
beware. :-) I have tested this myself, and everything seems to work,
but I can't test every possibility. Let me know if you find anything
that's broken, and enjoy!
SVN revision: 2048
I finally got around to implementing double-buffering, although it
seems to still have some issues with font changes. But if you don't
change fonts, it works great. :-)
I also fixed the multibyte font stuff with help from Sung-Hyun Nam
<namsh@lgic.co.kr>. There seem to be some new issues here, though,
with the background pixmap. But I'm to tired to look deeper tonight.
SVN revision: 1588