old
/
legacy-imlib2
3
0
Fork 4
Code Issues 3 Pull Requests Projects Releases Wiki Activity

modules: check for filepath truncation 

also check for (unlikely) snprintf error.
This commit is contained in:
NRK 2022-06-29 03:43:59 +06:00 committed by Kim Woelders
parent 90824fc2fd
commit 581de800b4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/lib/modules.c
View File

@ -159,6 +159,7 @@ __imlib_ModulesList(char **ppath, int *num_ret)
char *
__imlib_ModuleFind(char **ppath, const char *name)
{
int n;
char **pp;
char nbuf[4096];
@ -167,9 +168,9 @@ __imlib_ModuleFind(char **ppath, const char *name)
for (pp = ppath; *pp; pp++)
{
snprintf(nbuf, sizeof(nbuf), "%s/%s.so", *pp, name);
n = snprintf(nbuf, sizeof(nbuf), "%s/%s.so", *pp, name);
if (!__imlib_FileIsFile(nbuf))
if (n < 0 || n >= sizeof(nbuf) || !__imlib_FileIsFile(nbuf))
continue;
return strdup(nbuf);