orbea
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eo: use unref instead of del when constructor fails without parent 

Signed-off-by: Mike Blumenkrantz <zmike@osg.samsung.com>
This commit is contained in:
Cedric BAIL 2018-03-20 13:20:26 -04:00 committed by Cedric Bail
parent db92072338
commit 168849e8a0
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/eo/eo.c
View File

@ -927,7 +927,8 @@ ok_nomatch:
EO_OBJ_POINTER_GOTO_PROXY(eo_id, new_obj, err_newid);
/* We have two refs at this point. */
_efl_unref(obj);
efl_del((Eo *)obj->header.id);
if (parent_id) efl_del((Eo *) obj->header.id);
else _efl_unref(obj);
_efl_ref(new_obj);
EO_OBJ_DONE(eo_id);
}
@ -938,7 +939,8 @@ err_noid:
file, line, klass->desc->name);
/* We have two refs at this point. */
_efl_unref(obj);
efl_del((Eo *) obj->header.id);
if (parent_id) efl_del((Eo *) obj->header.id);
else _efl_unref(obj);
err_newid:
if (parent_id) EO_OBJ_DONE(parent_id);
return NULL;
@ -989,7 +991,8 @@ err_condtor:
}
cleanup:
_efl_unref(obj);
efl_del((Eo *) obj->header.id);
if (efl_parent_get(eo_id)) efl_del((Eo *) obj->header.id);
else _efl_unref(obj);
EO_OBJ_DONE(eo_id);
return NULL;
}