forked from enlightenment/efl
Evas 3d: Initialized local variables
Summary: The OpenGL functions assigns a value to the local variable. However, in case of error it would take the uninitialized garbage value. So, the correct solution would be to initialize it to 0. Signed-off-by: Deepjyoti Dutta <deepjyoti.d@samsung.com> Reviewers: Hermet, singh.amitesh, raster, jpeg Reviewed By: jpeg Subscribers: yashu21985, mvsovani, alok25, sachin.dev, cedric Differential Revision: https://phab.enlightenment.org/D3375
This commit is contained in:
parent
74f7d20441
commit
2a4877a597
|
@ -190,7 +190,7 @@ void _shader_flags_add(E3D_Shader_String *shader, E3D_Shader_Flag flags)
|
||||||
static inline Eina_Bool
|
static inline Eina_Bool
|
||||||
_shader_compile(GLuint shader, const char *src)
|
_shader_compile(GLuint shader, const char *src)
|
||||||
{
|
{
|
||||||
GLint ok;
|
GLint ok = 0;
|
||||||
|
|
||||||
glShaderSource(shader, 1, &src, NULL);
|
glShaderSource(shader, 1, &src, NULL);
|
||||||
glCompileShader(shader);
|
glCompileShader(shader);
|
||||||
|
@ -217,7 +217,7 @@ _shader_compile(GLuint shader, const char *src)
|
||||||
static inline Eina_Bool
|
static inline Eina_Bool
|
||||||
_program_build(E3D_Program *program, const char *vert_src, const char *frag_src)
|
_program_build(E3D_Program *program, const char *vert_src, const char *frag_src)
|
||||||
{
|
{
|
||||||
GLint ok;
|
GLint ok = 0;
|
||||||
|
|
||||||
/* Create OpenGL vertex & fragment shader object. */
|
/* Create OpenGL vertex & fragment shader object. */
|
||||||
program->vert = glCreateShader(GL_VERTEX_SHADER);
|
program->vert = glCreateShader(GL_VERTEX_SHADER);
|
||||||
|
@ -253,7 +253,7 @@ _program_build(E3D_Program *program, const char *vert_src, const char *frag_src)
|
||||||
if (!ok)
|
if (!ok)
|
||||||
{
|
{
|
||||||
GLchar *log_str;
|
GLchar *log_str;
|
||||||
GLint len;
|
GLint len = 0;
|
||||||
GLsizei info_len;
|
GLsizei info_len;
|
||||||
|
|
||||||
glGetProgramiv(program->prog, GL_INFO_LOG_LENGTH, &len);
|
glGetProgramiv(program->prog, GL_INFO_LOG_LENGTH, &len);
|
||||||
|
|
Loading…
Reference in New Issue