From 3a56b3f01391771206c7ee274817a86ca88d38c6 Mon Sep 17 00:00:00 2001 From: Oleksandr Shcherbina Date: Mon, 23 Nov 2015 08:18:51 +0100 Subject: [PATCH] evas: fix uninitialize variable in convex_hull_vertex_set function Summary: A bit of useless claim, becouse parameter coord always have value 0 or 1 or 2. May be for escape problem in future. @fix CID: 1339781 Reviewers: raster, cedric Reviewed By: cedric Differential Revision: https://phab.enlightenment.org/D3349 Signed-off-by: Cedric BAIL --- src/lib/evas/include/evas_3d_utils.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/evas/include/evas_3d_utils.h b/src/lib/evas/include/evas_3d_utils.h index 23d338d448..7c9b34e393 100644 --- a/src/lib/evas/include/evas_3d_utils.h +++ b/src/lib/evas/include/evas_3d_utils.h @@ -1578,7 +1578,7 @@ convex_hull_vertex_set(Evas_Triangle3 *el, unsigned short int *vertex_count, flo unsigned short int **index, unsigned int k, int *leader, int coord) { int color_coords, normal_coords; - Evas_Vec3 vect; + Evas_Vec3 vect = {0}; switch (coord) { case 0: @@ -1904,7 +1904,7 @@ evas_convex_hull_get(float *data, int count, int stride, Eina_Inarray *vertex, on_plain = EINA_FALSE; right = EINA_FALSE; - /* The case when several points are found, is discussed below. + /* The case when several points are found, is discussed below. This case is interesting because the convex hull in the two-dimensional subspace should be filled further */ if ((cos != 1.0) && (1 < eina_array_count(&arr_candidates)))