From 52cf0a49c6da3874367be39f26171449898bf38f Mon Sep 17 00:00:00 2001 From: Yeshwanth Reddivari Date: Tue, 31 Jul 2018 07:29:03 -0500 Subject: [PATCH] region_add: Fix copying wrong rect during smart merge Summary: When testing partial rendering on TV, found this bug. Probably this was caused because of wrong copy/paste. When region1 completely subsumes region2, region2 should be ignored. But currently region2 is copied to region1 which makes region1 rect completly wrong. This was causing lot of visual defects because of wrong rects. This patch will fix those visual defects when partial rendering is enabled. Test Plan: Tested with the patch on TV after enabling partial rendering. Reviewers: raster, cedric, Hermet, ManMower Reviewed By: ManMower Subscribers: bu5hm4n, ajwillia.ms, ManMower, devilhorns, cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6696 --- src/lib/evas/canvas/render2/region.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/lib/evas/canvas/render2/region.c b/src/lib/evas/canvas/render2/region.c index 92da332abd..b7747faf76 100644 --- a/src/lib/evas/canvas/render2/region.c +++ b/src/lib/evas/canvas/render2/region.c @@ -851,10 +851,7 @@ region_add(Region *dest, Region *source) // Region 1 completely subsumes region 2 if (!dest->data && CONTAINS(&dest->bound, &source->bound)) - { - if (dest != source) return region_copy(dest, source); return EINA_TRUE; - } // Region 2 completely subsumes region 1 if (!source->data && CONTAINS(&source->bound, &dest->bound))