orbea
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

edbus codegen: Optimizations 

Use eina_strbuf_string_steal() instead of strdup() +
eina_strbuf_string_get().

Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 82073
This commit is contained in:
José Roberto de Souza 2013-01-03 14:05:56 +00:00 committed by Lucas De Marchi
parent 30a6da0e7f
commit 62676bebb7
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/edbus/parser.c
View File

@ -201,7 +201,7 @@ open_signal(const char *content, unsigned length, Eina_Bool is_open_empty)
eina_strbuf_append_char(buf, toupper(d_signal->name[i])); eina_strbuf_append_char(buf, toupper(d_signal->name[i]));
} }
eina_strbuf_append(buf, "_EVENT"); eina_strbuf_append(buf, "_EVENT");
d_signal->signal_event = strdup(eina_strbuf_string_get(buf)); d_signal->signal_event = eina_strbuf_string_steal(buf);
eina_strbuf_free(buf); eina_strbuf_free(buf);
return r; return r;

11
src/bin/edbus/utils.c
View File

@ -20,7 +20,7 @@ file_read(const char *file_name, char **buffer)
eina_strbuf_append_char(buf, data); eina_strbuf_append_char(buf, data);
fclose(xml_handler); fclose(xml_handler);
*buffer = strdup(eina_strbuf_string_get(buf)); *buffer = eina_strbuf_string_steal(buf);
eina_strbuf_free(buf); eina_strbuf_free(buf);
return EINA_TRUE; return EINA_TRUE;
@ -62,8 +62,7 @@ dbus_name_to_c(const char *dbus)
while ((pch = strtok(NULL, "/."))) while ((pch = strtok(NULL, "/.")))
eina_strbuf_append_printf(buffer, "_%s",pch); eina_strbuf_append_printf(buffer, "_%s",pch);
ret = strdup(eina_strbuf_string_get(buffer)); ret = eina_strbuf_string_steal(buffer);
eina_strbuf_reset(buffer);
for (i = 0; ret[i]; i++) for (i = 0; ret[i]; i++)
{ {
if (i > 0 && ret[i-1] != '_' && ret[i] > '@' && ret[i] < '[')//upper case if (i > 0 && ret[i-1] != '_' && ret[i] > '@' && ret[i] < '[')//upper case
@ -72,7 +71,7 @@ dbus_name_to_c(const char *dbus)
eina_strbuf_append_char(buffer, tolower(ret[i])); eina_strbuf_append_char(buffer, tolower(ret[i]));
} }
free(ret); free(ret);
ret = strdup(eina_strbuf_string_get(buffer)); ret = eina_strbuf_string_steal(buffer);
end: end:
free(str_cpy); free(str_cpy);
eina_strbuf_free(buffer); eina_strbuf_free(buffer);
@ -93,7 +92,7 @@ replace_string(const char *string, const char *substr, const char *replacement)
while ((pch = strtok(NULL, substr))) while ((pch = strtok(NULL, substr)))
eina_strbuf_append_printf(buffer, "%s%s", replacement, pch); eina_strbuf_append_printf(buffer, "%s%s", replacement, pch);
ret = strdup(eina_strbuf_string_get(buffer)); ret = eina_strbuf_string_steal(buffer);
free(str_cpy); free(str_cpy);
eina_strbuf_free(buffer); eina_strbuf_free(buffer);
return ret; return ret;
@ -126,7 +125,7 @@ string_build(const char *fmt, ...)
eina_strbuf_prepend_vprintf(buffer, fmt, ap); eina_strbuf_prepend_vprintf(buffer, fmt, ap);
va_end(ap); va_end(ap);
ret = strdup(eina_strbuf_string_get(buffer)); ret = eina_strbuf_string_steal(buffer);
eina_strbuf_free(buffer); eina_strbuf_free(buffer);
return ret; return ret;