From 90135320d19e0fd1fa188730e925a72e58d72cc6 Mon Sep 17 00:00:00 2001 From: Bowon Ryu Date: Fri, 20 Apr 2018 17:49:44 +0900 Subject: [PATCH] efl_ui_progressbar: add null check Summary: a segmentation fault occurs once the argument is not valid. Test Plan: N/A Reviewers: cedric, Jaehyun_Cho Reviewed By: Jaehyun_Cho Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D5974 --- src/lib/elementary/efl_ui_progressbar.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/lib/elementary/efl_ui_progressbar.c b/src/lib/elementary/efl_ui_progressbar.c index d92e79d1ca..1637958d99 100644 --- a/src/lib/elementary/efl_ui_progressbar.c +++ b/src/lib/elementary/efl_ui_progressbar.c @@ -841,17 +841,16 @@ elm_progressbar_part_value_get(const Evas_Object *obj, const char *part) EAPI Eina_Bool elm_progressbar_horizontal_get(const Evas_Object *obj) { - Efl_Ui_Dir dir; - dir = efl_ui_direction_get(obj); + EFL_UI_PROGRESSBAR_DATA_GET_OR_RETURN(obj, sd, EINA_FALSE); - return _is_horizontal(dir); + return _is_horizontal(sd->dir); } EAPI void elm_progressbar_inverted_set(Evas_Object *obj, Eina_Bool inverted) { Efl_Ui_Dir dir; - EFL_UI_PROGRESSBAR_DATA_GET(obj, sd); + EFL_UI_PROGRESSBAR_DATA_GET_OR_RETURN(obj, sd); dir = _direction_get(_is_horizontal(sd->dir), inverted); @@ -861,17 +860,16 @@ elm_progressbar_inverted_set(Evas_Object *obj, Eina_Bool inverted) EAPI Eina_Bool elm_progressbar_inverted_get(const Evas_Object *obj) { - Efl_Ui_Dir dir; - dir = efl_ui_direction_get(obj); + EFL_UI_PROGRESSBAR_DATA_GET_OR_RETURN(obj, sd, EINA_FALSE); - return _is_inverted(dir); + return _is_inverted(sd->dir); } EAPI void elm_progressbar_horizontal_set(Evas_Object *obj, Eina_Bool horizontal) { Efl_Ui_Dir dir; - EFL_UI_PROGRESSBAR_DATA_GET(obj, sd); + EFL_UI_PROGRESSBAR_DATA_GET_OR_RETURN(obj, sd); dir = _direction_get(horizontal, _is_inverted(sd->dir));