orbea
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Widget: Don't check if it's the correct class everywhere. 

ELM_WIDGET_DATA_GET was checking it was the correct class. This is
stupid and wrong (and makes tools rightfully complain) because these
functions are implementations of that class anyway, so that would never
be false.
Functions that outside facing (that is, not called from eo_do) should
use API_ENTRY.
This commit is contained in:
Tom Hacohen 2014-01-06 14:58:18 +00:00
parent 4660142cc1
commit b01433ff47
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
legacy/elementary/src/lib/elm_widget.c
View File

@ -16,8 +16,7 @@ EAPI Eo_Op ELM_WIDGET_BASE_ID = EO_NOOP;
#define MY_CLASS_NAME_LEGACY "elm_widget"
#define ELM_WIDGET_DATA_GET(o, wd) \
Elm_Widget_Smart_Data *wd = NULL; \
if (eo_isa(o, MY_CLASS)) wd = eo_data_scope_get(o, MY_CLASS)
Elm_Widget_Smart_Data *wd = eo_data_scope_get(o, MY_CLASS)
#define API_ENTRY \
ELM_WIDGET_DATA_GET(obj, sd); \