orbea
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

elm_part: Mark as auto-unref before finalize 

This simplifies the IMPLEMENT macro, which can now be a proper function.
Also, do not set a parent for the part object, as it's not useful and
could mess up the refcount.
This commit is contained in:
Jean-Philippe Andre 2017-11-24 16:19:21 +09:00
parent 7e785d936d
commit dee149f3aa
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/lib/elementary/elm_part_helper.h
View File

@ -1,6 +1,9 @@
#ifndef _ELM_PART_HELPER_H
#define _ELM_PART_HELPER_H
#define EFL_OBJECT_BETA
#define EFL_OBJECT_PROTECTED
#include "Elementary.h"
#include "elm_priv.h"
#include "efl_ui_layout_part_legacy.eo.h"
@ -72,18 +75,19 @@ _elm_part_initialize(Eo *proxy, Eo *obj, const char *part)
EINA_SAFETY_ON_FALSE_RETURN_VAL(pd && obj && part, NULL);
efl_allow_parent_unref_set(proxy, 1);
// efl_auto_unref_set(proxy, 1);
efl_auto_unref_set(proxy, 1);
pd->part = eina_tmpstr_add(part);
pd->obj = obj;
return proxy;
}
#define ELM_PART_IMPLEMENT(PART_CLASS, _obj, _part) ({ \
Eo *proxy = efl_add(PART_CLASS, (Eo *) _obj, \
_elm_part_initialize(efl_added, (Eo *) _obj, _part)); \
efl_auto_unref_set(proxy, 1); \
proxy; })
static inline Eo *
ELM_PART_IMPLEMENT(const Efl_Class *part_klass, const Eo *obj, const char *part)
{
return efl_add(part_klass, NULL,
_elm_part_initialize(efl_added, (Eo *) obj, part));
}
#define ELM_PART_OVERRIDE_ONLY_ALIASES(type, TYPE, typedata, aliases) \
EOLIAN static Efl_Object * \