From f950e7990ffa38e3af8916b1e6a10cf392b9fc33 Mon Sep 17 00:00:00 2001 From: Sebastian Dransfeld Date: Sat, 7 Dec 2013 15:30:09 +0100 Subject: [PATCH] eldbus: free allocated mem on error Fixes CID 1039177 --- src/lib/eldbus/eldbus_service.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/eldbus/eldbus_service.c b/src/lib/eldbus/eldbus_service.c index 4c793c8a1c..4cd8a482e8 100644 --- a/src/lib/eldbus/eldbus_service.c +++ b/src/lib/eldbus/eldbus_service.c @@ -893,8 +893,8 @@ _eldbus_service_interface_desc_signals_signatures_get( Eina_Strbuf *buf = eina_strbuf_new(); Eina_Array *signatures = eina_array_new(1); - EINA_SAFETY_ON_NULL_RETURN_VAL(buf, NULL); - EINA_SAFETY_ON_NULL_RETURN_VAL(signatures, NULL); + EINA_SAFETY_ON_NULL_GOTO(buf, fail_signature); + EINA_SAFETY_ON_NULL_GOTO(signatures, fail_signature); for (sig = desc->signals; sig && sig->name; sig++) { @@ -919,8 +919,8 @@ _eldbus_service_interface_desc_signals_signatures_get( return signatures; fail_signature: - eina_strbuf_free(buf); - eina_array_free(signatures); + if (buf) eina_strbuf_free(buf); + if (signatures) eina_array_free(signatures); return NULL; }