From fd85423ae3eb2b9925daf84f164d1bf903ebfed7 Mon Sep 17 00:00:00 2001 From: Hermet Park Date: Fri, 20 Apr 2018 13:29:46 +0900 Subject: [PATCH] ecore: fix a potential memory leak. if the func argument is null, allocated memory won't be freed properly. return it as soon as possible. @fix --- src/lib/ecore/ecore_timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/ecore/ecore_timer.c b/src/lib/ecore/ecore_timer.c index ac6fb853dc..1ebce1f3df 100644 --- a/src/lib/ecore/ecore_timer.c +++ b/src/lib/ecore/ecore_timer.c @@ -174,13 +174,13 @@ ecore_timer_add(double in, Ecore_Task_Cb func, const void *data) Eo *timer; EINA_MAIN_LOOP_CHECK_RETURN_VAL(NULL); - legacy = calloc(1, sizeof (Ecore_Timer_Legacy)); - if (!legacy) return NULL; if (!func) { ERR("Callback function must be set up for the class."); return NULL; } + legacy = calloc(1, sizeof (Ecore_Timer_Legacy)); + if (!legacy) return NULL; legacy->func = func; legacy->data = data; timer = efl_add(MY_CLASS, efl_main_loop_get(),