Summary:
This patch focuses on Combobox widget customization,
Multibuttonentry widget is used instead of entry for taking user input.
The idea is to make the widget look like {F28112} {F28115} when the multiple_selection is set.
To-DO:
1) Need to add scrollable interface to combobox when MBE is used (need some suggestions on it).
2) focus cycle is still buggy as genlist requires focus otherwise selected item will return NULL (sometimes)
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
@feature
Test Plan: Please run combobox multiple selection example from elementart_test.
Reviewers: raster, shilpasingh, cedric
Subscribers: govi, rajeshps
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D3570
Summary:
The size of Colorclass is 20 bytes, but that of Elm_Color_Overlay 16 bytes.
Currently, there is no code to access last 4 bytes, but it can cause
seg fault by another patch.
Reviewers: cedric, zmike
Differential Revision: https://phab.enlightenment.org/D3784
so in feb 2015 seoz changed elm_genlist_item_index_get to start from 1
rather than 0. going back to elm code in 1.7 - it started at 0. this
is an api break that shouldn't have happend, but did. this fixes that.
yes - it's inconsistent with gengrid's index_get - but gengrid here is
wrong. nth_get starts at 0. this will get fixed with eo api's, and in
fact none of these index/nth api's should be in genlist's eo api.
legacy only. i can see why this was changed - it matches gengrid and
is more consistent, but we can't break things even if stupid.
@fix
eo.h and eo.c were added by mistake.
I couldn't quite test the build since the we still need ewekbit2
for configure to enable elm_web. @cedric has a bit of work left
here :)
This reverts commit 9f4c43c20dfa36e7a8be18278acf4336c13574d7.
I'm sorry but this causes a side effect(list sizing issue) at enventor.
And I couldn't find any mis-usage in enventor side.
We can't not accept this patch unless we figure the exact reason out.
Summary: This clarifies the documentation of the new api.
Reviewers: SanghyeonLee, shilpasingh, cedric
Reviewed By: cedric
Subscribers: bu5hm4n, buds
Differential Revision: https://phab.enlightenment.org/D3725
Summary:
elm_fileselector_buttons_ok_cancel_set() API checks the existence of
ok button before adding it.
This patch makes condition statement more intuitive.
Reviewers: cedric, bu5hm4n
Differential Revision: https://phab.enlightenment.org/D3770
======
CC libelementary_la-elm_interface_atspi_value.lo
elm_interface_atspi_image.c: In function '_elm_interface_atspi_image_description_set':
elm_interface_atspi_image.c:36:9: warning: 'old_descr' may be used uninitialized in this function [-Wmaybe-uninitialized]
eina_stringshare_del(old_descr);
^
======
Summary:
- in dump_cb buf is allocated by malloc() ->strdup() -> free.
This is needless.
- And buf allocated in dump_cb is strdup again.
This may cause memory leak.
Reviewers: Hermet, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3752
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When item_show / scrolling is happening, _item_block_position will be
called from smart_calculate where item width is set as block width.
If items are not realized _item_realize will be called and if items are
getting realized for first time we set mincalcd as false. So later
item width gets overwritten by min width of item and so issue is happening.
@fix T2603
Signed-off-by: godly.talias <godly.talias@samsung.com>
Test Plan: elementary_test -> Genlist Group -> show 480
Reviewers: prince.dubey, shilpasingh, SanghyeonLee, cedric
Subscribers: rajeshps, seoz, govi
Maniphest Tasks: T2603
Differential Revision: https://phab.enlightenment.org/D3729
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: This API will return the number of items that have passed the filter at a given point of time. If the API is called before "filter,done" callback comes, it may or may not give the filtered count for the complete genlist.
Test Plan: Updated Genlist_filter example to print the output from filtered_count_get API in "filter,done" callback.
Reviewers: SanghyeonLee, shilpasingh, cedric
Reviewed By: cedric
Subscribers: buds
Differential Revision: https://phab.enlightenment.org/D3725
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
refine code and theme, hopefully solve the issue
that the height of file list (genlist) is calculated wrong.
Test Plan: elementary_test -to fileselector
Reviewers: SanghyeonLee, jpeg, cedric
Subscribers: taxi2se
Differential Revision: https://phab.enlightenment.org/D3715
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: mapi have to be set NULL after free(m->api)
Reviewers: kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3756
I just ran my script (email to follow) to migrate all of the EFL
automatically. This commit is *only* the automatic conversion, so it can
be easily reverted and re-run.
If the scale is set on an object before contents are set, it will not
pass to them. Because of this, in the test, scale of the first label
remains 1.0, i.e the window scale, instead of 0.5.
The patch modifies the order of the instructions by setting the scale
after setting the label as content of the frame.
Summary: Radio inherits from Check now and remove the duplicate codes
Reviewers: yashu21985, cedric, tasn, raster
Reviewed By: raster
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3747
Switch to use a lcov config file which geninfo_auto_base and remove hard coding
the base dir to src/lib. geninfo_auto_base is designed for a use case like
ours where we have several base dirs (lib, bin, tests, ...) and it detects them
automatically. This fixes failures in a coverage run like this:
genhtml: ERROR: cannot read
/srv/build/workspace/manual_elm_gcc_x86_64_exactness_coverage/src/lib/test_win_state.c
Where the file is simply looked for in the wrong directory.
gcc thinks the vars may in theory be uniitiialized. it's right but it
won't actually happen. but having noise in warning output is bad, so
fix the warnings so we can focus on the real bugs/issues/warnings
Summary:
After genlist/genrid items are cleared, item highlight still
remains in blank space. This patch fixes this by updating highlight.
Test Plan:
elementary_test -to fileselector
enter blank directory and see highlight still remains
Reviewers: jpeg, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3683
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Check for all error conditions case in elm_spinner_label_format_set
and set label format only if its valid.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@feature
Test Plan:
1. Launch elementary test spinner
2. Set invalid formats e.g. formats with out %, formats with more than
one format specifier "%d %s" etc:-
Reviewers: jpeg, cedric
Reviewed By: cedric
Subscribers: govi, buds, subodh6129
Differential Revision: https://phab.enlightenment.org/D3720
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
without size hints on the edje object, a list item will never be sized
accurately, meaning that the size hints set on subobjects (icon, end) are
ignored in nearly all cases, and any previous sizing which was accurate was,
in fact, merely coincidentally accurate
@fix
typecast const char * to void * and pass ptr to free() since it doesn't modify the value pointed to,
either conceptually or in practice, it merely looks up the memory block using the pointer and deallocates it.
@fix
if a content's size hints change, reapplying the list's size hints
to override existing hints is required to prevent some list items from
having a bad layout
@fix
Summary: In "compile with" comment, filenames are different from the actual ones.
Reviewers: cedric, Oleksander, Hermet
Reviewed By: Oleksander, Hermet
Differential Revision: https://phab.enlightenment.org/D3722
Summary:
move focus out of genlist by pressing "up" key when no item
is selected.
Test Plan: elementary_test -to fileselector
Reviewers: SanghyeonLee, cedric, Jaehyun_Cho, Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3721
Summary:
fix the wrong operation of mirrored set.
when mirrored set is applied, notify change the theme using mirrored flag.
however, it is unnecessary operation.
@fix
Reviewers: Hermet, kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3700
Summary: No use of top object if not editable.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3719
Move declarations of types used in elm_widget.eo to elm_general.eot and
elm_widget.eo.
Give them a Eolian name and use it instead of the old ones.
Correct the type name of some other types used as method parameters, by
using the Eolian names instead of legacy/generated names.
Reorganize the positions of elm_widget.eo.h inclusion and
of callback type declarations in elm_widget.h.
This make a clearer distinction of the types in elm_widget.h that are
still required in elm_widget.eo.h.
using requested size may not be correct, so use real size. this should
solve issues in some wm's and actually also solved some kind of object
size lag in wayland too.
@fix - onward from 79b6edd1a6ad763258337b7aac5bd7799411bb44
Summary:
- icon param add an elm_icon and content set to icon part.
- entry's style is changing as other params are set and
icon part may not exist in certain condition(default has no icon part)
- checking icon param later than other params will set icon part
after the style is changed.
Reviewers: cedric, woohyun, jpeg, herdsman, tasn
Reviewed By: tasn
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D3693
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
when using a touchpad or frictionless mouse wheel, it becomes impossible
to accurately use a scroller which accelerates as scrollers on mobile devices
do. by setting this new option to 0, acceleration can be disabled and regular
behavior can be restored
ref 2ac2628612060114cf6e5205e5331044221178c6
@feature
when I scroll on a computer, I want my app to respond immediately. I don't
want to wait for it to finish scrolling and I don't want to have to guess
where the scroll will end.
ref 2ac2628612060114cf6e5205e5331044221178c6
@feature
we dont set this config by default so we dont see this - but a window
starts as withdrawn then becomes normal. this means the window starts
not rendering and may take 0.5 seconds to START because the eval is
deferred by 0.5 sec to avoid rapid switch to/from norender and other
states.
@fix
this fixes excess callbacks on window (and content) objhects resizing
down then back up again when windows are forcibly resized like
fullscreen, maximized and remembered windows.
@fix