resi
/
enlightenment
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Broken multi-file drops... 

Kevin Brosius <cobra@compuserve.com>


SVN revision: 5757
This commit is contained in:
sleuth 2001-12-08 21:07:44 +00:00 committed by sleuth
parent 3e72ecf27a
commit 2663676042
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/view.c
View File

@ -2555,7 +2555,9 @@ e_view_init(void)
/* /*
* send the dnd data to the target app * send the dnd data to the target app
* *
* uri-list (http://www.faqs.org/rfcs/rfc2483.html)
* URL formatting per RFC 1738 * URL formatting per RFC 1738
* (or not. Looks like a lot of apps ignore this. So do we! )
*/ */
static void static void
e_dnd_data_request(Ecore_Event * ev) e_dnd_data_request(Ecore_Event * ev)
@ -2610,7 +2612,7 @@ e_dnd_data_request(Ecore_Event * ev)
{ {
if (e->uri_list) if (e->uri_list)
{ {
int first = 1; /* int first = 1;*/
for (ll = v->icons; ll; ll = ll->next) for (ll = v->icons; ll; ll = ll->next)
{ {
@ -2625,13 +2627,22 @@ e_dnd_data_request(Ecore_Event * ev)
size += ic_size; size += ic_size;
REALLOC(data, char, size); REALLOC(data, char, size);
/*
* What's this for? It ends up double terminating
* the second and further files, plus the length
* needs to be adjusted for both cases...
* (And the wrong length breaks multi-file drops.)
if (first) if (first)
{ {
sprintf(data + idx, "file:%s/%s", v->dir, ic->file); */
sprintf(data + idx, "file:%s/%s\r\n", v->dir, ic->file);
#if 0
first = 0; first = 0;
} }
else else
sprintf(data + idx, "\r\nfile:%s/%s\r\n", v->dir, ic->file); sprintf(data + idx, "\r\nfile:%s/%s\r\n", v->dir, ic->file);
#endif
idx += ic_size; idx += ic_size;
} }
} }
@ -2855,8 +2866,6 @@ e_dnd_drop_request(Ecore_Event * ev)
/* if the dnd source is e itself then dont use the event mode */ /* if the dnd source is e itself then dont use the event mode */
if (e_view_find_by_window(e->source_win)) if (e_view_find_by_window(e->source_win))
{ {
E_View *vv;
v = e_view_find_by_window(e->source_win); v = e_view_find_by_window(e->source_win);
dnd_pending_mode = v->drag.drop_mode; dnd_pending_mode = v->drag.drop_mode;
} }