From 41e60d251ecb2acf9c1c92715b4335ac7bc364a2 Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Thu, 1 Dec 2016 10:55:49 -0600 Subject: [PATCH] Stop sending key up/down events on focus change under wayland We shouldn't be doing this, but there's a collective memory that this was put in place to fix stuck modifier bugs. If we run into stuck modifiers again because of this patch, then we should be fixing them in a different way. If anyone bisects to this point, I apologize - assign me a ticket. --- src/bin/e_comp_wl.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/bin/e_comp_wl.c b/src/bin/e_comp_wl.c index 57dc97500..01a5ac0c6 100644 --- a/src/bin/e_comp_wl.c +++ b/src/bin/e_comp_wl.c @@ -608,10 +608,6 @@ _e_comp_wl_evas_cb_focus_in_timer(E_Client *ec) e_comp_wl_input_keyboard_modifiers_update(); serial = wl_display_next_serial(e_comp_wl->wl.disp); t = ecore_time_unix_get(); - EINA_LIST_FOREACH(e_comp_wl->kbd.focused, l, res) - wl_array_for_each(k, &e_comp_wl->kbd.keys) - wl_keyboard_send_key(res, serial, t, - *k, WL_KEYBOARD_KEY_STATE_PRESSED); return EINA_FALSE; } @@ -703,9 +699,6 @@ _e_comp_wl_keyboard_leave(E_Client *ec) t = ecore_time_unix_get(); EINA_LIST_FOREACH_SAFE(e_comp_wl->kbd.focused, l, ll, res) { - wl_array_for_each(k, &e_comp_wl->kbd.keys) - wl_keyboard_send_key(res, serial, t, - *k, WL_KEYBOARD_KEY_STATE_RELEASED); if (ec->comp_data->surface) wl_keyboard_send_leave(res, serial, ec->comp_data->surface); e_comp_wl->kbd.focused = eina_list_remove_list(e_comp_wl->kbd.focused, l);