From a85a602a39642285b5ebabebfb089b5c662ddee9 Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Tue, 26 Sep 2017 14:19:24 -0500 Subject: [PATCH] Revert "Set close on exec for stdin" This reverts commit 40e8bb044c049d7a3a16f61aebef6ea6977509ce. EFL master solves this properly EFL stable currently has a bug that solves this accidentally so there's a window of about 3 commits in git where it's a problem, and nobody should run those commits in production :) This fix caused some problems when restarting E, as stdin would cloexec and then the following startup would try to set cloexec on an invalid fd and generate an err that generated a cri because of an invalid log domain. Someone should probably figure out the log domain thing. --- src/bin/e_main.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/bin/e_main.c b/src/bin/e_main.c index a69371126..98676ca18 100644 --- a/src/bin/e_main.c +++ b/src/bin/e_main.c @@ -233,16 +233,6 @@ main(int argc, char **argv) #endif TS("Begin Startup"); - /* When running as a wayland compositor, if a child process has - * access to stdin it can issue some pretty sketchy ioctl()s - * and mess with the console. So let's just set close_on_exec. - * It may be better to fix this in EFL's ecore_exe_run in some - * way, but it will be a while until a stable EFL release has - * it sorted... - */ - eina_file_close_on_exec(STDIN_FILENO, EINA_TRUE); - /* */ - /* trap deadly bug signals and allow some form of sane recovery */ /* or ability to gdb attach and debug at this point - better than your */ /* wm/desktop vanishing and not knowing what happened */