forked from enlightenment/efl
ecore: Don't call _ecore_fd_valid() in release builds
Not sure _ecore_fd_valid() is all that useful anymore, as the commit that introduced it said it would be removed "before release" a long time ago - it's a debug assist that probably doesn't need to be in release builds. (I'm counting syscalls on rpi3 - still, calling this an optimization seems like a bit of a stretch.)
This commit is contained in:
parent
e3bdfae54c
commit
44804a9579
|
@ -86,16 +86,21 @@ esac
|
||||||
|
|
||||||
prefer_assert="no"
|
prefer_assert="no"
|
||||||
eina_log_backtrace="yes"
|
eina_log_backtrace="yes"
|
||||||
|
efl_less_insane="no"
|
||||||
case "${build_profile}" in
|
case "${build_profile}" in
|
||||||
dev|debug)
|
dev|debug)
|
||||||
prefer_assert="yes"
|
prefer_assert="yes"
|
||||||
eina_log_backtrace="no"
|
eina_log_backtrace="no"
|
||||||
|
efl_less_insane="yes"
|
||||||
;;
|
;;
|
||||||
esac
|
esac
|
||||||
|
|
||||||
# Enable CRI & ERR backtrace by default for release but not for dev/debug
|
# Enable CRI & ERR backtrace by default for release but not for dev/debug
|
||||||
AC_DEFINE_IF([EINA_LOG_BACKTRACE_ENABLE], [test "x${eina_log_backtrace}" = "xyes"], [1], [Default log level triggering backtraces])
|
AC_DEFINE_IF([EINA_LOG_BACKTRACE_ENABLE], [test "x${eina_log_backtrace}" = "xyes"], [1], [Default log level triggering backtraces])
|
||||||
|
|
||||||
|
# Additional sanity checks only performed in debug builds
|
||||||
|
AC_DEFINE_IF([EFL_EXTRA_SANITY_CHECKS], [test "x${efl_less_insane}" = "xyes"], [1], [Extra run time sanity checks])
|
||||||
|
|
||||||
# TODO: add some build "profile" (server, full, etc...)
|
# TODO: add some build "profile" (server, full, etc...)
|
||||||
|
|
||||||
AC_ARG_WITH([crypto],
|
AC_ARG_WITH([crypto],
|
||||||
|
|
|
@ -344,6 +344,7 @@ _ecore_fd_close_on_exec(int fd)
|
||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#ifdef EFL_EXTRA_SANITY_CHECKS
|
||||||
static inline void
|
static inline void
|
||||||
_ecore_fd_valid(void)
|
_ecore_fd_valid(void)
|
||||||
{
|
{
|
||||||
|
@ -360,6 +361,7 @@ _ecore_fd_valid(void)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
#endif
|
||||||
|
|
||||||
static inline void
|
static inline void
|
||||||
_ecore_try_add_to_call_list(Ecore_Fd_Handler *fdh)
|
_ecore_try_add_to_call_list(Ecore_Fd_Handler *fdh)
|
||||||
|
@ -1997,7 +1999,9 @@ _ecore_main_fd_handlers_call(void)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
fdh->references--;
|
fdh->references--;
|
||||||
|
#ifdef EFL_EXTRA_SANITY_CHECKS
|
||||||
_ecore_fd_valid();
|
_ecore_fd_valid();
|
||||||
|
#endif
|
||||||
|
|
||||||
fdh->read_active = EINA_FALSE;
|
fdh->read_active = EINA_FALSE;
|
||||||
fdh->write_active = EINA_FALSE;
|
fdh->write_active = EINA_FALSE;
|
||||||
|
|
Loading…
Reference in New Issue