From ead7f10c0953d0ec1cfa978796b4b6a639be1620 Mon Sep 17 00:00:00 2001 From: Christopher Michael Date: Tue, 12 Mar 2019 09:41:00 -0400 Subject: [PATCH] efl_core_command_line: Fix logically dead code Small patch to remove logically dead code. Coverity reports that execution cannot reach the expression 0U inside this for statement. At this point in execution, 'array' cannot be NULL, so checking for its existence is a logically dead check. Fixes Coverity CID1399106 @fix Reviewed-by: Stefan Schmidt Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D8306 --- src/lib/ecore/efl_core_command_line.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ecore/efl_core_command_line.c b/src/lib/ecore/efl_core_command_line.c index 424dd3486a..54d21281d8 100644 --- a/src/lib/ecore/efl_core_command_line.c +++ b/src/lib/ecore/efl_core_command_line.c @@ -223,7 +223,7 @@ _efl_core_command_line_command_array_set(Eo *obj EINA_UNUSED, Efl_Core_Command_L eina_stringshare_del(eina_array_pop(pd->command)); eina_array_free(pd->command); pd->command = NULL; - for (;i < (array ? eina_array_count(array) : 0); ++i) + for (;i < eina_array_count(array); ++i) { content = eina_array_data_get(array, i); eina_stringshare_del(content);